From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] reorder: add checks for invalid function inputs
Date: Thu, 11 Apr 2019 08:43:26 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260D87B7B@IRSMSX108.ger.corp.intel.com> (raw)
Message-ID: <20190411084326.JNBYnv48ki9jVsC6EEDGUcS1shPE7qxh4rlQFQgnUeE@z> (raw)
In-Reply-To: <20190410112447.68386-1-bruce.richardson@intel.com>
> -----Original Message-----
> From: Richardson, Bruce
> Sent: Wednesday, April 10, 2019 12:25 PM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Subject: [PATCH] reorder: add checks for invalid function inputs
>
> For APIs which can return an error value, do sanity checking of the input
> parameters for NULL and return a suitable error value for those cases.
>
> NOTE: The drain function is currently omitting NULL checks too, but this
> function has no way to flag an error value, so checking in that case would
> simply mask problems.
>
> Reported-by: Bernard Iremonger <bernard.iremonger@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
next prev parent reply other threads:[~2019-04-11 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 11:24 Bruce Richardson
2019-04-10 11:24 ` Bruce Richardson
2019-04-11 8:43 ` Iremonger, Bernard [this message]
2019-04-11 8:43 ` Iremonger, Bernard
2019-04-22 17:37 ` Thomas Monjalon
2019-04-22 17:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260D87B7B@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).