From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4A041A0096 for ; Thu, 11 Apr 2019 10:43:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 695575B40; Thu, 11 Apr 2019 10:43:31 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E2D245B2E for ; Thu, 11 Apr 2019 10:43:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 01:43:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,336,1549958400"; d="scan'208";a="141819979" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 11 Apr 2019 01:43:28 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 09:43:27 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.82]) by irsmsx112.ger.corp.intel.com ([169.254.1.101]) with mapi id 14.03.0415.000; Thu, 11 Apr 2019 09:43:27 +0100 From: "Iremonger, Bernard" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [PATCH] reorder: add checks for invalid function inputs Thread-Index: AQHU75AGRg4Gu8ma/E2G1o6UqqjwOaY2pd8Q Date: Thu, 11 Apr 2019 08:43:26 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D87B7B@IRSMSX108.ger.corp.intel.com> References: <20190410112447.68386-1-bruce.richardson@intel.com> In-Reply-To: <20190410112447.68386-1-bruce.richardson@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTRhN2ZhMzktMTRmZS00OTllLWJhMGMtYmRiYTY2NmIzMTY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVnRjQWJLemt4VzArRzN1NlozM1J0RTY2cElHbmRvOCtNeng3OHEzMTJxK2YzbUR3aWdaVHBuaVFUVmk5ZmlaayJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] reorder: add checks for invalid function inputs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190411084326.JNBYnv48ki9jVsC6EEDGUcS1shPE7qxh4rlQFQgnUeE@z> > -----Original Message----- > From: Richardson, Bruce > Sent: Wednesday, April 10, 2019 12:25 PM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; Richardson, Bruce > > Subject: [PATCH] reorder: add checks for invalid function inputs >=20 > For APIs which can return an error value, do sanity checking of the input > parameters for NULL and return a suitable error value for those cases. >=20 > NOTE: The drain function is currently omitting NULL checks too, but this > function has no way to flag an error value, so checking in that case woul= d > simply mask problems. >=20 > Reported-by: Bernard Iremonger > Signed-off-by: Bruce Richardson Acked-by: Bernard Iremonger