* [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value
@ 2019-04-11 11:13 Reshma Pattan
2019-04-11 11:13 ` Reshma Pattan
2019-04-11 12:07 ` Burakov, Anatoly
0 siblings, 2 replies; 6+ messages in thread
From: Reshma Pattan @ 2019-04-11 11:13 UTC (permalink / raw)
To: dev; +Cc: Reshma Pattan, david.hunt, stable
Fix the data type of last_branches, last_branch_misses
from unit32_t to uint64_t, and for hits_diff, miss_diff
from int to int64_t respectively to fix possible
overflow or truncation.
Coverity issue: 337677
Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
CC: david.hunt@intel.com
CC: stable@dpdk.org
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
examples/vm_power_manager/oob_monitor_x86.c | 23 ++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/examples/vm_power_manager/oob_monitor_x86.c b/examples/vm_power_manager/oob_monitor_x86.c
index 589c604e5..ebd96b205 100644
--- a/examples/vm_power_manager/oob_monitor_x86.c
+++ b/examples/vm_power_manager/oob_monitor_x86.c
@@ -33,10 +33,10 @@ static float
apply_policy(int core)
{
struct core_info *ci;
- uint64_t counter;
+ uint64_t counter = 0;
uint64_t branches, branch_misses;
- uint32_t last_branches, last_branch_misses;
- int hits_diff, miss_diff;
+ uint64_t last_branches, last_branch_misses;
+ int64_t hits_diff, miss_diff;
float ratio;
int ret;
@@ -54,6 +54,7 @@ apply_policy(int core)
core);
branches = counter;
+ counter = 0;
ret = pread(ci->cd[core].msr_fd, &counter,
sizeof(counter), IA32_PERFCTR1);
if (ret < 0)
@@ -66,13 +67,25 @@ apply_policy(int core)
ci->cd[core].last_branches = branches;
ci->cd[core].last_branch_misses = branch_misses;
- hits_diff = (int)branches - (int)last_branches;
+ /*
+ * Intentional right shift to make MSB 0 to avoid
+ * possible signed overflow or truncation.
+ */
+ branches >>= 1;
+ last_branches >>= 1;
+ hits_diff = (int64_t)branches - (int64_t)last_branches;
if (hits_diff <= 0) {
/* Likely a counter overflow condition, skip this round */
return -1.0;
}
- miss_diff = (int)branch_misses - (int)last_branch_misses;
+ /*
+ * Intentional right shift to make MSB 0 to avoid
+ * possible signed overflow or truncation.
+ */
+ branch_misses >>= 1;
+ last_branch_misses >>= 1;
+ miss_diff = (int64_t)branch_misses - (int64_t)last_branch_misses;
if (miss_diff <= 0) {
/* Likely a counter overflow condition, skip this round */
return -1.0;
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value
2019-04-11 11:13 [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value Reshma Pattan
@ 2019-04-11 11:13 ` Reshma Pattan
2019-04-11 12:07 ` Burakov, Anatoly
1 sibling, 0 replies; 6+ messages in thread
From: Reshma Pattan @ 2019-04-11 11:13 UTC (permalink / raw)
To: dev; +Cc: Reshma Pattan, david.hunt, stable
Fix the data type of last_branches, last_branch_misses
from unit32_t to uint64_t, and for hits_diff, miss_diff
from int to int64_t respectively to fix possible
overflow or truncation.
Coverity issue: 337677
Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
CC: david.hunt@intel.com
CC: stable@dpdk.org
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
examples/vm_power_manager/oob_monitor_x86.c | 23 ++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/examples/vm_power_manager/oob_monitor_x86.c b/examples/vm_power_manager/oob_monitor_x86.c
index 589c604e5..ebd96b205 100644
--- a/examples/vm_power_manager/oob_monitor_x86.c
+++ b/examples/vm_power_manager/oob_monitor_x86.c
@@ -33,10 +33,10 @@ static float
apply_policy(int core)
{
struct core_info *ci;
- uint64_t counter;
+ uint64_t counter = 0;
uint64_t branches, branch_misses;
- uint32_t last_branches, last_branch_misses;
- int hits_diff, miss_diff;
+ uint64_t last_branches, last_branch_misses;
+ int64_t hits_diff, miss_diff;
float ratio;
int ret;
@@ -54,6 +54,7 @@ apply_policy(int core)
core);
branches = counter;
+ counter = 0;
ret = pread(ci->cd[core].msr_fd, &counter,
sizeof(counter), IA32_PERFCTR1);
if (ret < 0)
@@ -66,13 +67,25 @@ apply_policy(int core)
ci->cd[core].last_branches = branches;
ci->cd[core].last_branch_misses = branch_misses;
- hits_diff = (int)branches - (int)last_branches;
+ /*
+ * Intentional right shift to make MSB 0 to avoid
+ * possible signed overflow or truncation.
+ */
+ branches >>= 1;
+ last_branches >>= 1;
+ hits_diff = (int64_t)branches - (int64_t)last_branches;
if (hits_diff <= 0) {
/* Likely a counter overflow condition, skip this round */
return -1.0;
}
- miss_diff = (int)branch_misses - (int)last_branch_misses;
+ /*
+ * Intentional right shift to make MSB 0 to avoid
+ * possible signed overflow or truncation.
+ */
+ branch_misses >>= 1;
+ last_branch_misses >>= 1;
+ miss_diff = (int64_t)branch_misses - (int64_t)last_branch_misses;
if (miss_diff <= 0) {
/* Likely a counter overflow condition, skip this round */
return -1.0;
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value
2019-04-11 11:13 [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value Reshma Pattan
2019-04-11 11:13 ` Reshma Pattan
@ 2019-04-11 12:07 ` Burakov, Anatoly
2019-04-11 12:07 ` Burakov, Anatoly
2019-04-22 21:17 ` Thomas Monjalon
1 sibling, 2 replies; 6+ messages in thread
From: Burakov, Anatoly @ 2019-04-11 12:07 UTC (permalink / raw)
To: Reshma Pattan, dev; +Cc: david.hunt, stable
On 11-Apr-19 12:13 PM, Reshma Pattan wrote:
> Fix the data type of last_branches, last_branch_misses
> from unit32_t to uint64_t, and for hits_diff, miss_diff
> from int to int64_t respectively to fix possible
> overflow or truncation.
>
> Coverity issue: 337677
> Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
> CC: david.hunt@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value
2019-04-11 12:07 ` Burakov, Anatoly
@ 2019-04-11 12:07 ` Burakov, Anatoly
2019-04-22 21:17 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Burakov, Anatoly @ 2019-04-11 12:07 UTC (permalink / raw)
To: Reshma Pattan, dev; +Cc: david.hunt, stable
On 11-Apr-19 12:13 PM, Reshma Pattan wrote:
> Fix the data type of last_branches, last_branch_misses
> from unit32_t to uint64_t, and for hits_diff, miss_diff
> from int to int64_t respectively to fix possible
> overflow or truncation.
>
> Coverity issue: 337677
> Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
> CC: david.hunt@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value
2019-04-11 12:07 ` Burakov, Anatoly
2019-04-11 12:07 ` Burakov, Anatoly
@ 2019-04-22 21:17 ` Thomas Monjalon
2019-04-22 21:17 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-22 21:17 UTC (permalink / raw)
To: Reshma Pattan; +Cc: dev, Burakov, Anatoly, david.hunt, stable
11/04/2019 14:07, Burakov, Anatoly:
> On 11-Apr-19 12:13 PM, Reshma Pattan wrote:
> > Fix the data type of last_branches, last_branch_misses
> > from unit32_t to uint64_t, and for hits_diff, miss_diff
> > from int to int64_t respectively to fix possible
> > overflow or truncation.
> >
> > Coverity issue: 337677
> > Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
> > CC: david.hunt@intel.com
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value
2019-04-22 21:17 ` Thomas Monjalon
@ 2019-04-22 21:17 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-22 21:17 UTC (permalink / raw)
To: Reshma Pattan; +Cc: dev, Burakov, Anatoly, david.hunt, stable
11/04/2019 14:07, Burakov, Anatoly:
> On 11-Apr-19 12:13 PM, Reshma Pattan wrote:
> > Fix the data type of last_branches, last_branch_misses
> > from unit32_t to uint64_t, and for hits_diff, miss_diff
> > from int to int64_t respectively to fix possible
> > overflow or truncation.
> >
> > Coverity issue: 337677
> > Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions")
> > CC: david.hunt@intel.com
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-22 21:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-11 11:13 [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value Reshma Pattan
2019-04-11 11:13 ` Reshma Pattan
2019-04-11 12:07 ` Burakov, Anatoly
2019-04-11 12:07 ` Burakov, Anatoly
2019-04-22 21:17 ` Thomas Monjalon
2019-04-22 21:17 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).