From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D3DD85B36; Thu, 11 Apr 2019 16:30:32 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 131A5C075D7B; Thu, 11 Apr 2019 14:30:32 +0000 (UTC) Received: from localhost (dhcp-192-206.str.redhat.com [10.33.192.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 297BC5D9CC; Thu, 11 Apr 2019 14:30:27 +0000 (UTC) Date: Thu, 11 Apr 2019 16:30:25 +0200 From: Jens Freimann To: Ilya Maximets Cc: dev@dpdk.org, Maxime Coquelin , Tiwei Bie , Dariusz Stojaczyk , David Marchand , stable@dpdk.org Message-ID: <20190411143025.aakhk7x7uhcvecrr@jenstp.localdomain> References: <20190411102306.11943-1-i.maximets@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190411102306.11943-1-i.maximets@samsung.com> User-Agent: NeoMutt/20180716-1376-5d6ed1 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 11 Apr 2019 14:30:32 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fix device leak on connection add failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2019 14:30:33 -0000 On Thu, Apr 11, 2019 at 01:23:06PM +0300, Ilya Maximets wrote: >Need to destroy allocated device if application fails to >add new connection or we have fdset failure. > >Fixes: acbff5c67ea7 ("vhost: fix crash when exceeding file descriptors") >Fixes: efba12a78ddf ("vhost: add user callbacks for socket open/close") >Cc: stable@dpdk.org > >Reported-by: David Marchand >Signed-off-by: Ilya Maximets >--- > lib/librte_vhost/socket.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Jens Freimann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8E883A0096 for ; Thu, 11 Apr 2019 16:30:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFBBB5B38; Thu, 11 Apr 2019 16:30:34 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D3DD85B36; Thu, 11 Apr 2019 16:30:32 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 131A5C075D7B; Thu, 11 Apr 2019 14:30:32 +0000 (UTC) Received: from localhost (dhcp-192-206.str.redhat.com [10.33.192.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 297BC5D9CC; Thu, 11 Apr 2019 14:30:27 +0000 (UTC) Date: Thu, 11 Apr 2019 16:30:25 +0200 From: Jens Freimann To: Ilya Maximets Cc: dev@dpdk.org, Maxime Coquelin , Tiwei Bie , Dariusz Stojaczyk , David Marchand , stable@dpdk.org Message-ID: <20190411143025.aakhk7x7uhcvecrr@jenstp.localdomain> References: <20190411102306.11943-1-i.maximets@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Disposition: inline In-Reply-To: <20190411102306.11943-1-i.maximets@samsung.com> User-Agent: NeoMutt/20180716-1376-5d6ed1 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 11 Apr 2019 14:30:32 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fix device leak on connection add failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190411143025.B-1mxSH5KVYTF72SALIYZ2rmdJCHrsXaVS_1w2AmiXI@z> On Thu, Apr 11, 2019 at 01:23:06PM +0300, Ilya Maximets wrote: >Need to destroy allocated device if application fails to >add new connection or we have fdset failure. > >Fixes: acbff5c67ea7 ("vhost: fix crash when exceeding file descriptors") >Fixes: efba12a78ddf ("vhost: add user callbacks for socket open/close") >Cc: stable@dpdk.org > >Reported-by: David Marchand >Signed-off-by: Ilya Maximets >--- > lib/librte_vhost/socket.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Jens Freimann