From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B942EA0096 for ; Sat, 13 Apr 2019 07:52:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E9B291B148; Sat, 13 Apr 2019 07:52:51 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 3C3481B134; Sat, 13 Apr 2019 07:52:49 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3D5eTlP013602; Fri, 12 Apr 2019 22:52:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=xT1ZkT7981Plp0bSnzI2RzvU3tkvVx6wfYuoWuN0OwQ=; b=e2HdeSI3w8z8qFlOXYtkTtn5IVMIi4QB1IW8BsCrx8b/qDl7QLiDb8rUN2CAuqtopEjb 8j6AFZ1VR0hEp1n0HnlU3MTxVX74gMmIcgT5AA2yyF7Ye78nUffGt+MADRRXjlniLqD2 3WkxunM3Svk4AuE8eE3qZyhRSiObG9L5tKoBEtb8KwmRTuFpD+mLx81qaQ993EZgpTNi Cfhkcs3tw3pUZYByMm4H6+T5dnYevJDI8bDN3ehi2uuE4oqUHhDV3JHBZLeiel14B7h0 ZZwJD9vwPkeRCsF1rI38m72JO5UojwHytRrGzPC3kd6sYdFWLkBM37yBjZSA9/dyPH8A vg== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2rtthau41s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2019 22:52:45 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 12 Apr 2019 22:52:44 -0700 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.55) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 12 Apr 2019 22:52:44 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xT1ZkT7981Plp0bSnzI2RzvU3tkvVx6wfYuoWuN0OwQ=; b=T1TORrNUSn+GuwX9rmJw08NTQUQeFn+QPaGBY0zlmmXyyv6BLGJbZ8Jbr0Vx4nf+MLyRyzDuQxj9pSmxANGAe8ITro2vdLiSoZ9CCP8wcDW0yx/CmjUyXQwI7nHQQVG172WAU1k0DnGwlLjLOKJZSTfhERMg+OkaObw6fvjYCok= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB2056.namprd18.prod.outlook.com (10.171.255.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.21; Sat, 13 Apr 2019 05:52:42 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d%3]) with mapi id 15.20.1792.016; Sat, 13 Apr 2019 05:52:42 +0000 From: Pavan Nikhilesh Bhagavatula To: Yongseok Koh , "bruce.richardson@intel.com" , Jerin Jacob Kollanukkaran , "shahafs@mellanox.com" CC: "dev@dpdk.org" , "thomas@monjalon.net" , "gavin.hu@arm.com" , "Honnappa.Nagarahalli@arm.com" , "stable@dpdk.org" Thread-Topic: [EXT] [PATCH 1/6] meson: disable octeontx for buggy compilers on arm64 Thread-Index: AQHU8Yb3AKhgrKcy6UO7I81I+80XLqY5j3Sg Date: Sat, 13 Apr 2019 05:52:42 +0000 Message-ID: References: <20190412232451.30197-1-yskoh@mellanox.com> <20190412232451.30197-2-yskoh@mellanox.com> In-Reply-To: <20190412232451.30197-2-yskoh@mellanox.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [49.205.218.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6dab56b3-b30f-4629-7f99-08d6bfd43ed7 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR1801MB2056; x-ms-traffictypediagnostic: CY4PR1801MB2056: x-microsoft-antispam-prvs: x-forefront-prvs: 00064751B6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(346002)(136003)(376002)(366004)(199004)(189003)(446003)(25786009)(186003)(7696005)(4326008)(5660300002)(6246003)(8936002)(3846002)(6116002)(81156014)(97736004)(6436002)(74316002)(105586002)(81166006)(76176011)(2501003)(256004)(7736002)(33656002)(476003)(11346002)(305945005)(14454004)(14444005)(110136005)(486006)(229853002)(106356001)(316002)(66066001)(71200400001)(52536014)(78486014)(99286004)(68736007)(478600001)(26005)(6506007)(71190400001)(53936002)(102836004)(86362001)(9686003)(54906003)(2906002)(8676002)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2056; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +AQtsJtyorAvmzGnf3fqx/ZHJquGzq1VQbD3IvsWcYMjS6+zochEq/pFWtPctxOEcDP600Mg2wI3KAPd0zBV/1WN2s06HT2mcoqUuALXFE6HwKPeW40eRD2pKfcSwsGNHfE1R/uqGQZhqeHc7Kiq4JPY13ApGyNYj/jNwtKIxf8tQjx827S7XXM2FY9vnY7rAfcM/8e2tZEkUBy1BTtarhgRgtk6czuI/EKeE288P5Yu+6USIDBsuQ8zgoFkNmdggJDZdrNp1UPpnICi40d/MkNUp4ZGmOpJ5PFP+/Uey6LthU4XYzcdaPNiAWwaCmSWgZbvrYzvteS7EQKk3mnWk9Aj5VpD9YqRqWmpruaBAZlj6DHpxtWf0uffV7cajhwz7YjzCzQkEfZoGQfHiUYog0Z0wCcFfd4dSZ0/ZZ4tfiw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6dab56b3-b30f-4629-7f99-08d6bfd43ed7 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2019 05:52:42.6115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2056 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-13_01:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH 1/6] meson: disable octeontx for buggy compilers on arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190413055242.dHrDtI4yDVHn0lBd_rYXeCzyqQyMsEWkhXyMmIus1ps@z> Hi Yongseok, >---------------------------------------------------------------------- >Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler = error" >for aarch64 > >Fixes: bd77f2d64c44 ("event/octeontx: build with meson") >Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers") >Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on >arm64") >Cc: pbhagavatula@marvell.com >Cc: jerinj@marvell.com >Cc: stable@dpdk.org > >Signed-off-by: Yongseok Koh >--- > drivers/event/meson.build | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/drivers/event/meson.build b/drivers/event/meson.build index >836ecbb74b..d364871d15 100644 >--- a/drivers/event/meson.build >+++ b/drivers/event/meson.build >@@ -1,7 +1,11 @@ > # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corpor= ation > >-drivers =3D ['dpaa', 'dpaa2', 'octeontx', 'opdl', 'skeleton', 'sw', 'dsw'= ] >+drivers =3D ['dpaa', 'dpaa2', 'opdl', 'skeleton', 'sw', 'dsw'] if >+(toolchain =3D=3D 'gcc' and cc.version().version_compare('>=3D4.8.6') and >+ dpdk_conf.has('RTE_ARCH_ARM64')) Can we make this similar to MAKEFILE[1] case where octeontx is enabled for = everycase except when=20 We are compiling for ARCH_ARM64 is set and compiler is less than < 4.8.6?. The reason being we want x86 CI to run (compilation part) to find any error= s. [1] ' ifeq ($(CONFIG_RTE_ARCH), arm64) ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo = 1), 1) CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=3Dd CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=3Dd CONFIG_RTE_LIBRTE_OCTEONTX_PMD=3Dd endif endif ' >+ drivers +=3D 'octeontx' >+endif > std_deps =3D ['eventdev', 'kvargs'] > config_flag_fmt =3D 'RTE_LIBRTE_@0@_EVENTDEV_PMD' > driver_name_fmt =3D 'rte_pmd_@0@_event' >-- >2.21.0.196.g041f5ea Regards, Pavan.