From: Thomas Monjalon <thomas@monjalon.net>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"yskoh@mellanox.com" <yskoh@mellanox.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags
Date: Sun, 14 Apr 2019 19:44:16 +0200 [thread overview]
Message-ID: <1966190.OdWs8lNuHB@xps> (raw)
Message-ID: <20190414174416.NhyZFgCfXaDetPw3ImEgYY6OPUAQgd6ZgHNkD0L2cck@z> (raw)
In-Reply-To: <CY4PR1801MB18637A51BF6B26C06A7F4BB7DE2A0@CY4PR1801MB1863.namprd18.prod.outlook.com>
14/04/2019 16:40, Pavan Nikhilesh Bhagavatula:
> Hi Thomas,
>
> There is no guarantee of primary part number (machine names) uniqueness between implementors.
I think we don't speak the same language :)
By machine name, I mean what we set in RTE_MACHINE, like octeontx2.
> If we limit lookups to only machine names through primary part number we would have a lot of repetitive defines.
> Also, moving the arrays into the python script is not feasible as meson needs to reparse the standard out from the python script
I will probably need to write a PoC.
> Currently, config is split into three parts :
> 1. Implementor specific defines.
> 2. Micro-arch specific compiler flags.
> 3. Micro-arch specific defines.
This is currently unreadable in my opinion.
> I think from a configurability point of view the above three are really important for fine grained control.
I agree fine grain is required.
> Thoughts?
>
> Regards,
> Pavan.
>
> >-----Original Message-----
> >From: Thomas Monjalon <thomas@monjalon.net>
> >Sent: Sunday, April 14, 2019 2:13 AM
> >To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> >Cc: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>;
> >dev@dpdk.org; jerinjacobk@gmail.com; yskoh@mellanox.com;
> >bruce.richardson@intel.com
> >Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine
> >specific flags
> >
> >13/04/2019 08:24, Jerin Jacob Kollanukkaran:
> >> > I was not confortable with this patch without being able to say why.
> >> > Yesterday I spent more time to understand and see what may be improved.
> >> > I agree it is late, so it won't block this patch for 19.05.
> >> > Do you agree this file can be improved?
> >>
> >> Moving to the all to static config file is an option but we lose the
> >> flexibility of runtime detecting the options and few of them are
> >> probing at runtime based on gcc versions and mcpu combination etc.
> >
> >I think there is a misunderstanding.
> >I'm suggesting to symplify arrays by indexing only by machine name.
> >It should not change the behaviour.
> >
> >> I am not expert in meson area and not sure meson/python has better
> >> data strcture for this other than list/array combo. If Bruce has any
> >> feedback on this, then we will try to prototype it.
> >>
> >> > Please would you like to look at reworking during next cycle?
> >> > Thanks
> >
> >
>
>
next prev parent reply other threads:[~2019-04-14 17:44 UTC|newest]
Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 13:20 [dpdk-dev] [PATCH 1/3] mk: introduce helper to check valid compiler argument Jerin Jacob Kollanukkaran
2019-01-06 13:20 ` [dpdk-dev] [PATCH 2/3] config: add thunderx2 machine config Jerin Jacob Kollanukkaran
2019-01-06 20:56 ` Thomas Monjalon
2019-01-07 5:27 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-01-07 0:21 ` [dpdk-dev] " Gavin Hu (Arm Technology China)
2019-01-07 5:29 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-01-06 13:20 ` [dpdk-dev] [PATCH 3/3] config: add octeontx2 " Jerin Jacob Kollanukkaran
2019-01-07 15:42 ` [dpdk-dev] [PATCH v2 1/6] mk: introduce helper to check valid compiler argument Pavan Nikhilesh Bhagavatula
2019-01-07 15:42 ` [dpdk-dev] [PATCH v2 2/6] config: add thunderx2 machine config Pavan Nikhilesh Bhagavatula
2019-01-07 15:42 ` [dpdk-dev] [PATCH v2 3/6] config: add octeontx2 " Pavan Nikhilesh Bhagavatula
2019-01-07 15:42 ` [dpdk-dev] [PATCH v2 4/6] meson: add infra to support machine specific flags Pavan Nikhilesh Bhagavatula
2019-01-07 15:42 ` [dpdk-dev] [PATCH v2 5/6] meson: add thunderx2 machine config Pavan Nikhilesh Bhagavatula
2019-01-07 16:57 ` Thomas Monjalon
2019-01-07 15:42 ` [dpdk-dev] [PATCH v2 6/6] meson: add octeontx2 " Pavan Nikhilesh Bhagavatula
2019-01-09 10:19 ` [dpdk-dev] [PATCH v3 1/4] mk: introduce helper to check valid compiler argument Pavan Nikhilesh Bhagavatula
2019-01-09 10:19 ` [dpdk-dev] [PATCH v3 2/4] meson: add infra to support machine specific flags Pavan Nikhilesh Bhagavatula
2019-01-09 10:19 ` [dpdk-dev] [PATCH v3 3/4] config: add thunderx2 machine config Pavan Nikhilesh Bhagavatula
2019-01-09 10:19 ` [dpdk-dev] [PATCH v3 4/4] config: add octeontx2 " Pavan Nikhilesh Bhagavatula
2019-01-09 10:19 ` [dpdk-dev] [PATCH v3 5/5] meson: add cross build targets for thunderx2 and octeontx2 Pavan Nikhilesh Bhagavatula
2019-01-09 10:39 ` [dpdk-dev] [PATCH v4 1/5] mk: introduce helper to check valid compiler argument Pavan Nikhilesh Bhagavatula
2019-01-09 10:39 ` [dpdk-dev] [PATCH v4 2/5] meson: add infra to support machine specific flags Pavan Nikhilesh Bhagavatula
2019-01-14 11:32 ` Thomas Monjalon
2019-02-12 8:06 ` Phil Yang (Arm Technology China)
2019-02-12 8:35 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-01-09 10:39 ` [dpdk-dev] [PATCH v4 3/5] config: add thunderx2 machine config Pavan Nikhilesh Bhagavatula
2019-01-09 10:39 ` [dpdk-dev] [PATCH v4 4/5] config: add octeontx2 " Pavan Nikhilesh Bhagavatula
2019-02-12 8:50 ` Phil Yang (Arm Technology China)
2019-01-09 10:39 ` [dpdk-dev] [PATCH v4 5/5] meson: add cross build targets for thunderx2 and octeontx2 Pavan Nikhilesh Bhagavatula
2019-01-14 11:28 ` Thomas Monjalon
2019-01-14 11:35 ` [dpdk-dev] [PATCH v4 1/5] mk: introduce helper to check valid compiler argument Thomas Monjalon
2019-01-14 11:56 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-01-14 12:08 ` Thomas Monjalon
2019-02-24 18:11 ` [dpdk-dev] [PATCH v5 1/4] " Jerin Jacob Kollanukkaran
2019-02-24 18:11 ` [dpdk-dev] [PATCH v5 2/4] meson: add infra to support machine specific flags Jerin Jacob Kollanukkaran
2019-02-24 18:11 ` [dpdk-dev] [PATCH v5 3/4] config: add thunderx2 machine config Jerin Jacob Kollanukkaran
2019-02-24 18:11 ` [dpdk-dev] [PATCH v5 4/4] config: add octeontx2 " Jerin Jacob Kollanukkaran
2019-03-18 16:50 ` [dpdk-dev] [PATCH v6 1/4] mk: introduce helper to check valid compiler argument Jerin Jacob Kollanukkaran
2019-03-18 16:50 ` Jerin Jacob Kollanukkaran
2019-03-18 16:50 ` [dpdk-dev] [PATCH v6 2/4] meson: add infra to support machine specific flags Jerin Jacob Kollanukkaran
2019-03-18 16:50 ` Jerin Jacob Kollanukkaran
2019-03-19 9:40 ` Bruce Richardson
2019-03-19 9:40 ` Bruce Richardson
2019-03-29 13:57 ` Thomas Monjalon
2019-03-29 13:57 ` Thomas Monjalon
2019-03-18 16:50 ` [dpdk-dev] [PATCH v6 3/4] config: add thunderx2 machine config Jerin Jacob Kollanukkaran
2019-03-18 16:50 ` Jerin Jacob Kollanukkaran
2019-04-02 8:52 ` Gavin Hu (Arm Technology China)
2019-04-02 8:52 ` Gavin Hu (Arm Technology China)
2019-04-05 18:13 ` Thomas Monjalon
2019-04-05 18:13 ` Thomas Monjalon
2019-04-05 18:47 ` Jerin Jacob Kollanukkaran
2019-04-05 18:47 ` Jerin Jacob Kollanukkaran
2019-04-05 19:09 ` Thomas Monjalon
2019-04-05 19:09 ` Thomas Monjalon
2019-04-06 11:40 ` Jerin Jacob Kollanukkaran
2019-04-06 11:40 ` Jerin Jacob Kollanukkaran
2019-03-18 16:50 ` [dpdk-dev] [PATCH v6 4/4] config: add octeontx2 " Jerin Jacob Kollanukkaran
2019-03-18 16:50 ` Jerin Jacob Kollanukkaran
2019-04-02 8:54 ` Gavin Hu (Arm Technology China)
2019-04-02 8:54 ` Gavin Hu (Arm Technology China)
2019-04-06 14:27 ` [dpdk-dev] [PATCH v7 1/4] mk: introduce helper to check valid compiler argument jerinjacobk
2019-04-06 14:27 ` jerinjacobk
2019-04-06 14:27 ` [dpdk-dev] [PATCH v7 2/4] meson: add infra to support machine specific flags jerinjacobk
2019-04-06 14:27 ` jerinjacobk
2019-04-10 0:40 ` Yongseok Koh
2019-04-10 0:40 ` Yongseok Koh
2019-04-10 2:15 ` Yongseok Koh
2019-04-10 2:15 ` Yongseok Koh
2019-04-10 14:22 ` Pavan Nikhilesh Bhagavatula
2019-04-10 14:22 ` Pavan Nikhilesh Bhagavatula
2019-04-06 14:27 ` [dpdk-dev] [PATCH v7 3/4] config: add thunderx2 machine config jerinjacobk
2019-04-06 14:27 ` jerinjacobk
2019-04-08 10:32 ` Thomas Monjalon
2019-04-08 10:32 ` Thomas Monjalon
2019-04-08 12:05 ` Thomas Monjalon
2019-04-08 12:05 ` Thomas Monjalon
2019-04-08 12:11 ` Bruce Richardson
2019-04-08 12:11 ` Bruce Richardson
2019-04-06 14:27 ` [dpdk-dev] [PATCH v7 4/4] config: add octeontx2 " jerinjacobk
2019-04-06 14:27 ` jerinjacobk
2019-04-10 12:48 ` Thomas Monjalon
2019-04-10 12:48 ` Thomas Monjalon
2019-04-10 12:59 ` Jerin Jacob Kollanukkaran
2019-04-10 12:59 ` Jerin Jacob Kollanukkaran
2019-04-10 16:13 ` [dpdk-dev] [PATCH v8 1/4] mk: introduce helper to check valid compiler argument jerinjacobk
2019-04-10 16:13 ` jerinjacobk
2019-04-10 16:13 ` [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags jerinjacobk
2019-04-10 16:13 ` jerinjacobk
2019-04-10 17:37 ` Yongseok Koh
2019-04-10 17:37 ` Yongseok Koh
2019-04-11 6:07 ` Pavan Nikhilesh Bhagavatula
2019-04-11 6:07 ` Pavan Nikhilesh Bhagavatula
2019-04-11 20:12 ` Yongseok Koh
2019-04-11 20:12 ` Yongseok Koh
2019-04-12 2:04 ` Yongseok Koh
2019-04-12 2:04 ` Yongseok Koh
2019-04-12 6:07 ` Jerin Jacob Kollanukkaran
2019-04-12 6:07 ` Jerin Jacob Kollanukkaran
2019-04-12 6:43 ` Yongseok Koh
2019-04-12 6:43 ` Yongseok Koh
2019-04-12 7:00 ` Jerin Jacob Kollanukkaran
2019-04-12 7:00 ` Jerin Jacob Kollanukkaran
2019-04-12 7:34 ` Yongseok Koh
2019-04-12 7:34 ` Yongseok Koh
2019-04-12 7:09 ` Yongseok Koh
2019-04-12 7:09 ` Yongseok Koh
2019-04-12 7:35 ` Jerin Jacob Kollanukkaran
2019-04-12 7:35 ` Jerin Jacob Kollanukkaran
2019-04-12 7:47 ` Yongseok Koh
2019-04-12 7:47 ` Yongseok Koh
2019-04-11 23:37 ` Thomas Monjalon
2019-04-11 23:37 ` Thomas Monjalon
2019-04-12 1:59 ` Yongseok Koh
2019-04-12 1:59 ` Yongseok Koh
2019-04-12 7:12 ` Jerin Jacob Kollanukkaran
2019-04-12 7:12 ` Jerin Jacob Kollanukkaran
2019-04-12 8:45 ` Thomas Monjalon
2019-04-12 8:45 ` Thomas Monjalon
2019-04-13 6:24 ` Jerin Jacob Kollanukkaran
2019-04-13 6:24 ` Jerin Jacob Kollanukkaran
2019-04-13 20:42 ` Thomas Monjalon
2019-04-13 20:42 ` Thomas Monjalon
2019-04-14 14:40 ` Pavan Nikhilesh Bhagavatula
2019-04-14 14:40 ` Pavan Nikhilesh Bhagavatula
2019-04-14 17:44 ` Thomas Monjalon [this message]
2019-04-14 17:44 ` Thomas Monjalon
2019-04-14 18:19 ` Jerin Jacob Kollanukkaran
2019-04-14 18:19 ` Jerin Jacob Kollanukkaran
2019-04-14 18:29 ` Thomas Monjalon
2019-04-14 18:29 ` Thomas Monjalon
2019-04-10 16:13 ` [dpdk-dev] [PATCH v8 3/4] config: add thunderx2 machine config jerinjacobk
2019-04-10 16:13 ` jerinjacobk
2019-04-10 16:14 ` [dpdk-dev] [PATCH v8 4/4] config: add octeontx2 " jerinjacobk
2019-04-10 16:14 ` jerinjacobk
2019-04-13 19:01 ` [dpdk-dev] [PATCH v9 1/4] mk: introduce helper to check valid compiler argument jerinj
2019-04-13 19:01 ` jerinj
2019-04-13 19:01 ` [dpdk-dev] [PATCH v9 2/4] meson: add infra to support machine specific flags jerinj
2019-04-13 19:01 ` jerinj
2019-04-13 19:01 ` [dpdk-dev] [PATCH v9 3/4] config: add thunderx2 machine config jerinj
2019-04-13 19:01 ` jerinj
2019-04-13 19:01 ` [dpdk-dev] [PATCH v9 4/4] config: add octeontx2 " jerinj
2019-04-13 19:01 ` jerinj
2019-04-13 20:19 ` [dpdk-dev] [PATCH v10 1/4] mk: introduce helper to check valid compiler argument jerinj
2019-04-13 20:19 ` jerinj
2019-04-13 20:19 ` [dpdk-dev] [PATCH v10 2/4] meson: add infra to support machine specific flags jerinj
2019-04-13 20:19 ` jerinj
2019-04-13 20:19 ` [dpdk-dev] [PATCH v10 3/4] config: add thunderx2 machine config jerinj
2019-04-13 20:19 ` jerinj
2019-04-13 20:19 ` [dpdk-dev] [PATCH v10 4/4] config: add octeontx2 " jerinj
2019-04-13 20:19 ` jerinj
2019-04-15 21:00 ` [dpdk-dev] [PATCH v10 1/4] mk: introduce helper to check valid compiler argument Thomas Monjalon
2019-04-15 21:00 ` Thomas Monjalon
2019-03-21 10:13 ` [dpdk-dev] [PATCH v5 " Phil Yang (Arm Technology China)
2019-03-21 10:13 ` Phil Yang (Arm Technology China)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1966190.OdWs8lNuHB@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=pbhagavatula@marvell.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).