From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 69877A00E6 for ; Mon, 15 Apr 2019 10:37:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16CF71B113; Mon, 15 Apr 2019 10:37:31 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 88EA65B26 for ; Mon, 15 Apr 2019 10:37:29 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id i2so8214056pgj.11 for ; Mon, 15 Apr 2019 01:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u5moz7X6PLAdZ3PAvh+i726wO5CTvBaxghx4/0D7xA0=; b=LzsUJOE3Aaxotm7J/g67IevZeAXR2f3KggaMq2xDclbqJTcwb0MaJYjOlHUGbMt1nH Nim94K6dey9q2bfW2q3gP/qtlfJcHcWki7FjHGrxPDUntKXWc0hut1wHt1+ng0xa6DgQ SZFX+cP2KFM8pzosHLGYKktlWrRvy8lPigw+MGrx57reqvcv68A4jGpgKLC4LnDfYON2 k0G7ilMNkoaLONriRm+i20fIEg2+WQ6JRGtk7lrN28JVa4nPDdvOc3AymRlaIm0abooS p/rcqwKJT7R1K4NnitanCE1F0f5NWjb75gP8SBlRAvA4fOq8dRy15DAAIjOiQT1vsCTa Qlow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u5moz7X6PLAdZ3PAvh+i726wO5CTvBaxghx4/0D7xA0=; b=QkXCHc8wNKXgr264Jxm+lEwY8sdoKxts3kDa1GNPmLtxEYek2vEVXRuD1ww/UbBXfW iE7HptokPKzUK93ST2V12r4D18E7h53YCRWfVHrddn0shE0RRdX8oPMgHKgPgnIzuKoA b+ySkQJReP4YRLhqXjIYPEKO+NJCGyWtRIIsef4C1SGak4o9me6smr2w+d+GwnDmqYpC ilNWVHfs04/yXazJKyU7n/JG4R0s0PjAfA6OANFu2SWhRoJJbHkh9got6n+gQVwbqBz9 ojzMe+0m87DivU0tMQEBW2dhd8IOwzv3hmYAcSby8wr+26qdRwIQLAX3Zfj6YRvvcG8M wETA== X-Gm-Message-State: APjAAAVkYAe0XQhl8mzdLGtnpGB6u/Me/+Exik6OTPAYCIynUntdlgp0 uvJeay2zUtZ67IICmakubS8R2Y28psOag5Z+TCHHfA== X-Google-Smtp-Source: APXvYqxZmlCVl2vyg61hbJAl1m2sV8qVUjScOPdKmT5py/L5HjY7/qwzh/cy0LVOSTohJD59dC0U2cxXvxXMrSLVTkU= X-Received: by 2002:a63:5b4b:: with SMTP id l11mr38974987pgm.95.1555317448667; Mon, 15 Apr 2019 01:37:28 -0700 (PDT) MIME-Version: 1.0 References: <20180927000224.4011-1-iryzhov@nfware.com> <20190410103003.42385-1-iryzhov@nfware.com> <63fc1744-9c37-2080-c651-b0231c86e8cb@intel.com> <1836b546-01ef-b089-9651-ed7d82b917a2@intel.com> In-Reply-To: From: Igor Ryzhov Date: Mon, 15 Apr 2019 11:37:17 +0300 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190415083717.tc1e3943rC44YXj0H9RwHNdN3KijY-n4NSgZMDQC9do@z> Hi Ferruh, To be absolutely sure, I performed a test using the test application. When I send pings from an interface: 3: ens8: mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000 link/ether 52:54:00:c8:79:c6 brd ff:ff:ff:ff:ff:ff Here is what's in sockaddr_ll: $2 =3D {sll_family =3D 0x11, sll_protocol =3D 0x8, sll_ifindex =3D 0x2, sll= _hatype =3D 0x1, sll_pkttype =3D 0x0, sll_halen =3D 0x6, sll_addr =3D { 0x52, 0x54, 0x0, 0xc8, 0x79, 0xc6, 0x0, 0x0}} So everything works as expected =E2=80=93 the address in sll_addr is correc= t. Last two bytes are zero because the length of sll_addr is 8, however, Ethernet length is 6. Igor On Fri, Apr 12, 2019 at 8:15 PM Ferruh Yigit wrote= : > On 4/12/2019 6:12 PM, Igor Ryzhov wrote: > > Hi Ferruh, > > > > I didn't test it with any special application, but FRR's ISIS works for > me after > > the patch, and it didn't work before. > > That is good enough, and by work you mean that you are able to get correc= t > value > on 'sll_addr', right? > > > > > Igor > > > > On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit > > wrote: > > > > On 4/12/2019 3:52 PM, Ferruh Yigit wrote: > > > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > > >> It allows applications running packet sockets over KNI interface= s > to get > > >> source Ethernet addresses of packets received using recvfrom > function. > > >> > > >> Signed-off-by: Igor Ryzhov iryzhov@nfware.com>> > > > > > > Acked-by: Ferruh Yigit > > > > > > > > > > > Hi Igor, > > > > > > I tested this with a quick application on top of kni interfaces, > that > > reads and > > > prints the 'sll_halen', but the last two bytes of the mac address > are always > > > > I mean 'sll_addr', 'sll_halen' is right (6). > > > > > zero, it is quite possible that something is not right in the tes= t > app, but > > > before spending any time on it, can you please confirm this is > working > > fine for you? > > > > > > >