From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 321D61B123; Mon, 15 Apr 2019 11:19:49 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 02:19:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,353,1549958400"; d="scan'208";a="149508808" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.220.103]) by FMSMGA003.fm.intel.com with SMTP; 15 Apr 2019 02:19:45 -0700 Received: by (sSMTP sendmail emulation); Mon, 15 Apr 2019 10:19:44 +0100 Date: Mon, 15 Apr 2019 10:19:44 +0100 From: Bruce Richardson To: Yongseok Koh Cc: jerinj@marvell.com, pbhagavatula@marvell.com, shahafs@mellanox.com, dev@dpdk.org, thomas@monjalon.net, gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, bluca@debian.org, stable@dpdk.org Message-ID: <20190415091944.GC1846@bricha3-MOBL.ger.corp.intel.com> References: <20190412232451.30197-1-yskoh@mellanox.com> <20190412232451.30197-4-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190412232451.30197-4-yskoh@mellanox.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2019 09:19:49 -0000 On Fri, Apr 12, 2019 at 04:24:48PM -0700, Yongseok Koh wrote: > If MLNX_OFED is installed, there's no .pc file installed for libraries and > dependency() can't find libraries by pkg-config. By adding fallback of > using cc.find_library(), libraries are properly located. > > Fixes: e30b4e566f47 ("build: improve dependency handling") > Cc: bluca@debian.org > Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx4/meson.build | 19 +++++++++++-------- > drivers/net/mlx5/meson.build | 19 +++++++++++-------- > 2 files changed, 22 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build > index de020701d1..9082f69f25 100644 > --- a/drivers/net/mlx4/meson.build > +++ b/drivers/net/mlx4/meson.build > @@ -13,21 +13,24 @@ if pmd_dlopen > '-DMLX4_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION), > ] > endif > -libs = [ > - dependency('libmnl', required:false), > - dependency('libmlx4', required:false), > - dependency('libibverbs', required:false), > -] > +libs = [ 'libmnl', 'libmlx4', 'libibverbs' ] > +lib_deps = [] Minor suggestion - you can reduce the size of the diff in this patch by defining the first array as "libnames" and keeping the actual dependency objects as "libs". /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B7E67A00E6 for ; Mon, 15 Apr 2019 11:19:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A04F1B140; Mon, 15 Apr 2019 11:19:51 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 321D61B123; Mon, 15 Apr 2019 11:19:49 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 02:19:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,353,1549958400"; d="scan'208";a="149508808" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.220.103]) by FMSMGA003.fm.intel.com with SMTP; 15 Apr 2019 02:19:45 -0700 Received: by (sSMTP sendmail emulation); Mon, 15 Apr 2019 10:19:44 +0100 Date: Mon, 15 Apr 2019 10:19:44 +0100 From: Bruce Richardson To: Yongseok Koh Cc: jerinj@marvell.com, pbhagavatula@marvell.com, shahafs@mellanox.com, dev@dpdk.org, thomas@monjalon.net, gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, bluca@debian.org, stable@dpdk.org Message-ID: <20190415091944.GC1846@bricha3-MOBL.ger.corp.intel.com> References: <20190412232451.30197-1-yskoh@mellanox.com> <20190412232451.30197-4-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190412232451.30197-4-yskoh@mellanox.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190415091944.FBVt5g_-uNseiVxzWVxqjgBn8XYTDRoG4zjQHriX2ig@z> On Fri, Apr 12, 2019 at 04:24:48PM -0700, Yongseok Koh wrote: > If MLNX_OFED is installed, there's no .pc file installed for libraries and > dependency() can't find libraries by pkg-config. By adding fallback of > using cc.find_library(), libraries are properly located. > > Fixes: e30b4e566f47 ("build: improve dependency handling") > Cc: bluca@debian.org > Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh > --- > drivers/net/mlx4/meson.build | 19 +++++++++++-------- > drivers/net/mlx5/meson.build | 19 +++++++++++-------- > 2 files changed, 22 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build > index de020701d1..9082f69f25 100644 > --- a/drivers/net/mlx4/meson.build > +++ b/drivers/net/mlx4/meson.build > @@ -13,21 +13,24 @@ if pmd_dlopen > '-DMLX4_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION), > ] > endif > -libs = [ > - dependency('libmnl', required:false), > - dependency('libmlx4', required:false), > - dependency('libibverbs', required:false), > -] > +libs = [ 'libmnl', 'libmlx4', 'libibverbs' ] > +lib_deps = [] Minor suggestion - you can reduce the size of the diff in this patch by defining the first array as "libnames" and keeping the actual dependency objects as "libs". /Bruce