From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AE61BA00E6 for ; Mon, 15 Apr 2019 15:40:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 200F91B203; Mon, 15 Apr 2019 15:40:46 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10087.outbound.protection.outlook.com [40.107.1.87]) by dpdk.org (Postfix) with ESMTP id BF3061B1D6 for ; Mon, 15 Apr 2019 15:40:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kNTmCLJVk29xg4pZCNbPW17qnN3cQckYMucg0VAK0nQ=; b=WMvjVPv3vDzMgB7oxnHQda5I4LNiGzTdn+UoVlgV2uyzT3GEJj9+9ndoDs8iqiAiPYZQZErFmWaBPAT6SqfqnEKYFoltWE9YrNzuitFPVla3HZz9H9yZ//rccjsMz/H5KOuuXOfDsYL0osbLVfcQpMBLMM1xXJpIoUWq0Y22yKA= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5216.eurprd08.prod.outlook.com (10.255.159.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.17; Mon, 15 Apr 2019 13:40:43 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177%2]) with mapi id 15.20.1792.018; Mon, 15 Apr 2019 13:40:43 +0000 From: Honnappa Nagarahalli To: "jerinj@marvell.com" , "yskoh@mellanox.com" , "bruce.richardson@intel.com" , Pavan Nikhilesh Bhagavatula , "shahafs@mellanox.com" CC: "dev@dpdk.org" , "thomas@monjalon.net" , "Gavin Hu (Arm Technology China)" , nd , nd , nd Thread-Topic: [EXT] [PATCH 2/6] meson: change default cache line size for cortex-a72 Thread-Index: AQHU8Yb4imTG5knQF0WAOuqpUrB6m6Y5pVqAgAL4iJCAAJ9JgA== Date: Mon, 15 Apr 2019 13:40:42 +0000 Message-ID: References: <20190412232451.30197-1-yskoh@mellanox.com> <20190412232451.30197-3-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e0f97ce1-256b-4692-a790-08d6c1a7f4d1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VE1PR08MB5216; x-ms-traffictypediagnostic: VE1PR08MB5216: x-ms-exchange-purlcount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 000800954F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(39860400002)(376002)(396003)(366004)(199004)(189003)(2201001)(33656002)(53936002)(3846002)(68736007)(2940100002)(2906002)(6436002)(74316002)(9686003)(71190400001)(6306002)(256004)(305945005)(86362001)(6116002)(14444005)(11346002)(106356001)(55016002)(54906003)(71200400001)(5660300002)(66066001)(105586002)(446003)(7736002)(6246003)(229853002)(26005)(102836004)(478600001)(72206003)(6506007)(97736004)(486006)(966005)(76176011)(93156006)(316002)(8936002)(52536014)(476003)(7696005)(8676002)(25786009)(186003)(81166006)(14454004)(4326008)(93886005)(99286004)(81156014)(2501003)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5216; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: oXZj7/H315blMeLMHyJPp6qfWEqF78ETyM/MrZMJES16dg9pG2aPnGRWlF+tZfxN4w8nWz1MOHlpJNM28jL03qFLia17SVUttyZIq4vRmGUFW0+gMlA+rzpF7MkmDRnHZYK6+J3z7XKWykdAxTOrcWWfvEkx8j39hp7hlZuT+uJj5sGLPzqVhUVFE/RbWrOu9pjkrY4WnTgVGAeW5Jc+TJNvTC1o/wlIEKAHtSZnIjjQPjGd7kGLtc5bh7fDJnMkPqRDqakTgRzLafVOkL1f9nTlnm4rk5OPftHl3QnsqySalwyNZvoxr7FWywlvGbgVf2Zu0sO7uLTyvurrYGNdKeE3UmklFQiO0u+o7mGwhHx3XArSv2BI6oEB0s8GDJmsltYCzcd+kL/L38A25TiWaJP/d7nWfzwc9RzSf/iH3lk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0f97ce1-256b-4692-a790-08d6c1a7f4d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2019 13:40:42.9242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5216 Subject: Re: [dpdk-dev] [EXT] [PATCH 2/6] meson: change default cache line size for cortex-a72 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190415134042.XSn3P6QqHc756zQS8uIDYBkhDzuOZhB9vg3YcxAwU9s@z> >=20 > > > > > > -------------------------------------------------------------------- > > > -- Per the email discussion [1], the default cache line size of > > > armv8 > > > cortex-a72 is changed to 64 bytes. > > > > IMO, In git commit you remove the reference to specific discussion and > > Update the reason correctly. > > > > > > > > > > [1] https://mails.dpdk.org/archives/dev/2019-January/123218.html > > > > > > Signed-off-by: Yongseok Koh > > > --- > > > config/arm/meson.build | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > > > e00b894523..73c581948c 100644 > > > --- a/config/arm/meson.build > > > +++ b/config/arm/meson.build > > > @@ -51,6 +51,8 @@ flags_dpaa2 =3D [ > > > ['RTE_MAX_LCORE', 16], > > > ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]] flags_default_extra > > =3D [] > > > +flags_cortex_a72_extra =3D [ > > > + ['RTE_CACHE_LINE_SIZE', 64]] > > > flags_thunderx_extra =3D [ > Which tree does this patch apply to? I do not see the above line in maste= r. Please ignore this comment, I missed the dependency provided in 0/6 >=20 > > > ['RTE_MACHINE', '"thunderx"'], > > > ['RTE_USE_C11_MEM_MODEL', false]] > > > @@ -73,7 +75,7 @@ machine_args_generic =3D [ > > > ['0xd03', ['-mcpu=3Dcortex-a53']], > > > ['0xd04', ['-mcpu=3Dcortex-a35']], > > > ['0xd07', ['-mcpu=3Dcortex-a57']], > > > - ['0xd08', ['-mcpu=3Dcortex-a72']], > > > + ['0xd08', ['-mcpu=3Dcortex-a72'], flags_cortex_a72_extra], > > > ['0xd09', ['-mcpu=3Dcortex-a73']], > > > ['0xd0a', ['-mcpu=3Dcortex-a75']]] > > > > I think, flags_cortex_a72_extra() can be changed to > > flags_vendor_arm_extra or something similar And update the following > > CPUs also not just cortex-a72. > > > Why not add 'flags_arm' similar to flags_dpaa2/flag_cavium etc? All the > listed Arm cores are 64B cache line size. Just to complete the thought, impl_0x41 can use 'flags_arm' instead of 'fla= gs_generic'. IMO, current use of 'flags_generic' in impl_0x41 is incorrect. >=20 > > ['0xd03', ['-mcpu=3Dcortex-a53']], > > ['0xd04', ['-mcpu=3Dcortex-a35']], > > ['0xd05', ['-mcpu=3Dcortex-a55']], > > ['0xd07', ['-mcpu=3Dcortex-a57']], > > ['0xd08', ['-mcpu=3Dcortex-a72']], > > ['0xd09', ['-mcpu=3Dcortex-a73']], > > ['0xd0a', ['-mcpu=3Dcortex-a75']], > > ['0xd0b', ['-mcpu=3Dcortex-a76']], > > > > > > > > > > -- > > > 2.21.0.196.g041f5ea