From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4DE1AA00E6 for ; Mon, 15 Apr 2019 17:22:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DBE41B202; Mon, 15 Apr 2019 17:22:23 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8B9274CA7 for ; Mon, 15 Apr 2019 17:22:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 08:22:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,354,1549958400"; d="scan'208";a="135979421" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.210.157]) ([10.237.210.157]) by orsmga006.jf.intel.com with ESMTP; 15 Apr 2019 08:22:18 -0700 To: Lukasz Krakowiak Cc: anatoly.burakov@intel.com, dev@dpdk.org References: <20190307135950.30738-1-lukaszx.krakowiak@intel.com> <20190403103256.21856-1-lukaszx.krakowiak@intel.com> <20190403103256.21856-4-lukaszx.krakowiak@intel.com> From: "Hunt, David" Message-ID: Date: Mon, 15 Apr 2019 16:22:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190403103256.21856-4-lukaszx.krakowiak@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 3/3] test: add UT for power turbo feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190415152217.ZuDZpJNyfRNbSTEB6MAGICuUhqPgCER1oa4JnW4NN4c@z> On 3/4/2019 11:32 AM, Lukasz Krakowiak wrote: > Add UT check_power_turbo. > > Signed-off-by: Lukasz Krakowiak > --- > app/test/test_power_cpufreq.c | 72 +++++++++++++++++++++++++++++++++++ > 1 file changed, 72 insertions(+) > > diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c > index d099f2f47..d203810da 100644 > --- a/app/test/test_power_cpufreq.c > +++ b/app/test/test_power_cpufreq.c > @@ -366,6 +366,59 @@ check_power_freq_min(void) > return 0; > } > > +/* Check rte_power_turbo() */ > +static int > +check_power_turbo(void) > +{ > + int ret; > + > + if (rte_power_turbo_status(TEST_POWER_LCORE_ID) == 0) { > + printf("Turbo not available on lcore %u, skipping test\n", > + TEST_POWER_LCORE_ID); > + return 0; > + } > + > + /* test with an invalid lcore id */ > + ret = rte_power_freq_enable_turbo(TEST_POWER_LCORE_INVALID); > + if (ret >= 0) { > + printf("Unexpectedly enable turbo successfully on lcore %u\n", > + TEST_POWER_LCORE_INVALID); > + return -1; > + } > + ret = rte_power_freq_enable_turbo(TEST_POWER_LCORE_ID); > + if (ret < 0) { > + printf("Fail to enable turbo on lcore %u\n", > + TEST_POWER_LCORE_ID); > + return -1; > + } > + > + /* Check the current frequency */ > + ret = check_cur_freq(TEST_POWER_LCORE_ID, 0); > + if (ret < 0) > + return -1; > + > + /* test with an invalid lcore id */ > + ret = rte_power_freq_disable_turbo(TEST_POWER_LCORE_INVALID); > + if (ret >= 0) { > + printf("Unexpectedly disable turbo successfully on lcore %u\n", > + TEST_POWER_LCORE_INVALID); > + return -1; > + } > + ret = rte_power_freq_disable_turbo(TEST_POWER_LCORE_ID); > + if (ret < 0) { > + printf("Fail to disable turbo on lcore %u\n", > + TEST_POWER_LCORE_ID); > + return -1; > + } > + > + /* Check the current frequency */ > + ret = check_cur_freq(TEST_POWER_LCORE_ID, 1); > + if (ret < 0) > + return -1; > + > + return 0; > +} > + > static int > test_power_cpufreq(void) > { > @@ -427,6 +480,21 @@ test_power_cpufreq(void) > "been initialised\n"); > goto fail_all; > } > + if (rte_power_turbo_status == NULL) { > + printf("rte_power_turbo_status should not be NULL, environment has not " > + "been initialised\n"); > + goto fail_all; > + } > + if (rte_power_freq_enable_turbo == NULL) { > + printf("rte_power_freq_enable_turbo should not be NULL, environment has not " > + "been initialised\n"); > + goto fail_all; > + } > + if (rte_power_freq_disable_turbo == NULL) { > + printf("rte_power_freq_disable_turbo should not be NULL, environment has not " > + "been initialised\n"); > + goto fail_all; > + } > > ret = rte_power_exit(TEST_POWER_LCORE_ID); > if (ret < 0) { > @@ -502,6 +570,10 @@ test_power_cpufreq(void) > if (ret < 0) > goto fail_all; > > + ret = check_power_turbo(); > + if (ret < 0) > + goto fail_all; > + > ret = rte_power_exit(TEST_POWER_LCORE_ID); > if (ret < 0) { > printf("Cannot exit power management for lcore %u\n", Acked-by: David Hunt