From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BC7C3A00E6 for ; Mon, 15 Apr 2019 21:48:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93A901B3D2; Mon, 15 Apr 2019 21:48:55 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130082.outbound.protection.outlook.com [40.107.13.82]) by dpdk.org (Postfix) with ESMTP id A12DE1B3BA; Mon, 15 Apr 2019 21:48:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HjZEsWo+M35jPbu2It0MUx+Xq6XeY+knLyZ59jGsczw=; b=X5defguP67ANfyOMuMsBgOUeXB6PoKDidrOqgHeYer1Tm9eAUX81u1Baei7qRotjzyaS7/NmAUnYnIkpSubN06ttdqPzptsMswYTythva/T9GAQcTA5BkCpPcaB/7+y4EpXBg65z/0ntXJ3oVEN72CK6oJ8MyIJaRqCEl+mhQTI= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4057.eurprd05.prod.outlook.com (52.134.67.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.17; Mon, 15 Apr 2019 19:48:53 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a%3]) with mapi id 15.20.1792.018; Mon, 15 Apr 2019 19:48:53 +0000 From: Yongseok Koh To: Bruce Richardson CC: "jerinj@marvell.com" , "pbhagavatula@marvell.com" , Shahaf Shuler , "dev@dpdk.org" , Thomas Monjalon , "gavin.hu@arm.com" , "Honnappa.Nagarahalli@arm.com" , "bluca@debian.org" , "stable@dpdk.org" Thread-Topic: [PATCH 3/6] net/mlx: fix library search in meson build Thread-Index: AQHU8Yb4dNKN2lEEa0GyaR3eo4jOEaY89asAgACvxwA= Date: Mon, 15 Apr 2019 19:48:53 +0000 Message-ID: References: <20190412232451.30197-1-yskoh@mellanox.com> <20190412232451.30197-4-yskoh@mellanox.com> <20190415091944.GC1846@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190415091944.GC1846@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1115362d-5277-4327-ab94-08d6c1db63b2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:DB3PR0502MB4057; x-ms-traffictypediagnostic: DB3PR0502MB4057: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-forefront-prvs: 000800954F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(39860400002)(376002)(396003)(136003)(199004)(189003)(25786009)(83716004)(106356001)(105586002)(229853002)(36756003)(33656002)(14454004)(5660300002)(2616005)(486006)(446003)(82746002)(6486002)(6436002)(11346002)(71190400001)(478600001)(476003)(256004)(6512007)(6916009)(6506007)(86362001)(76176011)(6246003)(102836004)(7736002)(316002)(81166006)(71200400001)(54906003)(53546011)(305945005)(68736007)(8936002)(99286004)(81156014)(3846002)(4326008)(66066001)(186003)(26005)(2906002)(6116002)(8676002)(97736004)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4057; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: f+kvgcJYo+X9LXF1r23ZaLMBl0vupmSZlSsKUhpBLv7ryx5u7K18E7Uyx+Sqky3gYSnMFKQFgWnLp1uvJm7s0CrAd1zokxOI2AaSQ1D8DyI9z1H+dZiHXqX/1utrLgZV12V/GVPJ7KNm/D3dyoMz0cYIHDrl6z72M6AUC4tYkKyvSZKQejT8W8oXZQMyiD3yQSEf7J74vblNYccLpSFO2TpuO8JDoj+ol4et5wiAYmJSpyXsDcZq/nt4k/7Sv71apTTqaun7lj5McQe3HJBi8IsvpjVFq8V7alcqCzP1ullR/2HbLaOYXzPBi3tdZpBxZICrdKVKdM5TCgB6ZKR/Xk1vFfdGc2+WWoP6a6SbFwRkNWPBGDiU/To3GluYb4lLDm6x1pjefSzpg3OiixLfRIU4rsfAuS1kWqyQ1n7E+Mw= Content-Type: text/plain; charset="UTF-8" Content-ID: <12E9A7B78E9A8D489F0B5D7858040872@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1115362d-5277-4327-ab94-08d6c1db63b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2019 19:48:53.2074 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4057 Subject: Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190415194853.ICapv751OJm3h47rYnK58wDj8e2udLtE9PVGtSm5vtA@z> > On Apr 15, 2019, at 2:19 AM, Bruce Richardson wrote: >=20 > On Fri, Apr 12, 2019 at 04:24:48PM -0700, Yongseok Koh wrote: >> If MLNX_OFED is installed, there's no .pc file installed for libraries a= nd >> dependency() can't find libraries by pkg-config. By adding fallback of >> using cc.find_library(), libraries are properly located. >>=20 >> Fixes: e30b4e566f47 ("build: improve dependency handling") >> Cc: bluca@debian.org >> Cc: stable@dpdk.org >>=20 >> Signed-off-by: Yongseok Koh >> --- >> drivers/net/mlx4/meson.build | 19 +++++++++++-------- >> drivers/net/mlx5/meson.build | 19 +++++++++++-------- >> 2 files changed, 22 insertions(+), 16 deletions(-) >>=20 >> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build >> index de020701d1..9082f69f25 100644 >> --- a/drivers/net/mlx4/meson.build >> +++ b/drivers/net/mlx4/meson.build >> @@ -13,21 +13,24 @@ if pmd_dlopen >> '-DMLX4_GLUE_VERSION=3D"@0@"'.format(LIB_GLUE_VERSION), >> ] >> endif >> -libs =3D [ >> - dependency('libmnl', required:false), >> - dependency('libmlx4', required:false), >> - dependency('libibverbs', required:false), >> -] >> +libs =3D [ 'libmnl', 'libmlx4', 'libibverbs' ] >> +lib_deps =3D [] >=20 > Minor suggestion - you can reduce the size of the diff in this patch by > defining the first array as "libnames" and keeping the actual dependency > objects as "libs". Sounds good to me. Will take the suggestion in my v2.