From: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
To: "vivkong@ca.ibm.com" <vivkong@ca.ibm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [RFC 08/12] hash: add support for s390x architecture
Date: Mon, 15 Apr 2019 20:43:54 +0000 [thread overview]
Message-ID: <3B1CE4FA-0C44-4A92-9810-B85EFED4CD89@arm.com> (raw)
Message-ID: <20190415204354.L5jFEyudUVI9zOPllBMN427YOHsuPX08YCQ3ygdHcRg@z> (raw)
In-Reply-To: <20190409190630.31975-9-vivkong@ca.ibm.com>
Hi,
Please find the inline comment.
> On Apr 9, 2019, at 2:06 PM, Vivian Kong <vivkong@gmail.com> wrote:
>
> Add big endian support for s390x architecture.
>
> Signed-off-by: Vivian Kong <vivkong@ca.ibm.com>
> ---
> lib/librte_hash/rte_fbk_hash.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/librte_hash/rte_fbk_hash.h b/lib/librte_hash/rte_fbk_hash.h
> index c4d6976d2..5e49950a7 100644
> --- a/lib/librte_hash/rte_fbk_hash.h
> +++ b/lib/librte_hash/rte_fbk_hash.h
> @@ -125,9 +125,16 @@ rte_fbk_hash_add_key_with_bucket(struct rte_fbk_hash_table *ht,
> * corrupted due to race conditions, but it's still possible to
> * overwrite entries that have just been made valid.
> */
> + #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
> const uint64_t new_entry = ((uint64_t)(key) << 32) |
> ((uint64_t)(value) << 16) |
> 1; /* 1 = is_entry bit. */
> + #else
> + const uint64_t new_entry =
> + ((uint64_t)(1) << 48) | /* 1 = is_entry bit. */
((uint64_t)(1) << 56)?
> + ((uint64_t)(value) << 32) |
> + (uint64_t)(key);
> + #endif
> uint32_t i;
>
> for (i = 0; i < ht->entries_per_bucket; i++) {
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-04-15 20:43 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 19:06 [dpdk-dev] [RFC 00/12] introduce " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 01/12] mk: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:38 ` Luca Boccassi
2019-04-09 19:38 ` Luca Boccassi
2019-04-10 16:50 ` Vivian Kong
2019-04-10 16:50 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 02/12] eal: add support for " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 03/12] acl: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 04/12] lpm: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 05/12] examples/l3fwd: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 06/12] net/i40e: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 07/12] test: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 08/12] hash: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-15 20:43 ` Dharmik Thakkar [this message]
2019-04-15 20:43 ` Dharmik Thakkar
2019-04-09 19:06 ` [dpdk-dev] [RFC 09/12] doc: introduce " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 20:12 ` Thomas Monjalon
2019-04-09 20:12 ` Thomas Monjalon
2019-04-10 16:52 ` Vivian Kong
2019-04-10 16:52 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 10/12] ethdev: add cast for bus_device Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 20:14 ` Thomas Monjalon
2019-04-09 20:14 ` Thomas Monjalon
2019-04-10 2:41 ` Stephen Hemminger
2019-04-10 2:41 ` Stephen Hemminger
2019-04-10 17:10 ` Vivian Kong
2019-04-10 17:10 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 11/12] mbuf: trivial fix Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 20:13 ` Thomas Monjalon
2019-04-09 20:13 ` Thomas Monjalon
2019-04-09 19:06 ` [dpdk-dev] [RFC 12/12] test: miscellaneous test fixes Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 20:25 ` [dpdk-dev] [RFC 00/12] introduce s390x architecture Thomas Monjalon
2019-04-09 20:25 ` Thomas Monjalon
2019-04-10 17:09 ` Vivian Kong
2019-04-10 17:09 ` Vivian Kong
2019-04-10 17:43 ` Thomas Monjalon
2019-04-10 17:43 ` Thomas Monjalon
2019-04-10 19:15 ` Vivian Kong
2019-04-10 19:15 ` Vivian Kong
2019-04-10 19:46 ` Thomas Monjalon
2019-04-10 19:46 ` Thomas Monjalon
2019-04-10 20:45 ` Vivian Kong
2019-04-10 20:45 ` Vivian Kong
2019-04-10 20:31 ` David Christensen
2019-04-10 20:31 ` David Christensen
2019-04-10 20:46 ` Thomas Monjalon
2019-04-10 20:46 ` Thomas Monjalon
2019-04-10 21:03 ` David Christensen
2019-04-10 21:03 ` David Christensen
2019-04-10 21:45 ` Pradeep Satyanarayana
2019-04-10 21:45 ` Pradeep Satyanarayana
2019-04-11 6:59 ` Thomas Monjalon
2019-04-11 6:59 ` Thomas Monjalon
2019-04-11 15:57 ` Pradeep Satyanarayana
2019-04-11 15:57 ` Pradeep Satyanarayana
[not found] ` <OFB9049735.7E51096E-ON882583D9.00574783-882583D9.00579FE2@LocalDomain>
2019-04-18 21:06 ` Pradeep Satyanarayana
2019-04-18 21:06 ` Pradeep Satyanarayana
2019-04-18 21:18 ` Thomas Monjalon
2019-04-18 21:18 ` Thomas Monjalon
2019-04-11 7:45 ` David Marchand
2019-04-11 7:45 ` David Marchand
2019-05-15 12:45 ` David Marchand
2019-05-15 12:45 ` David Marchand
2020-02-18 21:03 ` Thomas Monjalon
2020-02-20 0:20 ` Pradeep Satyanarayana
2020-02-21 13:33 ` Vivian Kong
2021-03-24 21:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B1CE4FA-0C44-4A92-9810-B85EFED4CD89@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=vivkong@ca.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).