From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id D6E89A00E6
	for <public@inbox.dpdk.org>; Mon, 15 Apr 2019 23:33:19 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 6A8681B112;
	Mon, 15 Apr 2019 23:33:18 +0200 (CEST)
Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com
 [209.85.208.46]) by dpdk.org (Postfix) with ESMTP id 76C865F51;
 Mon, 15 Apr 2019 23:33:17 +0200 (CEST)
Received: by mail-ed1-f46.google.com with SMTP id d1so16006272edd.13;
 Mon, 15 Apr 2019 14:33:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=dwvbesx6i2DZ4fhdPNG3NBFs6qz172PbWNTdveY4kYE=;
 b=n1HcDXfGUNGD3gJmRjnZu4/R3H85/s5cRtgYR5z+SztR4QHfK9H2bIAObOEX2Cu56/
 FdbFQCH+vbxyu6n+X4pq6YIWOJy/NW5iAkXmudc29NSF6iIYtKlgUDJNdR3LNy+XG9Kw
 ePJedF/xv4/hVFmo+cQNdiuGh95vofzUSLaRwZyiuz0N7W3JrdHFX/pxh0YoQM9TPQcf
 dCBEgO48xLsOncElvRNuGe60Qb0Eee/vBfCuqIq5i8/CPxuU+6lzZ00z8/BNZX8UhBT2
 ckspSXGPiiwGKSZbHoYSst8PN2S9BbJMkWgTUMqqwehGVtDmJ5OAkPp8Wl8zu/nkKmH0
 +tUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=dwvbesx6i2DZ4fhdPNG3NBFs6qz172PbWNTdveY4kYE=;
 b=GkoUXeLoWfjUR4luL1wG0N+0SE3U8/EVYJ7Ct4iVVzkciur0zTQlcCT9pdMVuMqhym
 tuRWSi4p3GZ8+U7v8zWNgp/xgOgTK1ZkGGppPrkdoFyH0bJZIpcqoOpaSFmCJ9LwKlQM
 nJxW4JVpXJ9h2vqhtUxSq9yoimMy6Z/ubBcKlFYUqGfbejmuwkVfhakDiRi3IKm+mfxC
 PLw/ALyPWaUzp0wzgdoZY6POIwTPth/8kHHzKo6z/CmUn5Zwn3Csxnb9DyNYCQZ++PPQ
 vz1MoXMbBbQdbb6q/3nRNjfSnUN8+LMLOga6VsBnA276N9FgRkOXum7jX13NkSKM3LJC
 P6XQ==
X-Gm-Message-State: APjAAAVIEsZW5YXedFplbWVk9ToUS5dbW2ksOD/CO6PdqJoIcRDIvCwq
 A7rHJmdRXZkW344a7XJnea5BPnttelszgjElyhg=
X-Google-Smtp-Source: APXvYqxc4ADqZZx4zwVrx/yhsvGIDkLYp8v3rfARTH3SGvLjIrCDXJMftOSQReH79VV1E55tl0YuFBszyT1jyHYDE+8=
X-Received: by 2002:a50:fe15:: with SMTP id f21mr39195803edt.135.1555363997123; 
 Mon, 15 Apr 2019 14:33:17 -0700 (PDT)
MIME-Version: 1.0
References: <1555240302-9771-1-git-send-email-viveksharma@marvell.com>
 <20190415085435.3f616c8c@shemminger-XPS-13-9360>
In-Reply-To: <20190415085435.3f616c8c@shemminger-XPS-13-9360>
From: Rami Rosen <ramirose@gmail.com>
Date: Tue, 16 Apr 2019 00:33:09 +0300
Message-ID:
 <CAHLOa7T-D09b21XOuSB9m9n5QLbrqQZVf5nn_pTuusEti-DP-Q@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: viveksharma@marvell.com, dev@dpdk.org, thomas@monjalon.net, 
 ferruh.yigit@intel.com, arybchenko@solarflare.com, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix QinQ strip offload support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190415213309.VBg9KZ5r8P3Wp0Khxi6Bmka3VUCxyQQAgBcrduHZsjQ@z>

>Using a local (pointer) variable for dev->data->dev_conf.rxmode.offloads
>would make the code more readable and lines shorter.

+1