DPDK patches and discussions
 help / color / mirror / Atom feed
From: Li Qiang <liq3ea@163.com>
To: rosen.xu@intel.com, tianfei.zhang@intel.com
Cc: dev@dpdk.org, stable@dpdk.org, liq3ea@gmail.com,
	Li Qiang <liq3ea@163.com>
Subject: [dpdk-dev] [PATCH v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
Date: Tue, 16 Apr 2019 15:52:30 +0800	[thread overview]
Message-ID: <20190416075230.3087-1-liq3ea@163.com> (raw)
Message-ID: <20190416075230.Y4kxaVR10LWgR_2Oct_aE8bxf8aHjfW2DXrmg89d2zY@z> (raw)

In rte_fpga_do_pr() function, if 'stat' return error the
'file_fd' is never closed thus leading a fd leak. This patch
avoids this.

Coverity issue: 279441
Fixes: ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver")
Cc: stable@dpdk.org

Signed-off-by: Li Qiang <liq3ea@163.com>
---
Change since v2: add proper tags in commit message

 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
index da772d026..eff001b59 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -244,7 +244,8 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id,
 	if (ret) {
 		IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n",
 				file_name);
-		return -EINVAL;
+		ret = -EINVAL;
+		goto close_fd;
 	}
 	buffer_size = file_stat.st_size;
 	IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
-- 
2.19.1.3.ge56e4f7



             reply	other threads:[~2019-04-16 16:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16  7:52 Li Qiang [this message]
2019-04-16  7:52 ` Li Qiang
  -- strict thread matches above, loose matches on Subject: below --
2019-04-16  5:05 Li Qiang
2019-04-16  5:05 ` Li Qiang
2019-04-16  7:02 ` Xu, Rosen
2019-04-16  7:02   ` Xu, Rosen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416075230.3087-1-liq3ea@163.com \
    --to=liq3ea@163.com \
    --cc=dev@dpdk.org \
    --cc=liq3ea@gmail.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=tianfei.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).