Re: [dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name

[Thomas Monjalon <thomas@monjalon.net>]

16/04/2019 04:50, Xu, Rosen:
> From: Yigit, Ferruh
> > > --- a/drivers/bus/ifpga/rte_bus_ifpga.h
> > > +++ b/drivers/bus/ifpga/rte_bus_ifpga.h
> > > @@ -120,6 +120,15 @@ struct rte_afu_driver {  }
> > >
> > >  /**
> > > + * Find AFU by AFU name.
> > > + *
> > > + * @param name
> > > + *   A pointer to AFU name string.
> > > + */
> > > +struct rte_afu_device *__rte_experimental
> > > +rte_ifpga_find_afu_by_name(const char *name);
> > > +
> > 
> > 
> > Hi Rosen,
> > 
> > This is the bus code, and only drivers will call it right? I think there is no
> > intention to make this run by application code, the functions need to be
> > exported because driver and bus are different libraries.
> > If above correct, there is no point of making the function experimental, can
> > drop the __rte_experimental tag, and update .map file to not use
> > EXPERIMENTAL.
> 
> Hi Ferruh,
> 
> Just double confirm with you, if I follow this modification, there is one checkpatch error.

This is a warning, and Ferruh allows it in this case :)