From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5AFCF1B494; Tue, 16 Apr 2019 11:25:18 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 02:25:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,357,1549958400"; d="scan'208";a="136214876" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.220.103]) by orsmga006.jf.intel.com with SMTP; 16 Apr 2019 02:25:14 -0700 Received: by (sSMTP sendmail emulation); Tue, 16 Apr 2019 10:25:13 +0100 Date: Tue, 16 Apr 2019 10:25:12 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: "Liang, Ma" , Lee Daly , david.hunt@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20190416092511.GA1861@bricha3-MOBL.ger.corp.intel.com> References: <1555084647-75896-1-git-send-email-lee.daly@intel.com> <20190415161110.GA17469@sivswdev09.ir.intel.com> <20190415093640.7ef236c8@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190415093640.7ef236c8@shemminger-XPS-13-9360> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 09:25:19 -0000 On Mon, Apr 15, 2019 at 09:36:40AM -0700, Stephen Hemminger wrote: > On Mon, 15 Apr 2019 17:11:10 +0100 > "Liang, Ma" wrote: > > > > pi->turbo_enable = 0; > > > > > > - > > > + if ((pi->turbo_available) && (pi->curr_idx <= 1)) { > > You (don't) need (so many) parenthesis. True (but it doesn't hurt (either)) :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4A357A00E6 for ; Tue, 16 Apr 2019 11:25:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B62F51B49B; Tue, 16 Apr 2019 11:25:19 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5AFCF1B494; Tue, 16 Apr 2019 11:25:18 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 02:25:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,357,1549958400"; d="scan'208";a="136214876" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.220.103]) by orsmga006.jf.intel.com with SMTP; 16 Apr 2019 02:25:14 -0700 Received: by (sSMTP sendmail emulation); Tue, 16 Apr 2019 10:25:13 +0100 Date: Tue, 16 Apr 2019 10:25:12 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: "Liang, Ma" , Lee Daly , david.hunt@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20190416092511.GA1861@bricha3-MOBL.ger.corp.intel.com> References: <1555084647-75896-1-git-send-email-lee.daly@intel.com> <20190415161110.GA17469@sivswdev09.ir.intel.com> <20190415093640.7ef236c8@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190415093640.7ef236c8@shemminger-XPS-13-9360> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416092512.JMz-GKO5pYZ_iz22S75gQWC2aSou14E5Lhh8e2d7GZQ@z> On Mon, Apr 15, 2019 at 09:36:40AM -0700, Stephen Hemminger wrote: > On Mon, 15 Apr 2019 17:11:10 +0100 > "Liang, Ma" wrote: > > > > pi->turbo_enable = 0; > > > > > > - > > > + if ((pi->turbo_available) && (pi->curr_idx <= 1)) { > > You (don't) need (so many) parenthesis. True (but it doesn't hurt (either)) :-)