From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 881B91B4F7;
Tue, 16 Apr 2019 17:39:39 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
16 Apr 2019 08:39:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,358,1549958400"; d="scan'208";a="131897849"
Received: from silpixa00399752.ir.intel.com (HELO
silpixa00399752.ger.corp.intel.com) ([10.237.222.212])
by orsmga007.jf.intel.com with ESMTP; 16 Apr 2019 08:39:37 -0700
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Cc: dev@dpdk.org,
stable@dpdk.org
Date: Tue, 16 Apr 2019 16:39:32 +0100
Message-Id: <20190416153932.21788-2-ferruh.yigit@intel.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20190416153932.21788-1-ferruh.yigit@intel.com>
References: <20190410140058.26782-1-ferruh.yigit@intel.com>
<20190416153932.21788-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v2 2/2] build: fix crash by disabling AVX512 with
binutils 2.31
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2019 15:39:40 -0000
On Skylake platform, with native build, KNI kernel module crashes
because of the corrupted values passed to kernel module.
The corruption occurs because the userspace kni library works
unexpectedly. Compiler [1] is using AVX512 instructions and generated
binary is wrong [2].
It turned around gcc does its job correct, but gas is generating binary
wrong. And expected binutils 2.30, 2.31 & 2.31.1 are affected. Issue has
been fixed in binutils 2.32 with:
Commit x86: don't mistakenly scale non-8-bit displacements
AVX512 was already disabled with bintuils 2.30 [3], extending it to
2.31 & 2.31.1 too.
[1] gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
[2] gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028
[3] Bugzilla ID 97 has the details.
Bugzilla ID: 249
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
v2:
* Release notes "Known Issues" section updated
---
config/x86/meson.build | 6 ++++++
doc/guides/rel_notes/release_19_05.rst | 6 ++++++
mk/toolchain/gcc/rte.toolchain-compat.mk | 9 ++++++++-
3 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/config/x86/meson.build b/config/x86/meson.build
index 692aebe7a..9e9d5dc8c 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -10,6 +10,12 @@ if host_machine.system() != 'windows'
message('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97')
endif
endif
+ if ldver.contains('2.31')
+ if cc.has_argument('-mno-avx512f')
+ machine_args += '-mno-avx512f'
+ message('Binutils 2.31 detected, disabling AVX512 support as workaround for bug #249')
+ endif
+ endif
endif
# we require SSE4.2 for DPDK
diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst
index 25cd61ca2..cf04b9b26 100644
--- a/doc/guides/rel_notes/release_19_05.rst
+++ b/doc/guides/rel_notes/release_19_05.rst
@@ -338,6 +338,12 @@ Known Issues
Also, make sure to start the actual text at the margin.
=========================================================
+* **On x86 platforms, AVX512 support is disabled with binutils 2.31**
+
+ Because a defect in binutils 2.31 AVX512 support is disabled.
+ DPDK defect: https://bugs.dpdk.org/show_bug.cgi?id=249
+ GCC defect: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028
+
* **No software AES-XTS implementation.**
There are currently no cryptodev software PMDs available which implement
diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index df71e4a8b..ea40a11c0 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -27,7 +27,14 @@ ifneq ($(filter 2.30%,$(LD_VERSION)),)
FORCE_DISABLE_AVX512 := y
# print warning only once for librte_eal
ifneq ($(filter %librte_eal,$(CURDIR)),)
-$(warning AVX512 support disabled because of ld 2.30. See Bug 97)
+$(warning AVX512 support disabled because of binutils 2.30. See Bug 97)
+endif
+endif
+ifneq ($(filter 2.31%,$(LD_VERSION)),)
+FORCE_DISABLE_AVX512 := y
+# print warning only once for librte_eal
+ifneq ($(filter %librte_eal,$(CURDIR)),)
+$(warning AVX512 support disabled because of binutils 2.31. See Bug 249)
endif
endif
endif
--
2.20.1
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id F3C6AA00E6
for <public@inbox.dpdk.org>; Tue, 16 Apr 2019 17:39:53 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 716B21B510;
Tue, 16 Apr 2019 17:39:46 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by dpdk.org (Postfix) with ESMTP id 881B91B4F7;
Tue, 16 Apr 2019 17:39:39 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
16 Apr 2019 08:39:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,358,1549958400"; d="scan'208";a="131897849"
Received: from silpixa00399752.ir.intel.com (HELO
silpixa00399752.ger.corp.intel.com) ([10.237.222.212])
by orsmga007.jf.intel.com with ESMTP; 16 Apr 2019 08:39:37 -0700
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Cc: dev@dpdk.org,
stable@dpdk.org
Date: Tue, 16 Apr 2019 16:39:32 +0100
Message-Id: <20190416153932.21788-2-ferruh.yigit@intel.com>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20190416153932.21788-1-ferruh.yigit@intel.com>
References: <20190410140058.26782-1-ferruh.yigit@intel.com>
<20190416153932.21788-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v2 2/2] build: fix crash by disabling AVX512 with
binutils 2.31
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <20190416153932.BYKPiWWtPI-MtAhF-QEj4wx8nlcympUM43Iv67tzqUo@z>
On Skylake platform, with native build, KNI kernel module crashes
because of the corrupted values passed to kernel module.
The corruption occurs because the userspace kni library works
unexpectedly. Compiler [1] is using AVX512 instructions and generated
binary is wrong [2].
It turned around gcc does its job correct, but gas is generating binary
wrong. And expected binutils 2.30, 2.31 & 2.31.1 are affected. Issue has
been fixed in binutils 2.32 with:
Commit x86: don't mistakenly scale non-8-bit displacements
AVX512 was already disabled with bintuils 2.30 [3], extending it to
2.31 & 2.31.1 too.
[1] gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
[2] gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028
[3] Bugzilla ID 97 has the details.
Bugzilla ID: 249
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
v2:
* Release notes "Known Issues" section updated
---
config/x86/meson.build | 6 ++++++
doc/guides/rel_notes/release_19_05.rst | 6 ++++++
mk/toolchain/gcc/rte.toolchain-compat.mk | 9 ++++++++-
3 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/config/x86/meson.build b/config/x86/meson.build
index 692aebe7a..9e9d5dc8c 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -10,6 +10,12 @@ if host_machine.system() != 'windows'
message('Binutils 2.30 detected, disabling AVX512 support as workaround for bug #97')
endif
endif
+ if ldver.contains('2.31')
+ if cc.has_argument('-mno-avx512f')
+ machine_args += '-mno-avx512f'
+ message('Binutils 2.31 detected, disabling AVX512 support as workaround for bug #249')
+ endif
+ endif
endif
# we require SSE4.2 for DPDK
diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst
index 25cd61ca2..cf04b9b26 100644
--- a/doc/guides/rel_notes/release_19_05.rst
+++ b/doc/guides/rel_notes/release_19_05.rst
@@ -338,6 +338,12 @@ Known Issues
Also, make sure to start the actual text at the margin.
=========================================================
+* **On x86 platforms, AVX512 support is disabled with binutils 2.31**
+
+ Because a defect in binutils 2.31 AVX512 support is disabled.
+ DPDK defect: https://bugs.dpdk.org/show_bug.cgi?id=249
+ GCC defect: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028
+
* **No software AES-XTS implementation.**
There are currently no cryptodev software PMDs available which implement
diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk
index df71e4a8b..ea40a11c0 100644
--- a/mk/toolchain/gcc/rte.toolchain-compat.mk
+++ b/mk/toolchain/gcc/rte.toolchain-compat.mk
@@ -27,7 +27,14 @@ ifneq ($(filter 2.30%,$(LD_VERSION)),)
FORCE_DISABLE_AVX512 := y
# print warning only once for librte_eal
ifneq ($(filter %librte_eal,$(CURDIR)),)
-$(warning AVX512 support disabled because of ld 2.30. See Bug 97)
+$(warning AVX512 support disabled because of binutils 2.30. See Bug 97)
+endif
+endif
+ifneq ($(filter 2.31%,$(LD_VERSION)),)
+FORCE_DISABLE_AVX512 := y
+# print warning only once for librte_eal
+ifneq ($(filter %librte_eal,$(CURDIR)),)
+$(warning AVX512 support disabled because of binutils 2.31. See Bug 249)
endif
endif
endif
--
2.20.1