From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9AD2BA00E6 for ; Wed, 17 Apr 2019 01:07:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 775191B526; Wed, 17 Apr 2019 01:07:58 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48]) by dpdk.org (Postfix) with ESMTP id BEEF41B504 for ; Wed, 17 Apr 2019 01:07:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gsCnu0tZBDUE1OejQDTNQ9D+KINzY+nn081sKssSB/Q=; b=LzyrF1CvcdQqVSu3oia1/jIQDm90di4R+pQQAvDpiz3Af+f+1fGUuD0VGLS41gJfLBpsOIIGblFZhPrGysMSZ6rRvbtnoyBy1MrAwmqPTE5I4+8MOcPno5LQJ2GFh1hnITBKY0pl9+rqiopKe+yhRu1lX+d/gvru4DXh/Amjnq0= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4091.eurprd05.prod.outlook.com (52.134.68.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Tue, 16 Apr 2019 23:07:52 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a%3]) with mapi id 15.20.1813.011; Tue, 16 Apr 2019 23:07:52 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix missing init for flow group Thread-Index: AQHU8v9Pa8f7jAuIvkKA+dxwm6q5WKY/bGWA Date: Tue, 16 Apr 2019 23:07:52 +0000 Message-ID: <20190416230742.GB21044@mtidpdk.mti.labs.mlnx> References: <1555273135-1773-1-git-send-email-orika@mellanox.com> In-Reply-To: <1555273135-1773-1-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR01CA0054.prod.exchangelabs.com (2603:10b6:a03:94::31) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 804c63a2-893a-4de8-1a80-08d6c2c05a3a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:DB3PR0502MB4091; x-ms-traffictypediagnostic: DB3PR0502MB4091: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(346002)(136003)(376002)(366004)(199004)(189003)(68736007)(5660300002)(76176011)(186003)(102836004)(386003)(6506007)(105586002)(25786009)(478600001)(52116002)(106356001)(26005)(6116002)(6246003)(3846002)(9686003)(305945005)(4326008)(7736002)(476003)(6862004)(446003)(11346002)(6512007)(33656002)(2906002)(53936002)(486006)(8676002)(8936002)(81166006)(86362001)(81156014)(54906003)(256004)(1076003)(6486002)(6636002)(6436002)(14454004)(71190400001)(229853002)(71200400001)(316002)(99286004)(66066001)(4744005)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4091; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: XrtZp5lM3M+klTlEmrQGBXYpzVGmgG0a1pfCpLbAM6qvAm6CbUWvJQ699i6ZvqGQrwZFNWZDcD1nFnYhMsgjw+b4ss+4tD9A9mRwvOJy8abfUOopsHn64zCyoSrV56Ksztwlls1LXRT+PK9h8HkgtglC6RbcbFaCpf3gKD/rFVXJ1LnSW1vTvsMOJgGlLQVu0MqMJInxUbWaIWTEJLAH/u9ElLr3HlMiDUgHe+VH+FIpWPJxfQdVuwX81EBQzRa2F5BTRGq12KuMEx34e5Pb+DRL+YQ/w5iLFdcosz5Sq6mTpRtLSzj75mKSIpGqJG6dyKCg5LQH6VJy2MCpIxrhVNON8SGeaUQgNyE5NA4BJu33BSGP5MrJMpusKiBXXIGXMIEKF/dTtaTd0eOMPrTRxNIVM+HkzGtuwJ7txd9Y8CA= Content-Type: text/plain; charset="UTF-8" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 804c63a2-893a-4de8-1a80-08d6c2c05a3a X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 23:07:52.4681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4091 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416230752.kdzgZOLM-9STVOkX-9EB348ibMJJcLBcwYUgmaXVB5I@z> On Sun, Apr 14, 2019 at 08:18:55PM +0000, Ori Kam wrote: > the flow group should be initialized. > For example selecting if the encapsulation is for root or private tables > is based on the flow->group value. >=20 > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") >=20 > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_flow_dv.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow= _dv.c > index 3862b26..82e8749 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] =3D { > union flow_dv_attr flow_attr =3D { .attr =3D 0 }; > struct mlx5_flow_dv_tag_resource tag_resource; > =20 > + flow->group =3D attr->group; > if (priority =3D=3D MLX5_FLOW_PRIO_RSVD) > priority =3D priv->config.flow_prio - 1; > for (; !actions_end ; actions++) { > --=20 > 1.8.3.1 >=20