From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20064.outbound.protection.outlook.com [40.107.2.64]) by dpdk.org (Postfix) with ESMTP id B4EFB1B554 for ; Wed, 17 Apr 2019 01:47:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hp3dOA5R9DNUhxPEurnQ7Fsz0iH5VDkwhCLpbUnUls8=; b=MRJOy9dNi8Wwfy1MbjPrBLd9p6+khfMo1+0oTri9uCkXMsy64454MwZHiwllXkY7IXCpieu90uh1QQTMY2gxrHTwwwQ23LwOod6gq3hKg0hIc3oEShr0Qb5o34FwQ+YsHqW5xJFqHtnGdMPhsvQWGb7jJcKqp8nuJYybzcGk2/o= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4058.eurprd05.prod.outlook.com (52.134.68.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.18; Tue, 16 Apr 2019 23:47:42 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a%3]) with mapi id 15.20.1813.011; Tue, 16 Apr 2019 23:47:42 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH 1/9] net/mlx5: fix translate vport function name Thread-Index: AQHU8wbgxZ0w1zmw3UCDwanl1Edch6Y/d3qA Date: Tue, 16 Apr 2019 23:47:42 +0000 Message-ID: <20190416234734.GD21044@mtidpdk.mti.labs.mlnx> References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-2-git-send-email-orika@mellanox.com> In-Reply-To: <1555276357-4892-2-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR05CA0101.namprd05.prod.outlook.com (2603:10b6:a03:e0::42) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97407b28-a051-47ee-254c-08d6c2c5eade x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4058; x-ms-traffictypediagnostic: DB3PR0502MB4058: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(396003)(346002)(136003)(366004)(199004)(189003)(6636002)(26005)(2906002)(305945005)(4326008)(186003)(316002)(7736002)(66066001)(256004)(446003)(478600001)(71190400001)(71200400001)(11346002)(6862004)(6246003)(33656002)(97736004)(54906003)(486006)(52116002)(9686003)(8676002)(229853002)(6512007)(53936002)(81156014)(6116002)(3846002)(25786009)(76176011)(99286004)(476003)(106356001)(68736007)(6486002)(81166006)(105586002)(6436002)(102836004)(8936002)(1076003)(14454004)(6506007)(386003)(5660300002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4058; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NCN5oKLln4S7Sq/R0a646ddVT52TnTsRdmdNrdKgMio4GOXoBge6LDWrf5E9QuUDgft2qHo15R0P0e9o09EbETxVVxqRW75EW27NVbefQPgXYhPvkRX07rlErHEupeM+1vC3TInGqmnvWJumUmVkBjNhAl2X2gRn9gNl2c0BEOpzwRVXrRqVxas7VlawM0M38U5myiC988Udhjcl5SSmsZL7cG0nMSHlLK0Kr1Sf2vTvrK1juVdUk/kZmuq//H3rFEXrJDRteKltkto1AxJq84VZCBrgqUllCP92YxotDbfyvxfr1cETy9dHGGGou3t+MaUokiT3wjnHwesZexnvPottDJYjcM1vGeB9XaHcdND8V35AtyLK4G8/Smcs316isiM06kJZp7smbKJrMt7ZrE6tIWYjKH8rNHQHpgO9ll4= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97407b28-a051-47ee-254c-08d6c2c5eade X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 23:47:42.6298 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4058 Subject: Re: [dpdk-dev] [PATCH 1/9] net/mlx5: fix translate vport function name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 23:47:49 -0000 On Sun, Apr 14, 2019 at 09:12:29PM +0000, Ori Kam wrote: > Modify the translate vport function to match other translate items > naming convestions. >=20 > Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rul= es") > Cc: viacheslavo@mellanox.com >=20 > Signed-off-by: Ori Kam > --- Small suggestion. How about flow_dv_translate_item_src_vport()? Looks quite= long name.. Either you take it or not, Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_flow_dv.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow= _dv.c > index 3862b26..7b582f0 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -3087,8 +3087,8 @@ struct field_modify_info modify_tcp[] =3D { > * Mask > */ > static void > -flow_dv_translate_source_vport(void *matcher, void *key, > - int16_t port, uint16_t mask) > +flow_dv_translate_item_source_vport(void *matcher, void *key, > + int16_t port, uint16_t mask) > { > void *misc_m =3D MLX5_ADDR_OF(fte_match_param, matcher, misc_parameters= ); > void *misc_v =3D MLX5_ADDR_OF(fte_match_param, key, misc_parameters); > @@ -3492,10 +3492,10 @@ struct field_modify_info modify_tcp[] =3D { > * Add matching on source vport index only > * for ingress rules in E-Switch configurations. > */ > - flow_dv_translate_source_vport(matcher.mask.buf, > - dev_flow->dv.value.buf, > - priv->vport_id, > - 0xffff); > + flow_dv_translate_item_source_vport(matcher.mask.buf, > + dev_flow->dv.value.buf, > + priv->vport_id, > + 0xffff); > } > for (; items->type !=3D RTE_FLOW_ITEM_TYPE_END; items++) { > int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > --=20 > 1.8.3.1 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2D04FA00E6 for ; Wed, 17 Apr 2019 01:47:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2540D1B559; Wed, 17 Apr 2019 01:47:50 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20064.outbound.protection.outlook.com [40.107.2.64]) by dpdk.org (Postfix) with ESMTP id B4EFB1B554 for ; Wed, 17 Apr 2019 01:47:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hp3dOA5R9DNUhxPEurnQ7Fsz0iH5VDkwhCLpbUnUls8=; b=MRJOy9dNi8Wwfy1MbjPrBLd9p6+khfMo1+0oTri9uCkXMsy64454MwZHiwllXkY7IXCpieu90uh1QQTMY2gxrHTwwwQ23LwOod6gq3hKg0hIc3oEShr0Qb5o34FwQ+YsHqW5xJFqHtnGdMPhsvQWGb7jJcKqp8nuJYybzcGk2/o= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4058.eurprd05.prod.outlook.com (52.134.68.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.18; Tue, 16 Apr 2019 23:47:42 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a%3]) with mapi id 15.20.1813.011; Tue, 16 Apr 2019 23:47:42 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH 1/9] net/mlx5: fix translate vport function name Thread-Index: AQHU8wbgxZ0w1zmw3UCDwanl1Edch6Y/d3qA Date: Tue, 16 Apr 2019 23:47:42 +0000 Message-ID: <20190416234734.GD21044@mtidpdk.mti.labs.mlnx> References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-2-git-send-email-orika@mellanox.com> In-Reply-To: <1555276357-4892-2-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR05CA0101.namprd05.prod.outlook.com (2603:10b6:a03:e0::42) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97407b28-a051-47ee-254c-08d6c2c5eade x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4058; x-ms-traffictypediagnostic: DB3PR0502MB4058: x-microsoft-antispam-prvs: x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(396003)(346002)(136003)(366004)(199004)(189003)(6636002)(26005)(2906002)(305945005)(4326008)(186003)(316002)(7736002)(66066001)(256004)(446003)(478600001)(71190400001)(71200400001)(11346002)(6862004)(6246003)(33656002)(97736004)(54906003)(486006)(52116002)(9686003)(8676002)(229853002)(6512007)(53936002)(81156014)(6116002)(3846002)(25786009)(76176011)(99286004)(476003)(106356001)(68736007)(6486002)(81166006)(105586002)(6436002)(102836004)(8936002)(1076003)(14454004)(6506007)(386003)(5660300002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4058; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NCN5oKLln4S7Sq/R0a646ddVT52TnTsRdmdNrdKgMio4GOXoBge6LDWrf5E9QuUDgft2qHo15R0P0e9o09EbETxVVxqRW75EW27NVbefQPgXYhPvkRX07rlErHEupeM+1vC3TInGqmnvWJumUmVkBjNhAl2X2gRn9gNl2c0BEOpzwRVXrRqVxas7VlawM0M38U5myiC988Udhjcl5SSmsZL7cG0nMSHlLK0Kr1Sf2vTvrK1juVdUk/kZmuq//H3rFEXrJDRteKltkto1AxJq84VZCBrgqUllCP92YxotDbfyvxfr1cETy9dHGGGou3t+MaUokiT3wjnHwesZexnvPottDJYjcM1vGeB9XaHcdND8V35AtyLK4G8/Smcs316isiM06kJZp7smbKJrMt7ZrE6tIWYjKH8rNHQHpgO9ll4= Content-Type: text/plain; charset="UTF-8" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97407b28-a051-47ee-254c-08d6c2c5eade X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 23:47:42.6298 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4058 Subject: Re: [dpdk-dev] [PATCH 1/9] net/mlx5: fix translate vport function name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416234742.JsHPK7h1C4yuPR7ikePdE7qvnbOHdLOzgO1PHcEWIJ0@z> On Sun, Apr 14, 2019 at 09:12:29PM +0000, Ori Kam wrote: > Modify the translate vport function to match other translate items > naming convestions. >=20 > Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rul= es") > Cc: viacheslavo@mellanox.com >=20 > Signed-off-by: Ori Kam > --- Small suggestion. How about flow_dv_translate_item_src_vport()? Looks quite= long name.. Either you take it or not, Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_flow_dv.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow= _dv.c > index 3862b26..7b582f0 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -3087,8 +3087,8 @@ struct field_modify_info modify_tcp[] =3D { > * Mask > */ > static void > -flow_dv_translate_source_vport(void *matcher, void *key, > - int16_t port, uint16_t mask) > +flow_dv_translate_item_source_vport(void *matcher, void *key, > + int16_t port, uint16_t mask) > { > void *misc_m =3D MLX5_ADDR_OF(fte_match_param, matcher, misc_parameters= ); > void *misc_v =3D MLX5_ADDR_OF(fte_match_param, key, misc_parameters); > @@ -3492,10 +3492,10 @@ struct field_modify_info modify_tcp[] =3D { > * Add matching on source vport index only > * for ingress rules in E-Switch configurations. > */ > - flow_dv_translate_source_vport(matcher.mask.buf, > - dev_flow->dv.value.buf, > - priv->vport_id, > - 0xffff); > + flow_dv_translate_item_source_vport(matcher.mask.buf, > + dev_flow->dv.value.buf, > + priv->vport_id, > + 0xffff); > } > for (; items->type !=3D RTE_FLOW_ITEM_TYPE_END; items++) { > int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > --=20 > 1.8.3.1 >=20