Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules

[Yongseok Koh <yskoh@mellanox.com>]

> On Apr 16, 2019, at 5:01 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
> 
> On Sun, Apr 14, 2019 at 09:12:30PM +0000, Ori Kam wrote:
>> The meson build was missing the define for Direct Rules.

And a typo in the title.
menson -> meson

Also would be better to use 'meson build' instead of 'meson compilation'

"net/mlx5: fix meson build for Direct Rules"

>> 
>> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
>> Cc: orika@mellanox.com
>> 
>> Signed-off-by: Ori Kam <orika@mellanox.com>
>> ---
>> drivers/net/mlx5/meson.build | 2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
>> index a4c684e..0037e15 100644
>> --- a/drivers/net/mlx5/meson.build
>> +++ b/drivers/net/mlx5/meson.build
>> @@ -111,6 +111,8 @@ if build
>> 		'mlx5dv_devx_obj_create' ],
>> 		[ 'HAVE_IBV_FLOW_DEVX_COUNTERS', 'infiniband/mlx5dv.h',
>> 		'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ],
>> +		[ 'HAVE_MLX5DV_DR', 'infiniband/mlx5dv.h',
>> +		'MLX5DV_DR_NS_TYPE_TERMINATING' ],
> 
> Better to change the inconsistent naming?
> HAVE_MLX5DV_DR -> HAVE_IBV_FLOW_DV_DIRECT_RULES
> 
> And I want it to be at a similar location to Makefile. Let's put it next to
> HAVE_IBV_FLOW_DV_SUPPORT.
> 
> thanks
> Yongseok
> 
>> 		[ 'HAVE_SUPPORTED_40000baseKR4_Full', 'linux/ethtool.h',
>> 		'SUPPORTED_40000baseKR4_Full' ],
>> 		[ 'HAVE_SUPPORTED_40000baseCR4_Full', 'linux/ethtool.h',
>> -- 
>> 1.8.3.1
>>