From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 00E58A00E6 for ; Wed, 17 Apr 2019 09:13:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C71C35F25; Wed, 17 Apr 2019 09:13:22 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 384352BC1; Wed, 17 Apr 2019 09:13:21 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56E3330832C6; Wed, 17 Apr 2019 07:13:20 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 000175D9C8; Wed, 17 Apr 2019 07:13:18 +0000 (UTC) To: Tiwei Bie , Mohammad Abdul Awal Cc: dev@dpdk.org, zhihong.wang@intel.com, stable@dpdk.org References: <20190404085317.32337-1-mohammad.abdul.awal@intel.com> <20190408033845.GC20719@dpdk-tbie.sh.intel.com> From: Maxime Coquelin Message-ID: Date: Wed, 17 Apr 2019 09:13:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190408033845.GC20719@dpdk-tbie.sh.intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 17 Apr 2019 07:13:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix null pointer checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417071317.WcMTGJiNjdcFymv24FAIORO5aAxtZf_3VD6uKgP1UFQ@z> On 4/8/19 5:38 AM, Tiwei Bie wrote: > On Thu, Apr 04, 2019 at 09:53:17AM +0100, Mohammad Abdul Awal wrote: >> Null value for parameters will cause segfault. >> >> Fixes: d7280c9fff ("vhost: support selective datapath") >> Fixes: 72e8543093df ("vhost: add API to get MTU value") >> Fixes: a277c71598 ("vhost: refactor code structure") >> Fixes: ca33faf9ef ("vhost: introduce API to fetch negotiated features") >> Fixes: eb32247457 ("vhost: export guest memory regions") >> Fixes: 40ef286f23 ("vhost: export vhost vring info") >> Fixes: bd2e0c3fe5 ("vhost: add APIs for live migration") >> Fixes: 0b8572a0c1 ("vhost: add external message handling to the API") >> Fixes: b4953225ce ("vhost: add APIs for datapath configuration") > > Would be better to use the same length (12) for hashes. Just FYI, it is possible to define a git alias to do that: $ git config --get alias.fixline log -1 --abbrev=12 --format='Fixes: %h ("%s")%nCc: %ae' $ git fixline c5f21bdae4650bc168638c7b4a2c789e245ba562 Fixes: c5f21bdae465 ("fix indentation in symbol maps") Cc: thomas@monjalon.net