From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Babu Radhakrishnan,
AgalyaX" <agalyax.babu.radhakrishnan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix interactive commands in testpmd guide
Date: Wed, 17 Apr 2019 09:25:23 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260D89C99@IRSMSX108.ger.corp.intel.com> (raw)
Message-ID: <20190417092523.xGb1b_xVxxu34ciZm_TlKnb1h88RuExpOp8L3ZALVjg@z> (raw)
In-Reply-To: <21bf3efc-dd06-6a33-a88f-c5b1cf93f6a6@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, April 16, 2019 4:06 PM
> To: Babu Radhakrishnan, AgalyaX <agalyax.babu.radhakrishnan@intel.com>;
> dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; olivier.matz@6wind.com;
> Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: fix interactive commands in testpmd
> guide
>
> On 4/16/2019 7:33 AM, Agalya Babu RadhaKrishnan wrote:
> > From: Agalya Babu RadhaKrishnan
> <agalyax.babu.radhakrishnan@intel.com>
> >
> > Added some missing documentation for interactive mode commands
> >
> > Fixes: 01b2092a5e ("testpmd: add dump commands for debug")
> > Fixes: caf05a1b86 ("app/testpmd: new command to dump log types")
> >
> > Signed-off-by: Agalya Babu RadhaKrishnan
> > <agalyax.babu.radhakrishnan@intel.com>
>
<snip>
Hi Babu,
./dpdk/devtools/check-git-log.sh -1
Line too long:
Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
Is it candidate for Cc: stable@dpdk.org backport?
doc: fix interactive commands in testpmd guide
I am not sure what can be done about the length of the signoff line.
The Cc: stable@dpdk.org line should be added after the Fixes line.
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
next prev parent reply other threads:[~2019-04-17 9:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 6:33 Agalya Babu RadhaKrishnan
2019-04-16 6:33 ` Agalya Babu RadhaKrishnan
2019-04-16 7:32 ` Rami Rosen
2019-04-16 7:32 ` Rami Rosen
2019-04-16 15:05 ` Ferruh Yigit
2019-04-16 15:05 ` Ferruh Yigit
2019-04-17 9:25 ` Iremonger, Bernard [this message]
2019-04-17 9:25 ` Iremonger, Bernard
2019-04-18 19:51 ` Ferruh Yigit
2019-04-18 19:51 ` Ferruh Yigit
2019-04-23 10:44 ` [dpdk-dev] [PATCH v2] " Agalya Babu RadhaKrishnan
2019-04-23 10:44 ` Agalya Babu RadhaKrishnan
2019-04-23 11:38 ` Ferruh Yigit
2019-04-23 11:38 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260D89C99@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=agalyax.babu.radhakrishnan@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).