Re: [dpdk-dev] [PATCH v3 4/4] net/af_xdp: fix typos in Rx function

[David Marchand <david.marchand@redhat.com>]

On Wed, Apr 17, 2019 at 11:02 AM Xiaolong Ye <xiaolong.ye@intel.com> wrote:

> We should use ETH_AF_XDP_RX_BATCH_SIZE in Rx function rather than
> ETH_AF_XDP_TX_BATCH_SIZE.
>
> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
>
>
Reported-by: David Marchand <david.marchand@redhat.com>

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
> b/drivers/net/af_xdp/rte_eth_af_xdp.c
> index 817092584..ee10df0dc 100644
> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
> @@ -175,12 +175,12 @@ eth_af_xdp_rx(void *queue, struct rte_mbuf **bufs,
> uint16_t nb_pkts)
>         struct xsk_ring_prod *fq = &umem->fq;
>         uint32_t idx_rx = 0;
>         uint32_t free_thresh = fq->size >> 1;
> -       struct rte_mbuf *mbufs[ETH_AF_XDP_TX_BATCH_SIZE];
> +       struct rte_mbuf *mbufs[ETH_AF_XDP_RX_BATCH_SIZE];
>         unsigned long dropped = 0;
>         unsigned long rx_bytes = 0;
>         int rcvd, i;
>
> -       nb_pkts = RTE_MIN(nb_pkts, ETH_AF_XDP_TX_BATCH_SIZE);
> +       nb_pkts = RTE_MIN(nb_pkts, ETH_AF_XDP_RX_BATCH_SIZE);
>
>         if (unlikely(rte_pktmbuf_alloc_bulk(rxq->mb_pool, mbufs, nb_pkts)
> != 0))
>                 return 0;
> --
> 2.17.1
>

Reviewed-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand