From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CEBB2A00E6 for ; Wed, 17 Apr 2019 11:57:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 525751B5EA; Wed, 17 Apr 2019 11:57:35 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by dpdk.org (Postfix) with ESMTP id 1D1721B5D7 for ; Wed, 17 Apr 2019 11:57:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JNANTOZnSdY8Doa0WYNY7h+IpbSAs79e+QAgmb56AUk=; b=Iv6OMbeF8O56WWQQALOeekHb7PCnhlSO10735hWsmw2yeL7PPI8hZM2APySy5mNQkuaASM6QkdWMl+0nyDD5mz3WrE3GMr7VAUVreGtOL2AdQA5geVtEAR6IlgqFYwQp29dlQWie2dvfQHeHTYyMyX6Y19mMMcabN4A3GUDn/c8= Received: from VI1PR04MB4893.eurprd04.prod.outlook.com (20.177.49.154) by VI1PR04MB4830.eurprd04.prod.outlook.com (20.177.49.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Wed, 17 Apr 2019 09:57:32 +0000 Received: from VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7]) by VI1PR04MB4893.eurprd04.prod.outlook.com ([fe80::98b0:84a6:1c08:57c7%3]) with mapi id 15.20.1792.021; Wed, 17 Apr 2019 09:57:32 +0000 From: Akhil Goyal To: Ayuj Verma , "Trahe, Fiona" , "Kusztal, ArkadiuszX" CC: Shally Verma , Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" Thread-Topic: [PATCH v1] fix alphabetical ordering of headers Thread-Index: AdT1A/gTCWmdT48YScCW+n1kVYnAvw== Date: Wed, 17 Apr 2019 09:57:31 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e073a41c-d03f-4c40-c5fa-08d6c31b1bfc x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VI1PR04MB4830; x-ms-traffictypediagnostic: VI1PR04MB4830: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(39860400002)(376002)(366004)(136003)(396003)(346002)(189003)(13464003)(199004)(7696005)(53936002)(486006)(8936002)(316002)(3846002)(110136005)(54906003)(6116002)(790700001)(6436002)(14444005)(256004)(81166006)(97736004)(2906002)(229853002)(74316002)(52536014)(476003)(4326008)(81156014)(102836004)(7736002)(8676002)(66066001)(236005)(26005)(99286004)(105586002)(478600001)(106356001)(5660300002)(55016002)(71200400001)(71190400001)(68736007)(6506007)(53546011)(186003)(54896002)(6306002)(9686003)(14454004)(44832011)(9326002)(25786009)(33656002)(6246003)(86362001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4830; H:VI1PR04MB4893.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 8Rk8YLJk9NblsYTDHwkxA5zQlb7wHLbs8L+7virqF6vOyrssTW2COWXJAGHhT/gDWGe2YFj1/jXf47VsG6EMpEfylFcD1NQqoMIxbek4nCIMsiqtu0I0dV0XV7bihfeBeF8Ry9CfUkiae5qAIBu/anRYLJ7iIQLounDFbflsVIxh9ZPYHchU5dOxI7MO5S9Wr2/vtrdD64DS7kMk5b1RwSb7SZVYIhMWHNwZJYwf4WhzXwjJzAwD6YUUqnLDn0+653IAWNTRLB3e3Z8yeb7z4ZfVQREJJNRMm5pQUICZLf4moU3HcAnnI4u7l7TXqK7eub0eqtxl3pKmnoJWyld05FyKHTOR3c2IqCS/nEODuc8F9VnKnx+x8MeHqkQ+HvAuzfbTDxUGIt9rIuVKQ7xlffP4YEFMIQ8RxYE9lgcMHkM= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e073a41c-d03f-4c40-c5fa-08d6c31b1bfc X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 09:57:31.9316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4830 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417095731.M16dFqZ72Jm0ZDdXQXw_eNbl5X28H5Upnuk-U-kyhwY@z> Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.goyal@nxp.com; Kusztal, ArkadiuszX = >; Trahe,= Fiona > > > Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; adesai@marvell.com; > dev@dpdk.org; Ayuj Verma > > Subject: [PATCH v1] fix alphabetical ordering of headers > > rte_crypto_sym.h is included prior to rte_crypto_asym.h > in rte_crypto.h, which breaks alphabetical order. > > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. [Fiona] I presume you tried just swapping the order and it broke? If something in rte_crypto_asym.h depends on something from rte_crypto_sym.= h, it probably shouldn't. What's the dependency and can/should it be moved to rte= _crypto.h? [Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So = do you suggest to move it to rte_crypto.h? [Akhil] moving the enum is not a good idea. I believe we do not need this c= hange at all. Keeping the headers in alphabetical order may be a preferred = way, But it should not be mandatory, there may be some dependencies like this.