* [dpdk-dev] [PATCH] drivers/crypto: fix session destroy for dpaa and dpaa2
@ 2019-04-17 10:09 Akhil Goyal
2019-04-17 10:09 ` Akhil Goyal
2019-04-17 10:28 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
0 siblings, 2 replies; 6+ messages in thread
From: Akhil Goyal @ 2019-04-17 10:09 UTC (permalink / raw)
To: dev; +Cc: Hemant Agrawal, Akhil Goyal, stable
Fixes: 1f14d500bce1 ("crypto/dpaa_sec: support IPsec protocol offload")
Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec")
Coverity issue: 336798
Cc: stable@dpdk.org
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 5b72b9ee4..0d273bb62 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -2836,7 +2836,7 @@ dpaa2_sec_security_session_destroy(void *dev __rte_unused,
rte_free(s->ctxt);
rte_free(s->cipher_key.data);
rte_free(s->auth_key.data);
- memset(sess, 0, sizeof(dpaa2_sec_session));
+ memset(s, 0, sizeof(dpaa2_sec_session));
set_sec_session_private_data(sess, NULL);
rte_mempool_put(sess_mp, sess_priv);
}
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
index 8305f19a3..d9a7cd8a4 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.c
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
@@ -2453,7 +2453,7 @@ dpaa_sec_security_session_destroy(void *dev __rte_unused,
rte_free(s->cipher_key.data);
rte_free(s->auth_key.data);
- memset(sess, 0, sizeof(dpaa_sec_session));
+ memset(s, 0, sizeof(dpaa_sec_session));
set_sec_session_private_data(sess, NULL);
rte_mempool_put(sess_mp, sess_priv);
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] drivers/crypto: fix session destroy for dpaa and dpaa2
2019-04-17 10:09 [dpdk-dev] [PATCH] drivers/crypto: fix session destroy for dpaa and dpaa2 Akhil Goyal
@ 2019-04-17 10:09 ` Akhil Goyal
2019-04-17 10:28 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
1 sibling, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2019-04-17 10:09 UTC (permalink / raw)
To: dev; +Cc: Hemant Agrawal, Akhil Goyal, stable
Fixes: 1f14d500bce1 ("crypto/dpaa_sec: support IPsec protocol offload")
Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec")
Coverity issue: 336798
Cc: stable@dpdk.org
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 5b72b9ee4..0d273bb62 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -2836,7 +2836,7 @@ dpaa2_sec_security_session_destroy(void *dev __rte_unused,
rte_free(s->ctxt);
rte_free(s->cipher_key.data);
rte_free(s->auth_key.data);
- memset(sess, 0, sizeof(dpaa2_sec_session));
+ memset(s, 0, sizeof(dpaa2_sec_session));
set_sec_session_private_data(sess, NULL);
rte_mempool_put(sess_mp, sess_priv);
}
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
index 8305f19a3..d9a7cd8a4 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.c
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
@@ -2453,7 +2453,7 @@ dpaa_sec_security_session_destroy(void *dev __rte_unused,
rte_free(s->cipher_key.data);
rte_free(s->auth_key.data);
- memset(sess, 0, sizeof(dpaa_sec_session));
+ memset(s, 0, sizeof(dpaa_sec_session));
set_sec_session_private_data(sess, NULL);
rte_mempool_put(sess_mp, sess_priv);
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2] drivers/crypto: fix session destroy for dpaa and dpaa2
2019-04-17 10:09 [dpdk-dev] [PATCH] drivers/crypto: fix session destroy for dpaa and dpaa2 Akhil Goyal
2019-04-17 10:09 ` Akhil Goyal
@ 2019-04-17 10:28 ` Akhil Goyal
2019-04-17 10:28 ` Akhil Goyal
2019-04-18 8:32 ` Hemant Agrawal
1 sibling, 2 replies; 6+ messages in thread
From: Akhil Goyal @ 2019-04-17 10:28 UTC (permalink / raw)
To: dev; +Cc: hemant.agrawal, akhil.goyal, stable
Fixes: 1f14d500bce1 ("crypto/dpaa_sec: support IPsec protocol offload")
Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec")
Coverity issue: 336798
Cc: stable@dpdk.org
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
v2: fix checkpatch
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 5b72b9ee4..0d273bb62 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -2836,7 +2836,7 @@ dpaa2_sec_security_session_destroy(void *dev __rte_unused,
rte_free(s->ctxt);
rte_free(s->cipher_key.data);
rte_free(s->auth_key.data);
- memset(sess, 0, sizeof(dpaa2_sec_session));
+ memset(s, 0, sizeof(dpaa2_sec_session));
set_sec_session_private_data(sess, NULL);
rte_mempool_put(sess_mp, sess_priv);
}
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
index 8305f19a3..d9a7cd8a4 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.c
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
@@ -2453,7 +2453,7 @@ dpaa_sec_security_session_destroy(void *dev __rte_unused,
rte_free(s->cipher_key.data);
rte_free(s->auth_key.data);
- memset(sess, 0, sizeof(dpaa_sec_session));
+ memset(s, 0, sizeof(dpaa_sec_session));
set_sec_session_private_data(sess, NULL);
rte_mempool_put(sess_mp, sess_priv);
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2] drivers/crypto: fix session destroy for dpaa and dpaa2
2019-04-17 10:28 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
@ 2019-04-17 10:28 ` Akhil Goyal
2019-04-18 8:32 ` Hemant Agrawal
1 sibling, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2019-04-17 10:28 UTC (permalink / raw)
To: dev; +Cc: hemant.agrawal, akhil.goyal, stable
Fixes: 1f14d500bce1 ("crypto/dpaa_sec: support IPsec protocol offload")
Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec")
Coverity issue: 336798
Cc: stable@dpdk.org
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
v2: fix checkpatch
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 5b72b9ee4..0d273bb62 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -2836,7 +2836,7 @@ dpaa2_sec_security_session_destroy(void *dev __rte_unused,
rte_free(s->ctxt);
rte_free(s->cipher_key.data);
rte_free(s->auth_key.data);
- memset(sess, 0, sizeof(dpaa2_sec_session));
+ memset(s, 0, sizeof(dpaa2_sec_session));
set_sec_session_private_data(sess, NULL);
rte_mempool_put(sess_mp, sess_priv);
}
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
index 8305f19a3..d9a7cd8a4 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.c
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
@@ -2453,7 +2453,7 @@ dpaa_sec_security_session_destroy(void *dev __rte_unused,
rte_free(s->cipher_key.data);
rte_free(s->auth_key.data);
- memset(sess, 0, sizeof(dpaa_sec_session));
+ memset(s, 0, sizeof(dpaa_sec_session));
set_sec_session_private_data(sess, NULL);
rte_mempool_put(sess_mp, sess_priv);
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] drivers/crypto: fix session destroy for dpaa and dpaa2
2019-04-17 10:28 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
2019-04-17 10:28 ` Akhil Goyal
@ 2019-04-18 8:32 ` Hemant Agrawal
2019-04-18 8:32 ` Hemant Agrawal
1 sibling, 1 reply; 6+ messages in thread
From: Hemant Agrawal @ 2019-04-18 8:32 UTC (permalink / raw)
To: Akhil Goyal, dev; +Cc: stable
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-18 8:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 10:09 [dpdk-dev] [PATCH] drivers/crypto: fix session destroy for dpaa and dpaa2 Akhil Goyal
2019-04-17 10:09 ` Akhil Goyal
2019-04-17 10:28 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
2019-04-17 10:28 ` Akhil Goyal
2019-04-18 8:32 ` Hemant Agrawal
2019-04-18 8:32 ` Hemant Agrawal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).