From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7F207A00E6 for ; Wed, 17 Apr 2019 13:24:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76F5A1B5EC; Wed, 17 Apr 2019 13:24:55 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2BB2D1B5E8 for ; Wed, 17 Apr 2019 13:24:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 04:24:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,361,1549958400"; d="scan'208,217";a="151608310" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga002.jf.intel.com with ESMTP; 17 Apr 2019 04:24:50 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by IRSMSX106.ger.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 12:24:49 +0100 From: "Trahe, Fiona" To: Akhil Goyal , Ayuj Verma , "Kusztal, ArkadiuszX" CC: Shally Verma , Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [PATCH v1] fix alphabetical ordering of headers Thread-Index: AdT1A/gTi6obVnARzEmYuWnWlH+ovgAC5dKA Date: Wed, 17 Apr 2019 11:24:48 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589743BDB@IRSMSX101.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzM3ZDVjMzgtMjgwZS00Y2VjLWE5NzQtYWNmNmJjZmRkNDljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTk4yTGlZUXJXZ3pmSjdEeUp6UTdyOFQ5XC9CekRwVVJoS1JBbkpLRlh5M0NYOFUzbkJPcTY2b1wvRHVER0JMQ3ZtIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417112448.P1DFBIEI6MsxhJ7QSCAAuhOTzmRODpZOV8ifHHfyfgQ@z> Hi Ayuj, Akhil, From: Akhil Goyal [mailto:akhil.goyal@nxp.com] Sent: Wednesday, April 17, 2019 10:58 AM To: Ayuj Verma ; Trahe, Fiona ;= Kusztal, ArkadiuszX Cc: Shally Verma ; Sunila Sahu ; Ka= naka Durga Kotamarthy ; Arvind Desai ; dev@dpdk.org Subject: Re: [PATCH v1] fix alphabetical ordering of headers Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.goyal@nxp.com; Kusztal, ArkadiuszX = >; Trahe,= Fiona > > > Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; adesai@marvell.com; > dev@dpdk.org; Ayuj Verma > > Subject: [PATCH v1] fix alphabetical ordering of headers > > rte_crypto_sym.h is included prior to rte_crypto_asym.h > in rte_crypto.h, which breaks alphabetical order. > > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. [Fiona] I presume you tried just swapping the order and it broke? If something in rte_crypto_asym.h depends on something from rte_crypto_sym.= h, it probably shouldn't. What's the dependency and can/should it be moved to rte= _crypto.h? [Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So = do you suggest to move it to rte_crypto.h? [Akhil] moving the enum is not a good idea. I believe we do not need this c= hange at all. Keeping the headers in alphabetical order may be a preferred = way, But it should not be mandatory, there may be some dependencies like this. [Fiona] I agree with not moving the enum, now that I understand the depende= ncy. Either no change or the original patch are fine with me.