From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 664431B60B for ; Wed, 17 Apr 2019 15:32:00 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 06:31:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,362,1549958400"; d="scan'208";a="338308180" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga006.fm.intel.com with ESMTP; 17 Apr 2019 06:31:58 -0700 Date: Wed, 17 Apr 2019 21:26:13 +0800 From: Ye Xiaolong To: David Marchand Cc: dev , Ferruh Yigit , Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190417132613.GB111540@intel.com> References: <20190417085653.110559-1-xiaolong.ye@intel.com> <20190417085653.110559-2-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 1/4] net/af_xdp: enqueue buf ring when allocate Tx queue fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 13:32:00 -0000 On 04/17, David Marchand wrote: >On Wed, Apr 17, 2019 at 11:02 AM Xiaolong Ye wrote: > >> When it fails to allocate enough slots in Tx queue for transmitting >> packets, we need to return the dequeued addrs to buf ring. >> >> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") >> >> Signed-off-by: Xiaolong Ye >> --- >> drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c >> b/drivers/net/af_xdp/rte_eth_af_xdp.c >> index 007a1c6b4..5cc643ce2 100644 >> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c >> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c >> @@ -276,6 +276,7 @@ eth_af_xdp_tx(void *queue, struct rte_mbuf **bufs, >> uint16_t nb_pkts) >> >> if (xsk_ring_prod__reserve(&txq->tx, nb_pkts, &idx_tx) != nb_pkts) >> { >> kick_tx(txq); >> + rte_ring_enqueue_bulk(umem->buf_ring, addrs, nb_pkts, >> NULL); >> return 0; >> } >> >> -- >> 2.17.1 >> > >When there is no change, please keep Review tags from previous versions. > >Reviewed-by: David Marchand Got it, will add your review tag in next version. Thanks, Xiaolong > >-- >David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5D755A00E6 for ; Wed, 17 Apr 2019 15:32:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 205621B60C; Wed, 17 Apr 2019 15:32:02 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 664431B60B for ; Wed, 17 Apr 2019 15:32:00 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 06:31:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,362,1549958400"; d="scan'208";a="338308180" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga006.fm.intel.com with ESMTP; 17 Apr 2019 06:31:58 -0700 Date: Wed, 17 Apr 2019 21:26:13 +0800 From: Ye Xiaolong To: David Marchand Cc: dev , Ferruh Yigit , Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190417132613.GB111540@intel.com> References: <20190417085653.110559-1-xiaolong.ye@intel.com> <20190417085653.110559-2-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 1/4] net/af_xdp: enqueue buf ring when allocate Tx queue fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417132613.vZcK9Tc65KCUX7mY5d_JW6TmsB4OzszIVhzrRBblP0s@z> On 04/17, David Marchand wrote: >On Wed, Apr 17, 2019 at 11:02 AM Xiaolong Ye wrote: > >> When it fails to allocate enough slots in Tx queue for transmitting >> packets, we need to return the dequeued addrs to buf ring. >> >> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") >> >> Signed-off-by: Xiaolong Ye >> --- >> drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c >> b/drivers/net/af_xdp/rte_eth_af_xdp.c >> index 007a1c6b4..5cc643ce2 100644 >> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c >> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c >> @@ -276,6 +276,7 @@ eth_af_xdp_tx(void *queue, struct rte_mbuf **bufs, >> uint16_t nb_pkts) >> >> if (xsk_ring_prod__reserve(&txq->tx, nb_pkts, &idx_tx) != nb_pkts) >> { >> kick_tx(txq); >> + rte_ring_enqueue_bulk(umem->buf_ring, addrs, nb_pkts, >> NULL); >> return 0; >> } >> >> -- >> 2.17.1 >> > >When there is no change, please keep Review tags from previous versions. > >Reviewed-by: David Marchand Got it, will add your review tag in next version. Thanks, Xiaolong > >-- >David Marchand