From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8CBC01B6CC; Wed, 17 Apr 2019 17:05:00 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 08:04:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,362,1549958400"; d="scan'208";a="292343672" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.220.103]) by orsmga004.jf.intel.com with SMTP; 17 Apr 2019 08:04:50 -0700 Received: by (sSMTP sendmail emulation); Wed, 17 Apr 2019 16:04:49 +0100 Date: Wed, 17 Apr 2019 16:04:49 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: stable@dpdk.org, dev@dpdk.org Message-ID: <20190417150449.GA1807@bricha3-MOBL.ger.corp.intel.com> References: <20190410205224.69977-1-bruce.richardson@intel.com> <20190410205224.69977-2-bruce.richardson@intel.com> <5465672.Kypt5CsLy1@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5465672.Kypt5CsLy1@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 15:05:02 -0000 On Wed, Apr 17, 2019 at 04:59:53PM +0200, Thomas Monjalon wrote: > 10/04/2019 22:52, Bruce Richardson: > > if either gcc or clang are missing, skip doing those builds. > > This allows a setup to only do, e.g. gcc tests. > > > > CC: stable@dpdk.org > > Signed-off-by: Bruce Richardson > > --- > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > # shared and static linked builds with gcc and clang > > for c in gcc clang ; do > > - for s in static shared ; do > > - export CC="ccache $c" > > - build build-$c-$s --default-library=$s > > - done > > + if command -v $c >/dev/null 2>&1 ; then > > + for s in static shared ; do > > + export CC="ccache $c" > > + build build-$c-$s --default-library=$s > > + done > > + fi > > May I suggest this oneline change instead? > > command -v $c >/dev/null 2>&1 || continue > Looks fine to me. Make the change on apply if you like, otherwise let me know if you want a V2. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 06469A00E6 for ; Wed, 17 Apr 2019 17:05:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44CB71B6F0; Wed, 17 Apr 2019 17:05:03 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8CBC01B6CC; Wed, 17 Apr 2019 17:05:00 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 08:04:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,362,1549958400"; d="scan'208";a="292343672" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.220.103]) by orsmga004.jf.intel.com with SMTP; 17 Apr 2019 08:04:50 -0700 Received: by (sSMTP sendmail emulation); Wed, 17 Apr 2019 16:04:49 +0100 Date: Wed, 17 Apr 2019 16:04:49 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: stable@dpdk.org, dev@dpdk.org Message-ID: <20190417150449.GA1807@bricha3-MOBL.ger.corp.intel.com> References: <20190410205224.69977-1-bruce.richardson@intel.com> <20190410205224.69977-2-bruce.richardson@intel.com> <5465672.Kypt5CsLy1@xps> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <5465672.Kypt5CsLy1@xps> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417150449.DJ1LzYaf0xM8kmTwVWk3sySVguce-YnwDbQFLnGoyPY@z> On Wed, Apr 17, 2019 at 04:59:53PM +0200, Thomas Monjalon wrote: > 10/04/2019 22:52, Bruce Richardson: > > if either gcc or clang are missing, skip doing those builds. > > This allows a setup to only do, e.g. gcc tests. > > > > CC: stable@dpdk.org > > Signed-off-by: Bruce Richardson > > --- > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > # shared and static linked builds with gcc and clang > > for c in gcc clang ; do > > - for s in static shared ; do > > - export CC="ccache $c" > > - build build-$c-$s --default-library=$s > > - done > > + if command -v $c >/dev/null 2>&1 ; then > > + for s in static shared ; do > > + export CC="ccache $c" > > + build build-$c-$s --default-library=$s > > + done > > + fi > > May I suggest this oneline change instead? > > command -v $c >/dev/null 2>&1 || continue > Looks fine to me. Make the change on apply if you like, otherwise let me know if you want a V2.