* [dpdk-dev] [PATCH] lib/bitratestats: fix unchecked return value
@ 2019-04-17 15:22 Andrius Sirvys
2019-04-17 15:22 ` Andrius Sirvys
2019-04-17 19:03 ` Rami Rosen
0 siblings, 2 replies; 4+ messages in thread
From: Andrius Sirvys @ 2019-04-17 15:22 UTC (permalink / raw)
To: dev; +Cc: stable, Andrius Sirvys, remy.horton
Checking the return value of rte_metrics_update_values, if failed
returning that value.
Coverity had picked up that that the return value wasn't being checked.
Coverity issue: 336863
Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
Cc: remy.horton@intel.com
Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
---
lib/librte_bitratestats/rte_bitrate.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_bitratestats/rte_bitrate.c b/lib/librte_bitratestats/rte_bitrate.c
index c4b28f624..f0e16b3c1 100644
--- a/lib/librte_bitratestats/rte_bitrate.c
+++ b/lib/librte_bitratestats/rte_bitrate.c
@@ -124,7 +124,10 @@ rte_stats_bitrate_calc(struct rte_stats_bitrates *bitrate_data,
values[3] = port_data->mean_obits;
values[4] = port_data->peak_ibits;
values[5] = port_data->peak_obits;
- rte_metrics_update_values(port_id, bitrate_data->id_stats_set,
+ ret = rte_metrics_update_values(port_id, bitrate_data->id_stats_set,
values, ARRAY_SIZE(values));
+ if(ret < 0)
+ return ret;
+
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH] lib/bitratestats: fix unchecked return value
2019-04-17 15:22 [dpdk-dev] [PATCH] lib/bitratestats: fix unchecked return value Andrius Sirvys
@ 2019-04-17 15:22 ` Andrius Sirvys
2019-04-17 19:03 ` Rami Rosen
1 sibling, 0 replies; 4+ messages in thread
From: Andrius Sirvys @ 2019-04-17 15:22 UTC (permalink / raw)
To: dev; +Cc: stable, Andrius Sirvys, remy.horton
Checking the return value of rte_metrics_update_values, if failed
returning that value.
Coverity had picked up that that the return value wasn't being checked.
Coverity issue: 336863
Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library")
Cc: remy.horton@intel.com
Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
---
lib/librte_bitratestats/rte_bitrate.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/librte_bitratestats/rte_bitrate.c b/lib/librte_bitratestats/rte_bitrate.c
index c4b28f624..f0e16b3c1 100644
--- a/lib/librte_bitratestats/rte_bitrate.c
+++ b/lib/librte_bitratestats/rte_bitrate.c
@@ -124,7 +124,10 @@ rte_stats_bitrate_calc(struct rte_stats_bitrates *bitrate_data,
values[3] = port_data->mean_obits;
values[4] = port_data->peak_ibits;
values[5] = port_data->peak_obits;
- rte_metrics_update_values(port_id, bitrate_data->id_stats_set,
+ ret = rte_metrics_update_values(port_id, bitrate_data->id_stats_set,
values, ARRAY_SIZE(values));
+ if(ret < 0)
+ return ret;
+
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] lib/bitratestats: fix unchecked return value
2019-04-17 15:22 [dpdk-dev] [PATCH] lib/bitratestats: fix unchecked return value Andrius Sirvys
2019-04-17 15:22 ` Andrius Sirvys
@ 2019-04-17 19:03 ` Rami Rosen
2019-04-17 19:03 ` Rami Rosen
1 sibling, 1 reply; 4+ messages in thread
From: Rami Rosen @ 2019-04-17 19:03 UTC (permalink / raw)
To: Andrius Sirvys; +Cc: dev, stable, remy.horton
Acked-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-17 19:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 15:22 [dpdk-dev] [PATCH] lib/bitratestats: fix unchecked return value Andrius Sirvys
2019-04-17 15:22 ` Andrius Sirvys
2019-04-17 19:03 ` Rami Rosen
2019-04-17 19:03 ` Rami Rosen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).