From: Yongseok Koh <yskoh@mellanox.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Shahaf Shuler <shahafs@mellanox.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Gavin Hu <gavin.hu@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/4] meson: disable octeontx for buggy compilers on arm64
Date: Thu, 18 Apr 2019 01:43:07 +0000 [thread overview]
Message-ID: <AF02499F-3393-49D5-B32B-68249D959423@mellanox.com> (raw)
Message-ID: <20190418014307.7bjeJHjAQb9xkLTm9kx31l02q7HR4xHqIcwjFvpjea4@z> (raw)
In-Reply-To: <20190418014059.20309-1-yskoh@mellanox.com>
Please disregard this one.
Sent by mistake.
Thanks,
Yongseok
> On Apr 17, 2019, at 6:40 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
>
> Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler
> error" for aarch64
>
> Fixes: bd77f2d64c44 ("event/octeontx: build with meson")
> Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers")
> Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64")
> Cc: pbhagavatula@marvell.com
> Cc: jerinj@marvell.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
>
> v2:
> * fix bug - enable octeontx unless comipler is buggy
>
> drivers/event/meson.build | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/event/meson.build b/drivers/event/meson.build
> index 836ecbb74b..fb723f727b 100644
> --- a/drivers/event/meson.build
> +++ b/drivers/event/meson.build
> @@ -1,7 +1,11 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
>
> -drivers = ['dpaa', 'dpaa2', 'octeontx', 'opdl', 'skeleton', 'sw', 'dsw']
> +drivers = ['dpaa', 'dpaa2', 'opdl', 'skeleton', 'sw', 'dsw']
> +if not (toolchain == 'gcc' and cc.version().version_compare('<4.8.6') and
> + dpdk_conf.has('RTE_ARCH_ARM64'))
> + drivers += 'octeontx'
> +endif
> std_deps = ['eventdev', 'kvargs']
> config_flag_fmt = 'RTE_LIBRTE_@0@_EVENTDEV_PMD'
> driver_name_fmt = 'rte_pmd_@0@_event'
> --
> 2.11.0
>
next prev parent reply other threads:[~2019-04-18 1:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 1:40 Yongseok Koh
2019-04-18 1:40 ` Yongseok Koh
2019-04-18 1:43 ` Yongseok Koh [this message]
2019-04-18 1:43 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AF02499F-3393-49D5-B32B-68249D959423@mellanox.com \
--to=yskoh@mellanox.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).