From: Yongseok Koh <yskoh@mellanox.com>
To: bruce.richardson@intel.com, jerinj@marvell.com,
pbhagavatula@marvell.com, shahafs@mellanox.com
Cc: dev@dpdk.org, thomas@monjalon.net, gavin.hu@arm.com,
Honnappa.Nagarahalli@arm.com, bluca@debian.org, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 3/4] net/mlx: fix library search in meson build
Date: Wed, 17 Apr 2019 18:47:25 -0700 [thread overview]
Message-ID: <20190418014726.20600-3-yskoh@mellanox.com> (raw)
Message-ID: <20190418014725.nmzXcOzWuR-fVio_6J0gLJC0udxb7cfeLP4NPe1SL90@z> (raw)
In-Reply-To: <20190418014726.20600-1-yskoh@mellanox.com>
If MLNX_OFED is installed, there's no .pc file installed for libraries and
dependency() can't find libraries by pkg-config. By adding fallback of
using cc.find_library(), libraries are properly located.
Fixes: e30b4e566f47 ("build: improve dependency handling")
Cc: bluca@debian.org
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
v2:
* change variable names to minimize code change
drivers/net/mlx4/meson.build | 15 +++++++++------
drivers/net/mlx5/meson.build | 15 +++++++++------
2 files changed, 18 insertions(+), 12 deletions(-)
diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
index de020701d1..9d04dd930d 100644
--- a/drivers/net/mlx4/meson.build
+++ b/drivers/net/mlx4/meson.build
@@ -13,14 +13,17 @@ if pmd_dlopen
'-DMLX4_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
]
endif
-libs = [
- dependency('libmnl', required:false),
- dependency('libmlx4', required:false),
- dependency('libibverbs', required:false),
-]
+libnames = [ 'libmnl', 'libmlx4', 'libibverbs' ]
+libs = []
build = true
-foreach lib:libs
+foreach libname:libnames
+ lib = dependency(libname, required:false)
if not lib.found()
+ lib = cc.find_library(libname, required:false)
+ endif
+ if lib.found()
+ libs += [ lib ]
+ else
build = false
endif
endforeach
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index a4c684e1b5..ee8399af27 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -13,14 +13,17 @@ if pmd_dlopen
'-DMLX5_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
]
endif
-libs = [
- dependency('libmnl', required:false),
- dependency('libmlx5', required:false),
- dependency('libibverbs', required:false),
-]
+libnames = [ 'libmnl', 'libmlx5', 'libibverbs' ]
+libs = []
build = true
-foreach lib:libs
+foreach libname:libnames
+ lib = dependency(libname, required:false)
if not lib.found()
+ lib = cc.find_library(libname, required:false)
+ endif
+ if lib.found()
+ libs += [ lib ]
+ else
build = false
endif
endforeach
--
2.11.0
next prev parent reply other threads:[~2019-04-18 1:48 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 23:24 [dpdk-dev] [PATCH 0/6] build: fix build for arm64 Yongseok Koh
2019-04-12 23:24 ` Yongseok Koh
2019-04-12 23:24 ` [dpdk-dev] [PATCH 1/6] meson: disable octeontx for buggy compilers on arm64 Yongseok Koh
2019-04-12 23:24 ` Yongseok Koh
2019-04-13 5:52 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-04-13 5:52 ` Pavan Nikhilesh Bhagavatula
2019-04-15 18:16 ` Yongseok Koh
2019-04-15 18:16 ` Yongseok Koh
2019-04-12 23:24 ` [dpdk-dev] [PATCH 2/6] meson: change default cache line size for cortex-a72 Yongseok Koh
2019-04-12 23:24 ` Yongseok Koh
2019-04-13 6:43 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-04-13 6:43 ` Jerin Jacob Kollanukkaran
2019-04-15 4:35 ` Honnappa Nagarahalli
2019-04-15 4:35 ` Honnappa Nagarahalli
2019-04-15 13:40 ` Honnappa Nagarahalli
2019-04-15 13:40 ` Honnappa Nagarahalli
2019-04-15 20:40 ` Yongseok Koh
2019-04-15 20:40 ` Yongseok Koh
2019-04-15 20:44 ` Honnappa Nagarahalli
2019-04-15 20:44 ` Honnappa Nagarahalli
2019-04-12 23:24 ` [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build Yongseok Koh
2019-04-12 23:24 ` Yongseok Koh
2019-04-15 9:19 ` Bruce Richardson
2019-04-15 9:19 ` Bruce Richardson
2019-04-15 19:48 ` Yongseok Koh
2019-04-15 19:48 ` Yongseok Koh
2019-04-15 10:12 ` Luca Boccassi
2019-04-15 10:12 ` Luca Boccassi
2019-04-15 19:48 ` Yongseok Koh
2019-04-15 19:48 ` Yongseok Koh
2019-04-18 9:25 ` Luca Boccassi
2019-04-18 9:25 ` Luca Boccassi
2019-04-18 10:14 ` Bruce Richardson
2019-04-18 10:14 ` Bruce Richardson
2019-04-18 11:25 ` Yongseok Koh
2019-04-18 11:25 ` Yongseok Koh
2019-04-12 23:24 ` [dpdk-dev] [PATCH 4/6] meson: add Mellanox BlueField cross-compile config Yongseok Koh
2019-04-12 23:24 ` Yongseok Koh
2019-04-13 7:04 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-04-13 7:04 ` Jerin Jacob Kollanukkaran
2019-04-12 23:24 ` [dpdk-dev] [PATCH 5/6] build: add option for armv8 crypto extension Yongseok Koh
2019-04-12 23:24 ` Yongseok Koh
2019-04-13 7:22 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-04-13 7:22 ` Jerin Jacob Kollanukkaran
2019-04-15 4:52 ` Honnappa Nagarahalli
2019-04-15 4:52 ` Honnappa Nagarahalli
2019-04-15 18:43 ` Yongseok Koh
2019-04-15 18:43 ` Yongseok Koh
2019-04-15 20:13 ` Honnappa Nagarahalli
2019-04-15 20:13 ` Honnappa Nagarahalli
2019-04-17 16:28 ` Yongseok Koh
2019-04-17 16:28 ` Yongseok Koh
2019-04-30 3:33 ` Honnappa Nagarahalli
2019-04-30 3:33 ` Honnappa Nagarahalli
2019-05-02 1:54 ` Yongseok Koh
2019-05-02 1:54 ` Yongseok Koh
2019-05-02 10:13 ` Jerin Jacob Kollanukkaran
2019-05-02 10:13 ` Jerin Jacob Kollanukkaran
2019-05-02 23:08 ` Yongseok Koh
2019-05-02 23:08 ` Yongseok Koh
2019-05-02 23:33 ` Yongseok Koh
2019-05-02 23:33 ` Yongseok Koh
2019-05-03 10:28 ` Jerin Jacob Kollanukkaran
2019-05-03 10:28 ` Jerin Jacob Kollanukkaran
2019-05-03 3:54 ` Honnappa Nagarahalli
2019-05-03 3:54 ` Honnappa Nagarahalli
2019-05-03 9:49 ` Yongseok Koh
2019-05-03 9:49 ` Yongseok Koh
2019-05-03 14:21 ` Honnappa Nagarahalli
2019-05-03 14:21 ` Honnappa Nagarahalli
2019-04-12 23:24 ` [dpdk-dev] [PATCH 6/6] mk: disable armv8 crypto extension for Mellanox BlueField Yongseok Koh
2019-04-12 23:24 ` Yongseok Koh
2019-04-13 7:12 ` [dpdk-dev] [EXT] [PATCH 0/6] build: fix build for arm64 Jerin Jacob Kollanukkaran
2019-04-13 7:12 ` Jerin Jacob Kollanukkaran
2019-04-15 20:56 ` Yongseok Koh
2019-04-15 20:56 ` Yongseok Koh
2019-04-16 5:57 ` Jerin Jacob Kollanukkaran
2019-04-16 5:57 ` Jerin Jacob Kollanukkaran
2019-04-17 20:06 ` [dpdk-dev] " Thomas Monjalon
2019-04-17 20:06 ` Thomas Monjalon
2019-04-17 20:24 ` Honnappa Nagarahalli
2019-04-17 20:24 ` Honnappa Nagarahalli
2019-04-17 22:14 ` Yongseok Koh
2019-04-17 22:14 ` Yongseok Koh
2019-04-18 1:47 ` [dpdk-dev] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on arm64 Yongseok Koh
2019-04-18 1:47 ` Yongseok Koh
2019-04-18 1:47 ` [dpdk-dev] [PATCH v2 2/4] meson: change default cache line size for armv8 Yongseok Koh
2019-04-18 1:47 ` Yongseok Koh
2019-04-18 5:00 ` Honnappa Nagarahalli
2019-04-18 5:00 ` Honnappa Nagarahalli
2019-04-18 8:23 ` [dpdk-dev] [EXT] " Hemant Agrawal
2019-04-18 8:23 ` Hemant Agrawal
2019-04-18 11:32 ` Yongseok Koh
2019-04-18 11:32 ` Yongseok Koh
2019-04-18 1:47 ` Yongseok Koh [this message]
2019-04-18 1:47 ` [dpdk-dev] [PATCH v2 3/4] net/mlx: fix library search in meson build Yongseok Koh
2019-04-18 1:47 ` [dpdk-dev] [PATCH v2 4/4] meson: add Mellanox BlueField cross-compile config Yongseok Koh
2019-04-18 1:47 ` Yongseok Koh
2019-04-18 7:21 ` [dpdk-dev] [EXT] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on arm64 Jerin Jacob Kollanukkaran
2019-04-18 7:21 ` Jerin Jacob Kollanukkaran
2019-04-18 10:41 ` Yongseok Koh
2019-04-18 10:41 ` Yongseok Koh
2019-04-18 11:04 ` Thomas Monjalon
2019-04-18 11:04 ` Thomas Monjalon
2019-04-18 11:10 ` Yongseok Koh
2019-04-18 11:10 ` Yongseok Koh
2019-04-18 11:49 ` [dpdk-dev] [PATCH v3 1/4] drivers/event: " Yongseok Koh
2019-04-18 11:49 ` Yongseok Koh
2019-04-18 11:49 ` [dpdk-dev] [PATCH v3 2/4] meson: change default config for armv8 Yongseok Koh
2019-04-18 11:49 ` Yongseok Koh
2019-04-18 14:25 ` Honnappa Nagarahalli
2019-04-18 14:25 ` Honnappa Nagarahalli
2019-04-18 11:49 ` [dpdk-dev] [PATCH v3 3/4] net/mlx: fix library search in meson build Yongseok Koh
2019-04-18 11:49 ` Yongseok Koh
2019-04-18 12:02 ` Luca Boccassi
2019-04-18 12:02 ` Luca Boccassi
2019-04-18 11:49 ` [dpdk-dev] [PATCH v3 4/4] meson: add Mellanox BlueField cross-compile config Yongseok Koh
2019-04-18 11:49 ` Yongseok Koh
2019-04-18 16:23 ` Thomas Monjalon
2019-04-18 16:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418014726.20600-3-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).