From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6446EA00E6 for ; Thu, 18 Apr 2019 05:58:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21B881B907; Thu, 18 Apr 2019 05:58:24 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 4920E1B905 for ; Thu, 18 Apr 2019 05:58:22 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3I3t3ff031079; Wed, 17 Apr 2019 20:58:21 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=LCx46E3E0MSfshhU6gjvoTtv0yeclSxetDx+S+5p4wo=; b=XH8T53JNmsYaArIPfCNzFb++ujudhaakpL0AUcTnNPPBy2C3rNdzFba1Y8Dgjrnf/Ybm bQsF2hs60124vEvCaVos9D8taO5ed+uWhQkMfhEZw4vzurlKFp+n8ztXkxBboygd3p88 nlaYlgJNnKIZBC0FrZ91WqNGWU5wE7fub265HoSU1dzp+eS2HrTC2Ztd/q3MFKhxBDQg 1kQZ+hC2BDSobF/owCrHXDnuelvW1mLPRzvQACGc5BlO8TivQTQt+44OSTOvrxs/u+rg KyjggBajiMyBpQY9PVuSl+zdBPdKhXtygW+SBLjt9LfI7ywaGZrp8LqwinRp5aJVxk/l Tw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2rxh8903pk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 17 Apr 2019 20:58:21 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 17 Apr 2019 20:58:20 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.50) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 17 Apr 2019 20:58:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LCx46E3E0MSfshhU6gjvoTtv0yeclSxetDx+S+5p4wo=; b=ivzMngUItrkjSP6yeK2ioSpE3c4sGbLiWPHb7cCCLBqNSkY0gdwHGPlaUqcf4XEHlK1BPS4NjUTaPoHgAtp4NvauKy0Mc91Yhimu2QaOf1jTDsz1oC49iqK5jXCjJlMnKKPpxR3yhikcqaPtxE8N/rh9E0mLPUKdmIOI8h+Nymc= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2846.namprd18.prod.outlook.com (20.179.21.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Thu, 18 Apr 2019 03:58:18 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::8c8d:3cce:d106:bf62]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::8c8d:3cce:d106:bf62%6]) with mapi id 15.20.1792.022; Thu, 18 Apr 2019 03:58:18 +0000 From: Anoob Joseph To: Ayuj Verma , "akhil.goyal@nxp.com" , "arkadiuszx.kusztal@intel.com" , "fiona.trahe@intel.com" CC: Shally Verma , Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" , Ayuj Verma Thread-Topic: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers Thread-Index: AQHU8P3sxVaO2mfXd0OTyGsB6JauoaZBTeZw Date: Thu, 18 Apr 2019 03:58:18 +0000 Message-ID: References: <1555052602-19155-1-git-send-email-ayverma@marvell.com> <1555052602-19155-2-git-send-email-ayverma@marvell.com> In-Reply-To: <1555052602-19155-2-git-send-email-ayverma@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f2d0593d-d418-43ca-f896-08d6c3b21759 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:MN2PR18MB2846; x-ms-traffictypediagnostic: MN2PR18MB2846: x-microsoft-antispam-prvs: x-forefront-prvs: 0011612A55 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(376002)(396003)(39850400004)(366004)(13464003)(189003)(199004)(53546011)(71200400001)(6506007)(25786009)(71190400001)(55236004)(102836004)(7696005)(99286004)(66066001)(476003)(76176011)(446003)(486006)(3846002)(6116002)(11346002)(26005)(186003)(14454004)(6436002)(229853002)(478600001)(33656002)(52536014)(2201001)(86362001)(5660300002)(2501003)(107886003)(316002)(6246003)(2906002)(4326008)(54906003)(110136005)(55016002)(9686003)(74316002)(305945005)(97736004)(53936002)(7736002)(256004)(14444005)(81166006)(81156014)(68736007)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2846; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jtCncKle3nKCfYESkfKmMiefBCgILB9HpcVB2Yr9IDtAAkZahc/MsF+aediIzC84oB5xXhXDCYFpI6ruEkrlQ3MzAQA6x7HVQaBQIDhTei4LXgA/Zstqzhfg3PMEQis/TPzzt+iDHQh7tSGPKtK//U6X0rQbxedyMSSQu2kS9tYSLW8bT5B9UwA9Xyj4D+CI9LpgTMtGf7N/B25/e47YKL2Y1NrdFbud7xwo/rWehKsQt89D3TNAiAZrvMIk8C412b9QPuOObfEXQG2MAAUS1FYw2zlbhV4DaNZdmNK+lrJH5Hb7PxtEOBigzcyDhpPRiNBx18awNtS5uG8sQBg9RJTAw7UrIgFxYGu7vpDSXJQq9SEIZREqtR0HY0aXCFp6ru2EYznSaNkodDzuDArL+OwA6ArzqvCpNhiFAcDCfBQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f2d0593d-d418-43ca-f896-08d6c3b21759 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 03:58:18.1970 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2846 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-18_03:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418035818.YpL8EWRwhPegrr4O_UiwbSah0QkxQvFtvHkT-yc6STk@z> Hi Ayuj, Akhil, Fiona, Shally, I think there are couple of issues with this patch. The real issue here is = the dependency of rte_crypto_asym.h on rte_crypto_sym.h. If rte_crypto_asym= .h doesn't include all the headers it uses, every file which includes rte_c= rypto_asym.h will have to include rte_crypto_asym.h's dependencies, which i= s not the right practice. Keeping it alphabetical etc comes later. So the patch has to be rephrased to better reflect the purpose. Also please see inline. Thanks, Anoob =20 > -----Original Message----- > From: dev On Behalf Of Ayuj Verma > Sent: Friday, April 12, 2019 12:33 PM > To: akhil.goyal@nxp.com; arkadiuszx.kusztal@intel.com; > fiona.trahe@intel.com > Cc: Shally Verma ; Sunila Sahu ; > Kanaka Durga Kotamarthy ; Arvind Desai > ; dev@dpdk.org; Ayuj Verma > > Subject: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of > headers >=20 > include rte_crypto_sym.h in rte_crypto_asym.h in place of including it in > rte_crypto.h. >=20 > Signed-off-by: Ayuj Verma > Signed-off-by: Shally Verma >=20 > --- > lib/librte_cryptodev/rte_crypto.h | 1 - > lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_cryptodev/rte_crypto.h > b/lib/librte_cryptodev/rte_crypto.h > index fd5ef3a..17dccdf 100644 > --- a/lib/librte_cryptodev/rte_crypto.h > +++ b/lib/librte_cryptodev/rte_crypto.h > @@ -22,7 +22,6 @@ > #include > #include >=20 > -#include "rte_crypto_sym.h" > #include "rte_crypto_asym.h" [Anoob] If rte_crypto.h uses anything defined in rte_crypto_sym.h, then you= cannot remove the include. You can make it alphabetical, but the include h= as to be retained. >=20 > /** Crypto operation types */ > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h > b/lib/librte_cryptodev/rte_crypto_asym.h > index 5e43620..a55923a 100644 > --- a/lib/librte_cryptodev/rte_crypto_asym.h > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > @@ -25,6 +25,8 @@ > #include > #include >=20 > +#include "rte_crypto_sym.h" > + > typedef struct rte_crypto_param_t { > uint8_t *data; > /**< pointer to buffer holding data */ > -- > 1.8.3.1