* [dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE
@ 2019-04-18 4:58 Wei Zhao
2019-04-18 4:58 ` Wei Zhao
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wei Zhao @ 2019-04-18 4:58 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, Wei Zhao
Enable CLEARPBA bit is required by ice NIC of A0/A1 version to
enable Tx and Rx queue interrupt.
Also enable CLEARPBA bit does no impact on IAVF behaviour when be
hosted by other devices, so we can make it as default.
Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/iavf/iavf_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 846e604..57819dd 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1015,11 +1015,13 @@ iavf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
PMD_DRV_LOG(INFO, "MISC is also enabled for control");
IAVF_WRITE_REG(hw, IAVFINT_DYN_CTL01,
IAVFINT_DYN_CTL01_INTENA_MASK |
+ IAVFINT_DYN_CTL01_CLEARPBA_MASK |
IAVFINT_DYN_CTL01_ITR_INDX_MASK);
} else {
IAVF_WRITE_REG(hw,
IAVFINT_DYN_CTLN1(msix_intr - IAVF_RX_VEC_START),
IAVFINT_DYN_CTLN1_INTENA_MASK |
+ IAVFINT_DYN_CTL01_CLEARPBA_MASK |
IAVFINT_DYN_CTLN1_ITR_INDX_MASK);
}
--
2.7.5
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE
2019-04-18 4:58 [dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE Wei Zhao
@ 2019-04-18 4:58 ` Wei Zhao
2019-04-18 8:10 ` Zhang, Qi Z
2019-05-08 10:37 ` [dpdk-dev] [dpdk-stable] " Kevin Traynor
2 siblings, 0 replies; 6+ messages in thread
From: Wei Zhao @ 2019-04-18 4:58 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, Wei Zhao
Enable CLEARPBA bit is required by ice NIC of A0/A1 version to
enable Tx and Rx queue interrupt.
Also enable CLEARPBA bit does no impact on IAVF behaviour when be
hosted by other devices, so we can make it as default.
Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
Cc: stable@dpdk.org
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/iavf/iavf_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 846e604..57819dd 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1015,11 +1015,13 @@ iavf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
PMD_DRV_LOG(INFO, "MISC is also enabled for control");
IAVF_WRITE_REG(hw, IAVFINT_DYN_CTL01,
IAVFINT_DYN_CTL01_INTENA_MASK |
+ IAVFINT_DYN_CTL01_CLEARPBA_MASK |
IAVFINT_DYN_CTL01_ITR_INDX_MASK);
} else {
IAVF_WRITE_REG(hw,
IAVFINT_DYN_CTLN1(msix_intr - IAVF_RX_VEC_START),
IAVFINT_DYN_CTLN1_INTENA_MASK |
+ IAVFINT_DYN_CTL01_CLEARPBA_MASK |
IAVFINT_DYN_CTLN1_ITR_INDX_MASK);
}
--
2.7.5
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE
2019-04-18 4:58 [dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE Wei Zhao
2019-04-18 4:58 ` Wei Zhao
@ 2019-04-18 8:10 ` Zhang, Qi Z
2019-04-18 8:10 ` Zhang, Qi Z
2019-05-08 10:37 ` [dpdk-dev] [dpdk-stable] " Kevin Traynor
2 siblings, 1 reply; 6+ messages in thread
From: Zhang, Qi Z @ 2019-04-18 8:10 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Thursday, April 18, 2019 12:58 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/iavf: fix queue interrupt for ICE
>
> Enable CLEARPBA bit is required by ice NIC of A0/A1 version to enable Tx and Rx
> queue interrupt.
> Also enable CLEARPBA bit does no impact on IAVF behaviour when be hosted by
> other devices, so we can make it as default.
>
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE
2019-04-18 8:10 ` Zhang, Qi Z
@ 2019-04-18 8:10 ` Zhang, Qi Z
0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Qi Z @ 2019-04-18 8:10 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Thursday, April 18, 2019 12:58 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/iavf: fix queue interrupt for ICE
>
> Enable CLEARPBA bit is required by ice NIC of A0/A1 version to enable Tx and Rx
> queue interrupt.
> Also enable CLEARPBA bit does no impact on IAVF behaviour when be hosted by
> other devices, so we can make it as default.
>
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/iavf: fix queue interrupt for ICE
2019-04-18 4:58 [dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE Wei Zhao
2019-04-18 4:58 ` Wei Zhao
2019-04-18 8:10 ` Zhang, Qi Z
@ 2019-05-08 10:37 ` Kevin Traynor
2019-05-08 10:37 ` Kevin Traynor
2 siblings, 1 reply; 6+ messages in thread
From: Kevin Traynor @ 2019-05-08 10:37 UTC (permalink / raw)
To: Wei Zhao, dev; +Cc: stable, qi.z.zhang
On 18/04/2019 05:58, Wei Zhao wrote:
> Enable CLEARPBA bit is required by ice NIC of A0/A1 version to
> enable Tx and Rx queue interrupt.
> Also enable CLEARPBA bit does no impact on IAVF behaviour when be
> hosted by other devices, so we can make it as default.
>
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
The Fixes commit is in 18.11 stable but ice is not. If this is just for
ice as commit msg suggests, then it is not needed for 18.11 stable
branch. Please let me know if it's needed for some other reason on 18.11
branch.
thanks,
Kevin.
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/iavf/iavf_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 846e604..57819dd 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -1015,11 +1015,13 @@ iavf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
> PMD_DRV_LOG(INFO, "MISC is also enabled for control");
> IAVF_WRITE_REG(hw, IAVFINT_DYN_CTL01,
> IAVFINT_DYN_CTL01_INTENA_MASK |
> + IAVFINT_DYN_CTL01_CLEARPBA_MASK |
> IAVFINT_DYN_CTL01_ITR_INDX_MASK);
> } else {
> IAVF_WRITE_REG(hw,
> IAVFINT_DYN_CTLN1(msix_intr - IAVF_RX_VEC_START),
> IAVFINT_DYN_CTLN1_INTENA_MASK |
> + IAVFINT_DYN_CTL01_CLEARPBA_MASK |
> IAVFINT_DYN_CTLN1_ITR_INDX_MASK);
> }
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/iavf: fix queue interrupt for ICE
2019-05-08 10:37 ` [dpdk-dev] [dpdk-stable] " Kevin Traynor
@ 2019-05-08 10:37 ` Kevin Traynor
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Traynor @ 2019-05-08 10:37 UTC (permalink / raw)
To: Wei Zhao, dev; +Cc: stable, qi.z.zhang
On 18/04/2019 05:58, Wei Zhao wrote:
> Enable CLEARPBA bit is required by ice NIC of A0/A1 version to
> enable Tx and Rx queue interrupt.
> Also enable CLEARPBA bit does no impact on IAVF behaviour when be
> hosted by other devices, so we can make it as default.
>
> Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt")
The Fixes commit is in 18.11 stable but ice is not. If this is just for
ice as commit msg suggests, then it is not needed for 18.11 stable
branch. Please let me know if it's needed for some other reason on 18.11
branch.
thanks,
Kevin.
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/iavf/iavf_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 846e604..57819dd 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -1015,11 +1015,13 @@ iavf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, uint16_t queue_id)
> PMD_DRV_LOG(INFO, "MISC is also enabled for control");
> IAVF_WRITE_REG(hw, IAVFINT_DYN_CTL01,
> IAVFINT_DYN_CTL01_INTENA_MASK |
> + IAVFINT_DYN_CTL01_CLEARPBA_MASK |
> IAVFINT_DYN_CTL01_ITR_INDX_MASK);
> } else {
> IAVF_WRITE_REG(hw,
> IAVFINT_DYN_CTLN1(msix_intr - IAVF_RX_VEC_START),
> IAVFINT_DYN_CTLN1_INTENA_MASK |
> + IAVFINT_DYN_CTL01_CLEARPBA_MASK |
> IAVFINT_DYN_CTLN1_ITR_INDX_MASK);
> }
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-08 10:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-18 4:58 [dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE Wei Zhao
2019-04-18 4:58 ` Wei Zhao
2019-04-18 8:10 ` Zhang, Qi Z
2019-04-18 8:10 ` Zhang, Qi Z
2019-05-08 10:37 ` [dpdk-dev] [dpdk-stable] " Kevin Traynor
2019-05-08 10:37 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).