From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 90A0DA00E6 for ; Thu, 18 Apr 2019 07:07:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07F171B8F8; Thu, 18 Apr 2019 07:07:03 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58]) by dpdk.org (Postfix) with ESMTP id 3D4981B8F8 for ; Thu, 18 Apr 2019 07:07:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CWt/CVvIN2DfAdPAEBycyi99gyC7DYSScE4+col3Jyw=; b=p169Lr+Q7jXdOQErIAuoHE2muxcWZEK8UPluSLW5DhzS0EJaKTE1Q1SqKA33gPXEgHERDEx1TamMuW9pgxZoxlz5uhdWMKyj/RYgTm8njj4rB3tAv386dEUYdJQk8/nMrPvAcxI/see+Yl6KWuH0ziWOMDRVQwODYDJ+OftAd3Y= Received: from AM4PR05MB3425.eurprd05.prod.outlook.com (10.171.190.15) by AM4PR05MB3298.eurprd05.prod.outlook.com (10.171.187.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Thu, 18 Apr 2019 05:06:59 +0000 Received: from AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8]) by AM4PR05MB3425.eurprd05.prod.outlook.com ([fe80::a4d7:6c70:9829:2cc8%6]) with mapi id 15.20.1813.013; Thu, 18 Apr 2019 05:06:59 +0000 From: Ori Kam To: Yongseok Koh CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH 7/9] net/mlx5: add port ID action to Direct Verbs Thread-Index: AQHU9YIClNW9AEd51kq9JCCqRh1KCKZBW9Pw Date: Thu, 18 Apr 2019 05:06:59 +0000 Message-ID: References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-8-git-send-email-orika@mellanox.com> <20190418005931.GD31179@mtidpdk.mti.labs.mlnx> In-Reply-To: <20190418005931.GD31179@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [185.175.35.255] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d676d808-8741-41d8-41ff-08d6c3bbafba x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3298; x-ms-traffictypediagnostic: AM4PR05MB3298: x-microsoft-antispam-prvs: x-forefront-prvs: 0011612A55 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(366004)(396003)(39860400002)(13464003)(189003)(199004)(97736004)(256004)(478600001)(316002)(52536014)(14454004)(99286004)(30864003)(25786009)(71190400001)(71200400001)(54906003)(6636002)(5660300002)(6436002)(305945005)(7696005)(6246003)(229853002)(86362001)(76176011)(33656002)(7736002)(4326008)(6506007)(486006)(446003)(53546011)(55016002)(102836004)(68736007)(6862004)(8936002)(53936002)(6116002)(476003)(8676002)(2906002)(186003)(26005)(3846002)(81166006)(81156014)(9686003)(66066001)(11346002)(74316002)(7756004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3298; H:AM4PR05MB3425.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: f5JWQqQ+bBM+3nI+8Yuppk0WDRJMuFuJflqkW1LlS84SrTmdpC6kghqEXjiSC4oIBoFhyhggPWIqnAxCmoODwQGQjKt0R7sr+SUajeQBWnZEuy6JfATRTnbZYi5vdb0cBmVfyAnhcVGwrayFQgovaLtUryQKiwSsHzEm+AWLEgTga/VM12Cd4Hc/vZEfxLk4Ul6Ycv/nFyL2nSzyYl/Ws8ZwB0gpg2c3CfcI9BchKDf90V0wEGi55z/eCi+Rq0fSjSHJ2wJ3CMffwyuePFhrAtqXHla/kaat05WabWQOOizwwkB4s5L8Oy7metJUKwozozLp3BrfwVAUHadLSIQcm77Xw0IARPY6rghh5O/9ODcclczyZpCZtNFtp4f7CoHD52r/eZ4+FSO0oSdDFdJXDhZOszPJi5Wa/pagA0p2hj0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d676d808-8741-41d8-41ff-08d6c3bbafba X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 05:06:59.2652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3298 Subject: Re: [dpdk-dev] [PATCH 7/9] net/mlx5: add port ID action to Direct Verbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418050659.Tx-ib1yncYu6-2IG1fMqW9lbV1I7Q6ONjgdgjJ9p-jk@z> Hi Yongseok, PSB > -----Original Message----- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 4:00 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 7/9] net/mlx5: add port ID action to Direct Verbs >=20 > On Sun, Apr 14, 2019 at 09:12:35PM +0000, Ori Kam wrote: > > This commits adds the port ID action to DV steering. >=20 > Poor title and commit message. > Don't you add translation of the action? > Yes I add translation function but this is internal. the meaning of adding = translation is adding the command. I thought that we shouldn't use PMD wording. =20 How about this: net/mlx5: add E-Switch port_id action to Direct Verbs Problem it is too long. Regarding the message, what about: This commit adds the E-Switch port_id action to DV which enables E-Switch r= outing to a destination port > Thanks, > Yongseok >=20 > > Signed-off-by: Ori Kam > > --- > > drivers/net/mlx5/mlx5.h | 2 + > > drivers/net/mlx5/mlx5_flow.h | 12 ++++ > > drivers/net/mlx5/mlx5_flow_dv.c | 149 > ++++++++++++++++++++++++++++++++++++++++ > > drivers/net/mlx5/mlx5_glue.c | 14 ++++ > > drivers/net/mlx5/mlx5_glue.h | 1 + > > 5 files changed, 178 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > > index 8d63575..016984d 100644 > > --- a/drivers/net/mlx5/mlx5.h > > +++ b/drivers/net/mlx5/mlx5.h > > @@ -281,6 +281,8 @@ struct mlx5_ibv_shared { > > LIST_HEAD(modify_cmd, mlx5_flow_dv_modify_hdr_resource) > modify_cmds; > > LIST_HEAD(tag, mlx5_flow_dv_tag_resource) tags; > > LIST_HEAD(jump, mlx5_flow_dv_jump_tbl_resource) jump_tbl; > > + LIST_HEAD(port_id_action_list, > mlx5_flow_dv_port_id_action_resource) > > + port_id_action_list; /* List of port ID actions. */ > > /* Shared interrupt handler section. */ > > pthread_mutex_t intr_mutex; /* Interrupt config mutex. */ > > uint32_t intr_cnt; /* Interrupt handler reference counter. */ > > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.= h > > index 9d72024..c419e6b 100644 > > --- a/drivers/net/mlx5/mlx5_flow.h > > +++ b/drivers/net/mlx5/mlx5_flow.h > > @@ -267,6 +267,16 @@ struct mlx5_flow_dv_jump_tbl_resource { > > struct mlx5_flow_tbl_resource *tbl; /**< The target table. */ > > }; > > > > +/* Port ID resource structure. */ > > +struct mlx5_flow_dv_port_id_action_resource { > > + LIST_ENTRY(mlx5_flow_dv_port_id_action_resource) next; > > + /* Pointer to next element. */ > > + rte_atomic32_t refcnt; /**< Reference counter. */ > > + void *action; > > + /**< Verbs tag action object. */ > > + uint32_t port_id; /**< Port ID value. */ > > +}; > > + > > /* > > * Max number of actions per DV flow. > > * See CREATE_FLOW_MAX_FLOW_ACTIONS_SUPPORTED > > @@ -289,6 +299,8 @@ struct mlx5_flow_dv { > > struct ibv_flow *flow; /**< Installed flow. */ > > struct mlx5_flow_dv_jump_tbl_resource *jump; > > /**< Pointer to the jump action resource. */ > > + struct mlx5_flow_dv_port_id_action_resource *port_id_action; > > + /**< Pointer to port ID action resource. */ > > #ifdef HAVE_IBV_FLOW_DV_SUPPORT > > void *actions[MLX5_DV_MAX_NUMBER_OF_ACTIONS]; > > /**< Action list. */ > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > > index b4ca9ca..f4b7f06 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -1058,6 +1058,70 @@ struct field_modify_info modify_tcp[] =3D { > > } > > > > /** > > + * Find existing table port ID resource or create and register a new o= ne. > > + * > > + * @param dev[in, out] > > + * Pointer to rte_eth_dev structure. > > + * @param[in, out] resource > > + * Pointer to port ID action resource. > > + * @parm[in, out] dev_flow > > + * Pointer to the dev_flow. > > + * @param[out] error > > + * pointer to error structure. > > + * > > + * @return > > + * 0 on success otherwise -errno and errno is set. > > + */ > > +static int > > +flow_dv_port_id_action_resource_register > > + (struct rte_eth_dev *dev, > > + struct mlx5_flow_dv_port_id_action_resource > *resource, > > + struct mlx5_flow *dev_flow, > > + struct rte_flow_error *error) > > +{ > > + struct mlx5_priv *priv =3D dev->data->dev_private; > > + struct mlx5_ibv_shared *sh =3D priv->sh; > > + struct mlx5_flow_dv_port_id_action_resource *cache_resource; > > + > > + /* Lookup a matching resource from cache. */ > > + LIST_FOREACH(cache_resource, &sh->port_id_action_list, next) { > > + if (resource->port_id =3D=3D cache_resource->port_id) { > > + DRV_LOG(DEBUG, "port id action resource resource > %p: " > > + "refcnt %d++", > > + (void *)cache_resource, > > + rte_atomic32_read(&cache_resource- > >refcnt)); > > + rte_atomic32_inc(&cache_resource->refcnt); > > + dev_flow->dv.port_id_action =3D cache_resource; > > + return 0; > > + } > > + } > > + /* Register new port id action resource. */ > > + cache_resource =3D rte_calloc(__func__, 1, sizeof(*cache_resource), 0= ); > > + if (!cache_resource) > > + return rte_flow_error_set(error, ENOMEM, > > + > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > > + "cannot allocate resource memory"); > > + *cache_resource =3D *resource; > > + cache_resource->action =3D > > + mlx5_glue->dr_create_flow_action_dest_vport(priv->sh- > >fdb_ns, > > + resource->port_id); > > + if (!cache_resource->action) { > > + rte_free(cache_resource); > > + return rte_flow_error_set(error, ENOMEM, > > + > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > > + NULL, "cannot create action"); > > + } > > + rte_atomic32_init(&cache_resource->refcnt); > > + rte_atomic32_inc(&cache_resource->refcnt); > > + LIST_INSERT_HEAD(&sh->port_id_action_list, cache_resource, next); > > + dev_flow->dv.port_id_action =3D cache_resource; > > + DRV_LOG(DEBUG, "new port id action resource %p: refcnt %d++", > > + (void *)cache_resource, > > + rte_atomic32_read(&cache_resource->refcnt)); > > + return 0; > > +} > > + > > +/** > > * Get the size of specific rte_flow_item_type > > * > > * @param[in] item_type > > @@ -3467,6 +3531,44 @@ struct field_modify_info modify_tcp[] =3D { > > } > > > > /** > > + * Translate port ID action to vport. > > + * > > + * @param[in] dev > > + * Pointer to rte_eth_dev structure. > > + * @param[in] action > > + * Pointer to the port ID action. > > + * @param[out] dst_port_id > > + * The target port ID. > > + * @param[out] error > > + * Pointer to the error structure. > > + * > > + * @return > > + * 0 on success, a negative errno value otherwise and rte_errno is s= et. > > + */ > > +static int > > +flow_dv_translate_action_port_id(struct rte_eth_dev *dev, > > + const struct rte_flow_action *action, > > + uint32_t *dst_port_id, > > + struct rte_flow_error *error) > > +{ > > + uint32_t port; > > + uint16_t port_id; > > + int ret; > > + const struct rte_flow_action_port_id *conf =3D > > + (const struct rte_flow_action_port_id *)action->conf; > > + > > + port =3D conf->original ? dev->data->port_id : conf->id; > > + ret =3D mlx5_port_to_eswitch_info(port, NULL, &port_id); > > + if (ret) > > + return rte_flow_error_set(error, -ret, > > + RTE_FLOW_ERROR_TYPE_ACTION, > > + NULL, > > + "No eswitch info was found for port"); > > + *dst_port_id =3D port_id; > > + return 0; > > +} > > + > > +/** > > * Fill the flow with DV spec. > > * > > * @param[in] dev > > @@ -3524,10 +3626,24 @@ struct field_modify_info modify_tcp[] =3D { > > const struct rte_flow_action_jump *jump_data; > > struct mlx5_flow_dv_jump_tbl_resource jump_tbl_resource; > > struct mlx5_flow_tbl_resource *tbl; > > + uint32_t port_id =3D 0; > > + struct mlx5_flow_dv_port_id_action_resource > port_id_resource; > > > > switch (actions->type) { > > case RTE_FLOW_ACTION_TYPE_VOID: > > break; > > + case RTE_FLOW_ACTION_TYPE_PORT_ID: > > + if (flow_dv_translate_action_port_id(dev, action, > > + &port_id, error)) > > + return -rte_errno; > > + port_id_resource.port_id =3D port_id; > > + if (flow_dv_port_id_action_resource_register > > + (dev, &port_id_resource, dev_flow, error)) > > + return -rte_errno; > > + dev_flow->dv.actions[actions_n++] =3D > > + dev_flow->dv.port_id_action->action; > > + action_flags |=3D MLX5_FLOW_ACTION_PORT_ID; > > + break; > > case RTE_FLOW_ACTION_TYPE_FLAG: > > tag_resource.tag =3D > > > mlx5_flow_mark_set(MLX5_FLOW_MARK_DEFAULT); > > @@ -4131,6 +4247,37 @@ struct field_modify_info modify_tcp[] =3D { > > } > > > > /** > > + * Release port ID action resource. > > + * > > + * @param flow > > + * Pointer to mlx5_flow. > > + * > > + * @return > > + * 1 while a reference on it exists, 0 when freed. > > + */ > > +static int > > +flow_dv_port_id_action_resource_release(struct mlx5_flow *flow) > > +{ > > + struct mlx5_flow_dv_port_id_action_resource *cache_resource =3D > > + flow->dv.port_id_action; > > + > > + assert(cache_resource->action); > > + DRV_LOG(DEBUG, "port ID action resource %p: refcnt %d--", > > + (void *)cache_resource, > > + rte_atomic32_read(&cache_resource->refcnt)); > > + if (rte_atomic32_dec_and_test(&cache_resource->refcnt)) { > > + claim_zero(mlx5_glue->destroy_flow_action > > + (cache_resource->action)); > > + LIST_REMOVE(cache_resource, next); > > + rte_free(cache_resource); > > + DRV_LOG(DEBUG, "port id action resource %p: removed", > > + (void *)cache_resource); > > + return 0; > > + } > > + return 1; > > +} > > + > > +/** > > * Remove the flow from the NIC but keeps it in memory. > > * > > * @param[in] dev > > @@ -4197,6 +4344,8 @@ struct field_modify_info modify_tcp[] =3D { > > flow_dv_modify_hdr_resource_release(dev_flow); > > if (dev_flow->dv.jump) > > flow_dv_jump_tbl_resource_release(dev_flow); > > + if (dev_flow->dv.port_id_action) > > + flow_dv_port_id_action_resource_release(dev_flow); > > rte_free(dev_flow); > > } > > } > > diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.= c > > index a508faa..117190f 100644 > > --- a/drivers/net/mlx5/mlx5_glue.c > > +++ b/drivers/net/mlx5/mlx5_glue.c > > @@ -382,6 +382,18 @@ > > } > > > > static void * > > +mlx5_glue_dr_create_flow_action_dest_vport(void *ns, uint32_t vport) > > +{ > > +#ifdef HAVE_MLX5DV_DR_ESWITCH > > + return mlx5dv_dr_create_action_dest_vport(ns, vport); > > +#else > > + (void)ns; > > + (void)vport; > > + return NULL; > > +#endif > > +} > > + > > +static void * > > mlx5_glue_dr_create_flow_tbl(void *ns, uint32_t level) > > { > > #ifdef HAVE_MLX5DV_DR > > @@ -847,6 +859,8 @@ > > .cq_ex_to_cq =3D mlx5_glue_cq_ex_to_cq, > > .dr_create_flow_action_dest_flow_tbl =3D > > mlx5_glue_dr_create_flow_action_dest_flow_tbl, > > + .dr_create_flow_action_dest_vport =3D > > + mlx5_glue_dr_create_flow_action_dest_vport, > > .dr_create_flow_tbl =3D mlx5_glue_dr_create_flow_tbl, > > .dr_destroy_flow_tbl =3D mlx5_glue_dr_destroy_flow_tbl, > > .dr_create_ns =3D mlx5_glue_dr_create_ns, > > diff --git a/drivers/net/mlx5/mlx5_glue.h b/drivers/net/mlx5/mlx5_glue.= h > > index 058e9b1..26f5cb3 100644 > > --- a/drivers/net/mlx5/mlx5_glue.h > > +++ b/drivers/net/mlx5/mlx5_glue.h > > @@ -146,6 +146,7 @@ struct mlx5_glue { > > const char *(*port_state_str)(enum ibv_port_state port_state); > > struct ibv_cq *(*cq_ex_to_cq)(struct ibv_cq_ex *cq); > > void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); > > + void *(*dr_create_flow_action_dest_vport)(void *ns, uint32_t vport); > > void *(*dr_create_flow_tbl)(void *ns, uint32_t level); > > int (*dr_destroy_flow_tbl)(void *tbl); > > void *(*dr_create_ns)(struct ibv_context *ctx, > > -- > > 1.8.3.1 > >