From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1E38BA00E6 for ; Thu, 18 Apr 2019 12:11:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E343C1B92D; Thu, 18 Apr 2019 12:11:23 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 838241B8CB; Thu, 18 Apr 2019 12:11:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2019 03:11:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,365,1549958400"; d="scan'208";a="224586435" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga001.jf.intel.com with ESMTP; 18 Apr 2019 03:11:19 -0700 Received: from irsmsx110.ger.corp.intel.com ([169.254.15.173]) by IRSMSX108.ger.corp.intel.com ([169.254.11.82]) with mapi id 14.03.0415.000; Thu, 18 Apr 2019 11:11:18 +0100 From: "Pattan, Reshma" To: "Lipiec, Herakliusz" CC: "dev@dpdk.org" , "jianfeng.tan@intel.com" , "stable@dpdk.org" Thread-Topic: [PATCH 5/8] ipc: fix pdump memleak Thread-Index: AQHU9SupDF/g1KVUvEeSpsoKWNHKMaZBsyLw Date: Thu, 18 Apr 2019 10:11:18 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A44932F@irsmsx110.ger.corp.intel.com> References: <20190417144158.23016-1-herakliusz.lipiec@intel.com> In-Reply-To: <20190417144158.23016-1-herakliusz.lipiec@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTQ1YmIxODItYzZmNS00ODhkLWEzZGQtZTE2YjczOTM0YjJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ2F6VXpFV3ppRHNObnFqWVwvN3lzUFRjU2ZGc3B4dGkxZDk4UUtmYTlZRG1UQlBBeHNJQXR0TEw5OXd5aTVGUngifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/8] ipc: fix pdump memleak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418101118.RByI-WqnhNVRBiv1VcYcjJgr7tfPAhptOqaXttIctKU@z> > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Wednesday, April 17, 2019 3:42 PM > To: Pattan, Reshma > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng.tan@intel.com; stable@dpdk.org > Subject: [PATCH 5/8] ipc: fix pdump memleak >=20 > When sending multiple requests, rte_mp_request_sync can succeed sending a > few of those requests, but then fail on a later one and in the end return= with rc=3D- > 1. > The upper layers - e.g. device hotplug - currently handles this case as i= f no > messages were sent and no memory for response buffers was allocated, whic= h > is not true. Fixed by always freeing reply message buffers. >=20 > Fixes: 660098d61f57 ("pdump: use generic multi-process channel") > Cc: jianfeng.tan@intel.com > Cc: stable@dpdk.org > Signed-off-by: Herakliusz Lipiec Might need to add Bugzilla id in commit message. Other than that, Acked-By: Reshma Pattan