From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A02EDA00E6 for ; Thu, 18 Apr 2019 12:59:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B6E71B94B; Thu, 18 Apr 2019 12:59:46 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 94E581B944 for ; Thu, 18 Apr 2019 12:59:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id A29ABE2A1; Thu, 18 Apr 2019 06:59:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 18 Apr 2019 06:59:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=mesmtp; bh=TGwUJHchhX Va27gmfl+BwWPJaTZsryNrycrSk5SMkyE=; b=GyMDRf1Z+dE5WE2Zc9TCYs21KZ SXbbgmfw7PyfTpqXZwN9cz8Vs+BkqsyjpPVq3wwxkV8A3oPGv8jYyQl4e1//wi72 jUgA3doobAgiK6H7rCeZdZxTth7Fr3rPxD0yaFpFcLv74Zi2C7dqRJREUiG3TXSd 00jJ/4LJYIcAxknp0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TGwUJH chhXVa27gmfl+BwWPJaTZsryNrycrSk5SMkyE=; b=gD+hs+C+WEY/u5fV+s9Sm8 XGU/IZ0EZO/suVYPNO0BLL1u0P6CEEFeCmeBUvzTphaFX/4fFQHYlqP9qJKCJKnq dhALx9LwZJiTS9Y6+P0RL5vzVsC4ms3FTCEXqJCPg21xRWuixqLzuZX+5Jd47jeJ zs/+0ScM4nJRWe1rbVESnRP8oxAFblMurPF6C39e4V3QHPZJQelpHAGtjCFkAz69 m2RAquASz5ittKEyTWmeovIQa28qnAmQ1+FuIWMT09rSOJXTCkQK6XYjAUJ4h+hL dJ14AcDaiK3w/jkWyjwXetKWbGmEBBqOM3fS2y74MjjLFDi5KMkA5v/fdYbdX3+w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeehgddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffohhmrg hinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6375D103C9; Thu, 18 Apr 2019 06:59:34 -0400 (EDT) From: Thomas Monjalon To: "John W. Linville" , Xiaolong Ye , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Gagandeep Singh , Pankaj Chauhan , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Ferruh Yigit , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Yongseok Koh , Zyta Szpak , Liron Himi , Alan Winkowski , Tomasz Duszynski , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Rastislav Cernay , Jan Remes , Alejandro Lucero , Tetsuya Mukawa , Jerin Jacob , Bruce Richardson , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Anatoly Burakov Cc: dev@dpdk.org Date: Thu, 18 Apr 2019 12:59:33 +0200 Message-ID: <30528485.5cHeq7CNxZ@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418105933.8xhjfA3ayaWzNBYrZm88P6M83hYxR_PrV8xO5DT7cU4@z> Hi all, Since DPDK 18.11, the behaviour of the close operation is changed if RTE_ETH_DEV_CLOSE_REMOVE is enabled in the driver: port is released (i.e. totally freed and data erased) on close. This new behaviour is enabled per driver for a migration period. Looking at the code, you can see these comments: /* old behaviour: only free queue arrays */ RTE_ETHDEV_LOG(DEBUG, "Port closing is using an old behaviour.\n" "The driver %s should migrate to the new behaviour.\n", /* new behaviour: send event + reset state + free all data */ You can find an advice in the commit: http://git.dpdk.org/dpdk/commit/?id=23ea57a2a " When enabling RTE_ETH_DEV_CLOSE_REMOVE, the PMD must free all its private resources for the port, in its dev_close function. It is advised to call the dev_close function in the remove function in order to support removing a device without closing its ports. " It would be great to complete this migration for the next LTS version, which will be 19.11. It means the work should be ideally finished during the summer. The migration to the new behaviour is done in 4 drivers: git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 ena enic mlx5 vmxnet3 Following drivers should be migrated: ( find drivers/net -mindepth 1 -maxdepth 1 -type d | cut -d/ -f3 ; git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 ) | sort | uniq -u af_packet af_xdp ark atlantic avp axgbe bnx2x bnxt bonding cxgbe dpaa dpaa2 e1000 enetc failsafe fm10k i40e iavf ice ifc ixgbe kni liquidio mlx4 mvneta mvpp2 netvsc nfb nfp null octeontx pcap qede ring sfc softnic szedata2 tap thunderx vdev_netvsc vhost virtio Please let's progress smoothly on this topic, thanks. The concerned maintainers (Cc) can be found with the following command: devtools/get-maintainer.sh $(( find drivers/net -mindepth 1 -maxdepth 1 -type d | cut -d/ -f-3 ; git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers ) | sort | uniq -u)