From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 662D0A00E6 for ; Thu, 18 Apr 2019 15:23:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D740B1B9E2; Thu, 18 Apr 2019 15:23:16 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60063.outbound.protection.outlook.com [40.107.6.63]) by dpdk.org (Postfix) with ESMTP id 31DED1B9CC for ; Thu, 18 Apr 2019 15:23:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=chiZEHdEdX3dWLbRLEytUR0klrRL7mH8plT1xUcMj1g=; b=Uoe9SJl5Ex3elUotKXyOdZwjLWnfGGNCjHH9evicuylvbjHVRu5BKf70LFWd+s/7iSyl84ER48SL/CFuaOXxxigsXiustHux2UfDdaga3jobsTH3qM3SbZG7/M9VltG1zkr7gw1cL3SAcbODcNMAUU8x4UbCMHEZTFROubl+FQs= Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com (52.133.40.151) by AM0PR0502MB3796.eurprd05.prod.outlook.com (52.133.47.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.11; Thu, 18 Apr 2019 13:23:13 +0000 Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::7da6:9e13:922a:9d88]) by AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::7da6:9e13:922a:9d88%5]) with mapi id 15.20.1813.013; Thu, 18 Apr 2019 13:23:13 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch Thread-Index: AQHU9ekac2GY8i7eiEuI3BqwZuUgVKZB5+wA Date: Thu, 18 Apr 2019 13:23:13 +0000 Message-ID: References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555593367-144772-1-git-send-email-orika@mellanox.com> <1555593367-144772-10-git-send-email-orika@mellanox.com> In-Reply-To: <1555593367-144772-10-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 75d03f67-c301-4344-6bbb-08d6c40102b6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3796; x-ms-traffictypediagnostic: AM0PR0502MB3796: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 0011612A55 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39860400002)(366004)(136003)(189003)(199004)(81166006)(26005)(6506007)(53546011)(102836004)(6306002)(6512007)(5660300002)(6862004)(966005)(71190400001)(6246003)(71200400001)(83716004)(186003)(82746002)(256004)(53936002)(4326008)(25786009)(14454004)(8676002)(478600001)(8936002)(81156014)(86362001)(7736002)(305945005)(33656002)(6636002)(66066001)(446003)(486006)(3846002)(6116002)(2906002)(36756003)(2616005)(11346002)(476003)(68736007)(99286004)(6486002)(37006003)(54906003)(97736004)(6436002)(229853002)(76176011)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3796; H:AM0PR0502MB3971.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: k4U/zT5ocxYlXzbSKnmEioO3mXUxCHUl4WNt4ozlc+pTsbdT0Frtb64fOf0C6+SoEu0QXkyBdV3b6/KOrzcLBOEWrYSdbNWvQZ9eFUXMA+reLncH9HqX4GzzBU7WtNTFmgZJtebtKkW4iw3busGQa6EMyS2RTQ1UEvNPvMsdezfHhItgQtiMfZ7I5pve9ddGJ3Nvpd/0uPBYdFMcMDmBeTA0NYxuN6SggGQ2f9D/v8br8diuoDW3VE2+0ahuRZ42ygtkC4Eg3TR6jgjtL5WDgf+9P5BvdcgUdDtF44QbX2+VezHlWSSKPEjQcDcfVQzObnV9XlXoyJf7SYCIo+mLnyPi4H5Z3SrLHyDWibWpnqpOh4/CtZ8n29/1eI3bqZiT8FvEhbWUfC6TXTVbfNO7+F6gy8CbzFsbEggUR6Y9h54= Content-Type: text/plain; charset="UTF-8" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75d03f67-c301-4344-6bbb-08d6c40102b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 13:23:13.8024 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3796 Subject: Re: [dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418132313.-22fgQlXF6JW3e19HUA-dqt8qMWIgMcPGm20nuSjGms@z> > On Apr 18, 2019, at 6:16 AM, Ori Kam wrote: >=20 > This commit adds support for drop action when creating E-Switch flow > using DV. >=20 > Signed-off-by: Ori Kam > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5.c | 9 +++++++++ > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_flow_dv.c | 22 ++++++++++++++-------- > drivers/net/mlx5/mlx5_glue.c | 12 ++++++++++++ > drivers/net/mlx5/mlx5_glue.h | 1 + > 5 files changed, 37 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index ff24e1d..65c69af 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -357,6 +357,7 @@ struct mlx5_dev_spawn_data { > goto error; > } > sh->fdb_ns =3D ns; > + sh->esw_drop_action =3D mlx5_glue->dr_create_flow_action_drop(); > } > #endif > sh->dv_refcnt++; > @@ -377,6 +378,10 @@ struct mlx5_dev_spawn_data { > mlx5_glue->dr_destroy_ns(sh->fdb_ns); > sh->fdb_ns =3D NULL; > } > + if (sh->esw_drop_action) { > + mlx5_glue->destroy_flow_action(sh->esw_drop_action); > + sh->esw_drop_action =3D NULL; > + } > return err; > #else > (void)priv; > @@ -417,6 +422,10 @@ struct mlx5_dev_spawn_data { > mlx5_glue->dr_destroy_ns(sh->fdb_ns); > sh->fdb_ns =3D NULL; > } > + if (sh->esw_drop_action) { > + mlx5_glue->destroy_flow_action(sh->esw_drop_action); > + sh->esw_drop_action =3D NULL; > + } > #endif > pthread_mutex_destroy(&sh->dv_mutex); > #else > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index 907d5c3..443625e 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -276,6 +276,7 @@ struct mlx5_ibv_shared { > /* RX Direct Rules tables. */ > void *tx_ns; /* TX Direct Rules name space handle. */ > struct mlx5_flow_tbl_resource tx_tbl[MLX5_MAX_TABLES]; > + void *esw_drop_action; /* Pointer to DR E-Switch drop action. */ > /* TX Direct Rules tables/ */ > LIST_HEAD(matchers, mlx5_flow_dv_matcher) matchers; > LIST_HEAD(encap_decap, mlx5_flow_dv_encap_decap_resource) encaps_decaps; > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow= _dv.c > index 5997182..4352d48 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -4049,6 +4049,7 @@ struct field_modify_info modify_tcp[] =3D { > { > struct mlx5_flow_dv *dv; > struct mlx5_flow *dev_flow; > + struct mlx5_priv *priv =3D dev->data->dev_private; > int n; > int err; >=20 > @@ -4056,15 +4057,20 @@ struct field_modify_info modify_tcp[] =3D { > dv =3D &dev_flow->dv; > n =3D dv->actions_n; > if (flow->actions & MLX5_FLOW_ACTION_DROP) { > - dv->hrxq =3D mlx5_hrxq_drop_new(dev); > - if (!dv->hrxq) { > - rte_flow_error_set > - (error, errno, > - RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > - "cannot get drop hash queue"); > - goto error; > + if (flow->transfer) > + dv->actions[n++] =3D priv->sh->esw_drop_action; > + else { Please fix the coding style issue. http://mails.dpdk.org/archives/test-report/2019-April/080992.html > + dv->hrxq =3D mlx5_hrxq_drop_new(dev); > + if (!dv->hrxq) { > + rte_flow_error_set > + (error, errno, > + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > + NULL, > + "cannot get drop hash queue"); > + goto error; > + } > + dv->actions[n++] =3D dv->hrxq->action; > } > - dv->actions[n++] =3D dv->hrxq->action; > } else if (flow->actions & > (MLX5_FLOW_ACTION_QUEUE | MLX5_FLOW_ACTION_RSS)) { > struct mlx5_hrxq *hrxq; > diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c > index 117190f..b32cd09c 100644 > --- a/drivers/net/mlx5/mlx5_glue.c > +++ b/drivers/net/mlx5/mlx5_glue.c > @@ -394,6 +394,16 @@ > } >=20 > static void * > +mlx5_glue_dr_create_flow_action_drop(void) > +{ > +#ifdef HAVE_MLX5DV_DR_ESWITCH > + return mlx5dv_dr_create_action_drop(); > +#else > + return NULL; > +#endif > +} > + > +static void * > mlx5_glue_dr_create_flow_tbl(void *ns, uint32_t level) > { > #ifdef HAVE_MLX5DV_DR > @@ -861,6 +871,8 @@ > mlx5_glue_dr_create_flow_action_dest_flow_tbl, > .dr_create_flow_action_dest_vport =3D > mlx5_glue_dr_create_flow_action_dest_vport, > + .dr_create_flow_action_drop =3D > + mlx5_glue_dr_create_flow_action_drop, > .dr_create_flow_tbl =3D mlx5_glue_dr_create_flow_tbl, > .dr_destroy_flow_tbl =3D mlx5_glue_dr_destroy_flow_tbl, > .dr_create_ns =3D mlx5_glue_dr_create_ns, > diff --git a/drivers/net/mlx5/mlx5_glue.h b/drivers/net/mlx5/mlx5_glue.h > index 26f5cb3..1d06583 100644 > --- a/drivers/net/mlx5/mlx5_glue.h > +++ b/drivers/net/mlx5/mlx5_glue.h > @@ -147,6 +147,7 @@ struct mlx5_glue { > struct ibv_cq *(*cq_ex_to_cq)(struct ibv_cq_ex *cq); > void *(*dr_create_flow_action_dest_flow_tbl)(void *tbl); > void *(*dr_create_flow_action_dest_vport)(void *ns, uint32_t vport); > + void *(*dr_create_flow_action_drop)(); > void *(*dr_create_flow_tbl)(void *ns, uint32_t level); > int (*dr_destroy_flow_tbl)(void *tbl); > void *(*dr_create_ns)(struct ibv_context *ctx, > --=20 > 1.8.3.1 >=20