From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9F263A00E6 for ; Thu, 18 Apr 2019 16:50:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE1481BB74; Thu, 18 Apr 2019 16:50:54 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 06D061BAA7 for ; Thu, 18 Apr 2019 16:50:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 75C7C2639F; Thu, 18 Apr 2019 10:50:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 18 Apr 2019 10:50:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=WHhFsDOswN3ZsJW4DGOqtc4reZpryKgunH2mvxyOB8s=; b=mO9dF3EI3TuW VT6A6E4Dn7aUYIesKN44hdVU3gxQk+WaXGnX7KawUk1hJ9ApvPSrg8E90bv96Mes 1O8ZO6cG10LAh6C6B9s/TEPve8IG9qaVhBdTW5P3ze4FL35y/Tl/0Jx8pyb8sjL6 fQ3DoS9hHsOVcJgCdzCHEfdjDF/XQNw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=WHhFsDOswN3ZsJW4DGOqtc4reZpryKgunH2mvxyOB 8s=; b=gZ8ervvsrnmNEdMgtB81Jm3jlwzQnc+o2hsQvz55+trV31J3LEvkYQ6ik zpKC+01+tI0cDO7wqHhkSxow7BqqJTMOhtXo0uBP/Nab0EUron4YjMCpmvssHrtj fQwOtvrz/ITpryz/8tTM+yQ+0UvWueG1gsJ1qy9MVCV04Yc4F9Ra/JYrzNX/sUtv Bow8sbEFTSsGWTxiY8o3TD6I+1OMEhDUxTZORWexPParLOtjm6+1Rl3bxIK4Q+c/ UhDxbaMmX2TlFtt/5Myg6ikU+YNqHzecc7n7WmVNW87N5CH+NmrUuFdl8sy9yint 0d5K2mVyd7+K59w+73/0mmcggdmgA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeehgdefiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 96FDAE4788; Thu, 18 Apr 2019 10:50:49 -0400 (EDT) From: Thomas Monjalon To: Arnon Warshavsky Cc: dev@dpdk.org, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, ranjit.menon@intel.com, anand.rawat@intel.com, Pallavi Kadam , Harini Ramakrishnan , "O'Hare, Cathal" Date: Thu, 18 Apr 2019 16:50:48 +0200 Message-ID: <3131803.2ETXjPmY0d@xps> In-Reply-To: <1524552123-31378-1-git-send-email-arnon@qwilt.com> References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418145048.4HhMwzqtrXuh7oPUu7qdUJQVRsxLzeOeeutFXRMGXkA@z> Hi, 24/04/2018 08:41, Arnon Warshavsky: > The purpose of this patch series is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation of the event. > > This patch modifies the majority of rte_panic calls > under lib and drivers, and replaces them with a log message > and an error return code according to context, > that can be propagated up the call stack. > > - Focus was given to the dpdk initialization path > - Some of the panic calls within drivers were left in place where > the call is from within an interrupt or calls that are > on the data path,where there is no simple applicative > route to propagate the error to temination. > These should be handled by the driver maintainers.. > - local void functions with no api were changed to retrun a value > where needed > - No change took place in example and test files > - No change took place for debug assertions calling panic > - A new function was added to devtools/checkpatches.sh > in order to prevent new additions of calls to rte_panic > under lib and drivers. > > Keep calm and don't panic What happened to this patchset? This is definitely an improvement. We must remove rte_panic from libs. Arnon, are you still available to rebase this patchset in preparation of 19.08? Or someone else? What are the required API breakages? I see one in ethdev which requires a deprecation notice to be sent for publishing in 19.05. Is there more rte_panic to remove?