From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by dpdk.org (Postfix) with ESMTP id 411BA1BA96 for ; Fri, 19 Apr 2019 10:08:07 +0200 (CEST) Received: by mail-wm1-f44.google.com with SMTP id w15so5600886wmc.3 for ; Fri, 19 Apr 2019 01:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v6icCwlRYprbi651oXGiR/PK/aNtx1gA0f4sjZh1bNM=; b=h3q3uhncxyC4asIKdwnEYbWeGYpryTzLoAAnhcgIWjkGdOt/9759a0PI7IuMw43+DV HFpsCAEJ5ic09/ptYG5+yK+/jOun9KoBW1MICTLDzu1S8zbOTaVQdgl/MQ0vHMktA3qc P+7wAP+vu2T6tnxn7t55J6ota+lR59YgbPHCA1wME3TpFwstZbCuEstJgLkYYY+/GBLm B1osx4LXCHKVRZEJlLORLumjyx5vcdl+YhF+RV9xZXhHr171eBe+VUd0dmPDK3i9XwxW BX6Me8PrQ+JZtHF10HG1on+4v+YbUb+9YM+nzEBDqedAGtpQycyg3d6hDxEpyZD9BOAf HKKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v6icCwlRYprbi651oXGiR/PK/aNtx1gA0f4sjZh1bNM=; b=qTeJIR1A9BwftJ7ON54S7oz63ueF/oY9MfNfPxFDUtEq89ImqcFdfYk9Z9I2SpVT6B 1/fr4TgweGgsCduhtPiLPB1kBA5SBu1hzMXGJMmLTov5Ch6+5QkGuSREZF069ADmRGjw neDIvCMGSirgLuLMN292Zlhj/VFzQih1UASNr76+QefuJ9hw2acnEWbdzmEzbgD4Suim m7U/zzSJww+TCCm4/YSQUgb1WAweZIoHrUwvb6PCU2RfyCb6gIeb1Klwb6zUX5LzK7wl Kyrf8uhlrH0yQaLKoLH2ytxzNVffd2hcxcxKa0tXAQjcVrV+v3kevfWC7fFDs3gdOlWT an9g== X-Gm-Message-State: APjAAAW5PJ0J+3Oev2eFDy4lyjlgefNlZO3g54U7Cp5CLDu1TNYN4xZ7 mBURjSLSNIwJWCtZweVaoPmAlg== X-Google-Smtp-Source: APXvYqyrvLq31tuc/5QeUchW/1CfFNLMEEj3INsy6szVsoc9L6l2v3IggGRmjsirDJzwa8ZibgoouA== X-Received: by 2002:a1c:f702:: with SMTP id v2mr1852421wmh.0.1555661286977; Fri, 19 Apr 2019 01:08:06 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k2sm5755224wrx.21.2019.04.19.01.08.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 01:08:05 -0700 (PDT) Date: Fri, 19 Apr 2019 10:08:03 +0200 From: Adrien Mazarguil To: David Marchand Cc: Gaetan Rivet , Ferruh Yigit , dev , Chas Williams <3chas3@gmail.com> Message-ID: <20190419080803.GJ4889@6wind.com> References: <20190418130419.25675-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 08:08:07 -0000 On Thu, Apr 18, 2019 at 04:06:31PM +0200, David Marchand wrote: > Hey Adrien, Hey David! > On Thu, Apr 18, 2019 at 3:12 PM Adrien Mazarguil > wrote: > > > When passed to the application, Rx packets retain the port ID value > > originally set by slave devices. Unfortunately these IDs have no meaning to > > applications, which are typically unaware of their existence. > > > > This confuses those caring about the source port field in mbufs (m->port) > > which experience issues ranging from traffic drop to crashes. > > > > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") > Not a big fan of those duplicated rx_burst functions... > Reviewed-by: David Marchand > > I suppose the bonding pmd has the same issue. I don't have much experience with it, however chances are that it's not as bad as with failsafe since bonding behaves more like a helper that applications knowingly use to aggregate ports they set up and already know about. Leaving the original port ID in this case may actually be useful, but could be optional. Failsafe on the other hand spawns and manages any number of sub-devices hidden from the application on its own based on opaque user configuration. These sub-devices may or may not be present depending on hot-plug events absorbed by failsafe, which means their port IDs are not only unexpected but also volatile. -- Adrien Mazarguil 6WIND From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BA30EA00E6 for ; Fri, 19 Apr 2019 10:08:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D5EA1BA9A; Fri, 19 Apr 2019 10:08:08 +0200 (CEST) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by dpdk.org (Postfix) with ESMTP id 411BA1BA96 for ; Fri, 19 Apr 2019 10:08:07 +0200 (CEST) Received: by mail-wm1-f44.google.com with SMTP id w15so5600886wmc.3 for ; Fri, 19 Apr 2019 01:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v6icCwlRYprbi651oXGiR/PK/aNtx1gA0f4sjZh1bNM=; b=h3q3uhncxyC4asIKdwnEYbWeGYpryTzLoAAnhcgIWjkGdOt/9759a0PI7IuMw43+DV HFpsCAEJ5ic09/ptYG5+yK+/jOun9KoBW1MICTLDzu1S8zbOTaVQdgl/MQ0vHMktA3qc P+7wAP+vu2T6tnxn7t55J6ota+lR59YgbPHCA1wME3TpFwstZbCuEstJgLkYYY+/GBLm B1osx4LXCHKVRZEJlLORLumjyx5vcdl+YhF+RV9xZXhHr171eBe+VUd0dmPDK3i9XwxW BX6Me8PrQ+JZtHF10HG1on+4v+YbUb+9YM+nzEBDqedAGtpQycyg3d6hDxEpyZD9BOAf HKKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v6icCwlRYprbi651oXGiR/PK/aNtx1gA0f4sjZh1bNM=; b=qTeJIR1A9BwftJ7ON54S7oz63ueF/oY9MfNfPxFDUtEq89ImqcFdfYk9Z9I2SpVT6B 1/fr4TgweGgsCduhtPiLPB1kBA5SBu1hzMXGJMmLTov5Ch6+5QkGuSREZF069ADmRGjw neDIvCMGSirgLuLMN292Zlhj/VFzQih1UASNr76+QefuJ9hw2acnEWbdzmEzbgD4Suim m7U/zzSJww+TCCm4/YSQUgb1WAweZIoHrUwvb6PCU2RfyCb6gIeb1Klwb6zUX5LzK7wl Kyrf8uhlrH0yQaLKoLH2ytxzNVffd2hcxcxKa0tXAQjcVrV+v3kevfWC7fFDs3gdOlWT an9g== X-Gm-Message-State: APjAAAW5PJ0J+3Oev2eFDy4lyjlgefNlZO3g54U7Cp5CLDu1TNYN4xZ7 mBURjSLSNIwJWCtZweVaoPmAlg== X-Google-Smtp-Source: APXvYqyrvLq31tuc/5QeUchW/1CfFNLMEEj3INsy6szVsoc9L6l2v3IggGRmjsirDJzwa8ZibgoouA== X-Received: by 2002:a1c:f702:: with SMTP id v2mr1852421wmh.0.1555661286977; Fri, 19 Apr 2019 01:08:06 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k2sm5755224wrx.21.2019.04.19.01.08.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 01:08:05 -0700 (PDT) Date: Fri, 19 Apr 2019 10:08:03 +0200 From: Adrien Mazarguil To: David Marchand Cc: Gaetan Rivet , Ferruh Yigit , dev , Chas Williams <3chas3@gmail.com> Message-ID: <20190419080803.GJ4889@6wind.com> References: <20190418130419.25675-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419080803.zzG5MoEqYEo-uLwlu5uvey9CjcGjyhpLYGV3DUMYNGw@z> On Thu, Apr 18, 2019 at 04:06:31PM +0200, David Marchand wrote: > Hey Adrien, Hey David! > On Thu, Apr 18, 2019 at 3:12 PM Adrien Mazarguil > wrote: > > > When passed to the application, Rx packets retain the port ID value > > originally set by slave devices. Unfortunately these IDs have no meaning to > > applications, which are typically unaware of their existence. > > > > This confuses those caring about the source port field in mbufs (m->port) > > which experience issues ranging from traffic drop to crashes. > > > > Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") > Not a big fan of those duplicated rx_burst functions... > Reviewed-by: David Marchand > > I suppose the bonding pmd has the same issue. I don't have much experience with it, however chances are that it's not as bad as with failsafe since bonding behaves more like a helper that applications knowingly use to aggregate ports they set up and already know about. Leaving the original port ID in this case may actually be useful, but could be optional. Failsafe on the other hand spawns and manages any number of sub-devices hidden from the application on its own based on opaque user configuration. These sub-devices may or may not be present depending on hot-plug events absorbed by failsafe, which means their port IDs are not only unexpected but also volatile. -- Adrien Mazarguil 6WIND