From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
rahul.lakkireddy@chelsio.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names
Date: Fri, 19 Apr 2019 09:15:12 +0100 [thread overview]
Message-ID: <a80f41b1-6bfc-8a68-a69c-83cef7693ffd@intel.com> (raw)
Message-ID: <20190419081512.pLuM1sAP7oUNLGmIfhDRhr9V93lRobvqEx52CC5zuWU@z> (raw)
In-Reply-To: <20190418233701.20793-1-stephen@networkplumber.org>
On 4/19/2019 12:37 AM, Stephen Hemminger wrote:
> This driver defines lots of functions (like init_rss) which are intended
> to only be used in this device. But when doing static linking these
> global functions cause link failures when similar function name is
> used in application.
>
> This patch prefixes all functions defined in cxgbe.h with cxgbe_
> to avoid these kind of conflicts.
+1, not static functions should have module prefix
>
> Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2019-04-19 8:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 23:37 Stephen Hemminger
2019-04-18 23:37 ` Stephen Hemminger
2019-04-19 8:15 ` Ferruh Yigit [this message]
2019-04-19 8:15 ` Ferruh Yigit
2019-04-19 10:05 ` Rahul Lakkireddy
2019-04-19 10:05 ` Rahul Lakkireddy
2019-04-19 10:04 ` Rahul Lakkireddy
2019-04-19 10:04 ` Rahul Lakkireddy
2019-04-19 11:38 ` Ferruh Yigit
2019-04-19 11:38 ` Ferruh Yigit
2019-04-19 11:44 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-04-19 11:44 ` Ferruh Yigit
2019-04-19 12:03 ` Rahul Lakkireddy
2019-04-19 12:03 ` Rahul Lakkireddy
2019-04-19 12:20 ` Ferruh Yigit
2019-04-19 12:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a80f41b1-6bfc-8a68-a69c-83cef7693ffd@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=rahul.lakkireddy@chelsio.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).