Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list

["Hunt, David" <david.hunt@intel.com>]

On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote:
> Removed dependency to mac_list from policies:
> * BRANCH_RATIO,
> * WORKLOAD,
> * TIME
> in function update_policy.
>
> Fixes: 1b897991473f ("power: update error handling")
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> ---
>   examples/vm_power_manager/channel_monitor.c | 18 +++++++++++++-----
>   1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
> index 74df0fe20..ad1ddde07 100644
> --- a/examples/vm_power_manager/channel_monitor.c
> +++ b/examples/vm_power_manager/channel_monitor.c
> @@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt)
>   			/* Copy the contents of *pkt into the policy.pkt */
>   			policies[i].pkt = *pkt;
>   			get_pcpu_to_control(&policies[i]);
> -			if (get_pfid(&policies[i]) < 0) {
> -				updated = 1;
> -				break;
> +			/* Check Eth dev only for Traffic policy */
> +			if (policies[i].pkt.policy_to_use == TRAFFIC) {
> +				if (get_pfid(&policies[i]) < 0) {
> +					updated = 1;
> +					break;
> +				}
>   			}
>   			core_share_status(i);
>   			policies[i].enabled = 1;
> @@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt)
>   			if (policies[i].enabled == 0) {
>   				policies[i].pkt = *pkt;
>   				get_pcpu_to_control(&policies[i]);
> -				if (get_pfid(&policies[i]) < 0)
> -					break;
> +				/* Check Eth dev only for Traffic policy */
> +				if (policies[i].pkt.policy_to_use == TRAFFIC) {
> +					if (get_pfid(&policies[i]) < 0) {
> +						updated = 1;
> +						break;
> +					}
> +				}
>   				core_share_status(i);
>   				policies[i].enabled = 1;
>   				break;


I hope it's OK to add Yufeng's Tested-by. As a new member to the mailing 
list, they've tested the patch, but does not have the original email to 
reply to.

Tested-by: Yufeng Mo <yufengx.mo@intel.com>