From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names
Date: Fri, 19 Apr 2019 15:35:52 +0530 [thread overview]
Message-ID: <20190419100551.GB11982@chelsio.com> (raw)
In-Reply-To: <a80f41b1-6bfc-8a68-a69c-83cef7693ffd@intel.com>
On Friday, April 04/19/19, 2019 at 13:45:12 +0530, Ferruh Yigit wrote:
> On 4/19/2019 12:37 AM, Stephen Hemminger wrote:
> > This driver defines lots of functions (like init_rss) which are intended
> > to only be used in this device. But when doing static linking these
> > global functions cause link failures when similar function name is
> > used in application.
> >
> > This patch prefixes all functions defined in cxgbe.h with cxgbe_
> > to avoid these kind of conflicts.
>
> +1, not static functions should have module prefix
>
Agreed. I still see some non-static functions missing cxgbe_
prefix. I'll analyze more and audit them.
> >
> > Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
Thanks,
Rahul
next prev parent reply other threads:[~2019-04-19 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 23:37 Stephen Hemminger
2019-04-18 23:37 ` Stephen Hemminger
2019-04-19 8:15 ` Ferruh Yigit
2019-04-19 8:15 ` Ferruh Yigit
2019-04-19 10:05 ` Rahul Lakkireddy [this message]
2019-04-19 10:05 ` Rahul Lakkireddy
2019-04-19 10:04 ` Rahul Lakkireddy
2019-04-19 10:04 ` Rahul Lakkireddy
2019-04-19 11:38 ` Ferruh Yigit
2019-04-19 11:38 ` Ferruh Yigit
2019-04-19 11:44 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2019-04-19 11:44 ` Ferruh Yigit
2019-04-19 12:03 ` Rahul Lakkireddy
2019-04-19 12:03 ` Rahul Lakkireddy
2019-04-19 12:20 ` Ferruh Yigit
2019-04-19 12:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419100551.GB11982@chelsio.com \
--to=rahul.lakkireddy@chelsio.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).