From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id CF61FA00E6
	for <public@inbox.dpdk.org>; Fri, 19 Apr 2019 12:09:58 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 96A891BB91;
	Fri, 19 Apr 2019 12:09:58 +0200 (CEST)
Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id 828781BB2E
 for <dev@dpdk.org>; Fri, 19 Apr 2019 12:09:56 +0200 (CEST)
Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94])
 by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x3JA9ssg018462;
 Fri, 19 Apr 2019 03:09:55 -0700
Date: Fri, 19 Apr 2019 15:35:52 +0530
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20190419100551.GB11982@chelsio.com>
References: <20190418233701.20793-1-stephen@networkplumber.org>
 <a80f41b1-6bfc-8a68-a69c-83cef7693ffd@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <a80f41b1-6bfc-8a68-a69c-83cef7693ffd@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [PATCH] net/cxgbe: fix colliding function names
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190419100552.9QWEGRzv0SFQJpYY21v1KO2fdPp4PTp25oDo-Pc74c4@z>

On Friday, April 04/19/19, 2019 at 13:45:12 +0530, Ferruh Yigit wrote:
> On 4/19/2019 12:37 AM, Stephen Hemminger wrote:
> > This driver defines lots of functions (like init_rss) which are intended
> > to only be used in this device. But when doing static linking these
> > global functions cause link failures when similar function name is
> > used in application.
> > 
> > This patch prefixes all functions defined in cxgbe.h with cxgbe_
> > to avoid these kind of conflicts.
> 
> +1, not static functions should have module prefix
> 

Agreed. I still see some non-static functions missing cxgbe_
prefix. I'll analyze more and audit them.

> > 
> > Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 

Thanks,
Rahul