DPDK patches and discussions
 help / color / mirror / Atom feed
From: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
To: Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com,
	Herakliusz Lipiec <herakliusz.lipiec@intel.com>,
	rasland@mellanox.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] net/tap: ipc add check for number of messages received
Date: Fri, 19 Apr 2019 11:28:52 +0100	[thread overview]
Message-ID: <20190419102852.45526-1-herakliusz.lipiec@intel.com> (raw)
Message-ID: <20190419102852.WpY59nuRPa_6ig9j07fjfq5P4282JnsEGtbIrwUxcyc@z> (raw)
In-Reply-To: <20190418171923.570-1-herakliusz.lipiec@intel.com>

A sucessfull call to rte_mp_request_sync does not guarantee that there
are any messages in the buffer, and this should be checked for before
accessing data in the message. Buffer can be empty if IPC is disabled or
if we deciede to ignore replies.

Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: rasland@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
---
 drivers/net/tap/rte_eth_tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index e9fda8cf6..7f74b5dc9 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2101,7 +2101,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
 	request.len_param = sizeof(*request_param);
 	/* Send request and receive reply */
 	ret = rte_mp_request_sync(&request, &replies, &timeout);
-	if (ret < 0) {
+	if (ret < 0 || replies.nb_received != 1) {
 		TAP_LOG(ERR, "Failed to request queues from primary: %d",
 			rte_errno);
 		return -1;
-- 
2.17.2


  parent reply	other threads:[~2019-04-19 10:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 17:19 [dpdk-dev] [PATCH] " Herakliusz Lipiec
2019-04-18 17:19 ` Herakliusz Lipiec
2019-04-18 18:13 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-18 18:13   ` Ferruh Yigit
2019-04-19 16:39   ` Lipiec, Herakliusz
2019-04-19 16:39     ` Lipiec, Herakliusz
2019-04-19 17:17     ` Ferruh Yigit
2019-04-19 17:17       ` Ferruh Yigit
2019-04-19 10:28 ` Herakliusz Lipiec [this message]
2019-04-19 10:28   ` [dpdk-dev] [PATCH v2] " Herakliusz Lipiec
2019-04-19 17:37   ` Ferruh Yigit
2019-04-19 17:37     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190419102852.45526-1-herakliusz.lipiec@intel.com \
    --to=herakliusz.lipiec@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=rasland@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).