From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 782F2A00E6
	for <public@inbox.dpdk.org>; Fri, 19 Apr 2019 12:49:26 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 474501BBA1;
	Fri, 19 Apr 2019 12:49:24 +0200 (CEST)
Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com
 [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id A54221BB2E
 for <dev@dpdk.org>; Fri, 19 Apr 2019 12:49:22 +0200 (CEST)
Received: by mail-vs1-f67.google.com with SMTP id s11so2718545vsn.0
 for <dev@dpdk.org>; Fri, 19 Apr 2019 03:49:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=/fk+yftunhSADVFawKY3Qy7LVndqK3hkPM2D8zJalq4=;
 b=BQVrctjoZj5PFWByhCeWXfUQw0mDn5Fgk5MAmeHfFJH1mE7b9uS5UfXkDrvaS5Wr/j
 UzV2mCpn6VoL5wrw6chhYPX6F1BcVMYOlFWvWsxban24ravm36gkMnAbHdjakuU90G7q
 8gFVZQPpmBgQQZcQ45Fu4pohGrldnzIsI5/Oi91wJ43UffC7CBs+dczbapiXxvvkLnVA
 nFuIOrRrmZm1EHfZVIlX8T4NGl2fljPjEa2eNfx+AyDe9ZizIZNMFIGeJ/pfhNVhmLhb
 a7yGGv5A6felOklVNQiJ7uIdG5hB/oZ9kskfjwNB6X49PYCrPNxU1cIAS6g7LgrfMAgq
 QxLQ==
X-Gm-Message-State: APjAAAXF/efTtoMN2tUhLmbpNxknT6zSdrXGlwp3Hh0KY0BnFJqq2Nd5
 mi4a9K+QDtF/4fF/iRTCWeX5YO04JiWoj76XwBKPfw==
X-Google-Smtp-Source: APXvYqyNo6r94gAIIIngvpklGPM+3kb7SgKbrvj8ZvNRAuLQ2xyj+H1BfVJlFTKoRlUj4OOH/8SbQ+YdJb0f1CNO+hA=
X-Received: by 2002:a67:eb57:: with SMTP id x23mr1662284vso.39.1555670961988; 
 Fri, 19 Apr 2019 03:49:21 -0700 (PDT)
MIME-Version: 1.0
References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com>
In-Reply-To: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 19 Apr 2019 12:49:10 +0200
Message-ID:
 <CAJFAV8xCPneNihvUNLv0NmhUCnd1_eH03ss8mxZwYUwUgpJbcw@mail.gmail.com>
To: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Cc: dev <dev@dpdk.org>, "Trahe, Fiona" <fiona.trahe@intel.com>, 
 Yongseok Koh <yskoh@mellanox.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190419104910.hX2sbPo58iehWVVxY7b3OO-3uEzsZuypt3OmIIx9rxM@z>

On Fri, Apr 19, 2019 at 11:57 AM Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
wrote:

> Fixed the compilation error on gcc (GCC)
> 4.8.5 20150623 (Red Hat 4.8.5-28)
>
> Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> ---
>  app/test/test_compressdev.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index 404b98f..603eeea 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -1948,6 +1948,7 @@ test_compressdev_deflate_stateless_dynamic_big(void)
>         struct comp_testsuite_params *ts_params = &testsuite_params;
>         uint16_t i = 0;
>         int ret = TEST_SUCCESS;
> +       int j = 0;
>

Useless initialisation.

        const struct rte_compressdev_capabilities *capab;
>         char *test_buffer = NULL;
>
> @@ -1989,8 +1990,8 @@ test_compressdev_deflate_stateless_dynamic_big(void)
>
>         /* fill the buffer with data based on rand. data */
>         srand(BIG_DATA_TEST_SIZE);
> -       for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i)
> -               test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
> +       for (j = 0; j < BIG_DATA_TEST_SIZE - 1; ++j)
> +               test_buffer[j] = (uint8_t)(rand() % ((uint8_t)-1)) | 1;
>
>         test_buffer[BIG_DATA_TEST_SIZE-1] = 0;
>         int_data.buf_idx = &i;
> --
> 2.7.4
>

Tested-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand