From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by dpdk.org (Postfix) with ESMTP id F27EE1B5DF; Fri, 19 Apr 2019 14:07:24 +0200 (CEST) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x3JC7Mr4019560; Fri, 19 Apr 2019 05:07:23 -0700 Date: Fri, 19 Apr 2019 17:33:20 +0530 From: Rahul Lakkireddy To: Ferruh Yigit Cc: "dev@dpdk.org" , Stephen Hemminger , "stable@dpdk.org" Message-ID: <20190419120319.GA12160@chelsio.com> References: <20190418233701.20793-1-stephen@networkplumber.org> <20190419114425.46299-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190419114425.46299-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v2] net/cxgbe: fix colliding function names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 12:07:25 -0000 On Friday, April 04/19/19, 2019 at 17:14:25 +0530, Ferruh Yigit wrote: > From: Stephen Hemminger > > This driver defines lots of functions (like init_rss) which are intended > to only be used in this device. But when doing static linking these > global functions cause link failures when similar function name is > used in application. > > This patch prefixes all functions defined in cxgbe.h with cxgbe_ > to avoid these kind of conflicts. > > Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF") > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger > Reviewed-by: Ferruh Yigit Acked-by: Rahul Lakkireddy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0C41BA00E6 for ; Fri, 19 Apr 2019 14:07:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 853B31B5FD; Fri, 19 Apr 2019 14:07:26 +0200 (CEST) Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by dpdk.org (Postfix) with ESMTP id F27EE1B5DF; Fri, 19 Apr 2019 14:07:24 +0200 (CEST) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x3JC7Mr4019560; Fri, 19 Apr 2019 05:07:23 -0700 Date: Fri, 19 Apr 2019 17:33:20 +0530 From: Rahul Lakkireddy To: Ferruh Yigit Cc: "dev@dpdk.org" , Stephen Hemminger , "stable@dpdk.org" Message-ID: <20190419120319.GA12160@chelsio.com> References: <20190418233701.20793-1-stephen@networkplumber.org> <20190419114425.46299-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190419114425.46299-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v2] net/cxgbe: fix colliding function names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419120320.Rma20dyPpdfUNx1yWojahuWTRcojbqGEebS2cjcbVKI@z> On Friday, April 04/19/19, 2019 at 17:14:25 +0530, Ferruh Yigit wrote: > From: Stephen Hemminger > > This driver defines lots of functions (like init_rss) which are intended > to only be used in this device. But when doing static linking these > global functions cause link failures when similar function name is > used in application. > > This patch prefixes all functions defined in cxgbe.h with cxgbe_ > to avoid these kind of conflicts. > > Fixes: bfcb257d3014 ("net/cxgbe: enable RSS for VF") > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger > Reviewed-by: Ferruh Yigit Acked-by: Rahul Lakkireddy