From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id ADB6DA00E6
	for <public@inbox.dpdk.org>; Fri, 19 Apr 2019 14:10:04 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5A4631B5A7;
	Fri, 19 Apr 2019 14:10:04 +0200 (CEST)
Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com
 [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 019694F9A
 for <dev@dpdk.org>; Fri, 19 Apr 2019 14:10:03 +0200 (CEST)
Received: by mail-vs1-f67.google.com with SMTP id e2so2758674vsc.13
 for <dev@dpdk.org>; Fri, 19 Apr 2019 05:10:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=KEfXKFMWvEpnKjyqT3LPdPVyqsJTXNZUtTnFslnzSck=;
 b=rAuHiK5+2BjdoCjFCjQYSl0ChoC2J2KnvN2qwj5AepRxsxCJb3uIpYfZ0ZBzq933iu
 bhG0pXej1PyesjxfxGt+rQe6344dNNTqtFvLn/W7GzUqjLOhGKlzfuJpF1QTFQ7oRoNA
 uak+bN6nOl2KTZtqftQbyGwHkQQB1g+xdQFAB/O3NVD1LDwxyvc6owiRy38ppCCkqiHC
 nxsBZqjchhjBwtfkkZhSH0Jgs/tLMQXuDBAjdqv3Mi5HiwPJihoENnLpq+AOhw5G4HQZ
 S0/rYlev8yMt1sABirf7NcFEgx1bOTyDqZIVuhFcs1X5kxrhRvQBU2XcPH00ZlK+fxCk
 omSQ==
X-Gm-Message-State: APjAAAXMeLXMmk0X/vxB22zQIDQF5SECLoJoRRtJnEzbkxAbl2TVspJ2
 R3gGI4brZk1fQqYMDFEKnMjsT+h42FmHiIxxGJCl1Q==
X-Google-Smtp-Source: APXvYqzLxHRjDW1rC1yuT5215reJKqeeYPi8mAXeZFWaGhudRJXoI0DYIv5NsZ6sJtN/mCqlkvUn5tNHLApmLn9wfzQ=
X-Received: by 2002:a67:edcb:: with SMTP id e11mr1826442vsp.105.1555675802355; 
 Fri, 19 Apr 2019 05:10:02 -0700 (PDT)
MIME-Version: 1.0
References: <20190419120327.29752-1-bruce.richardson@intel.com>
In-Reply-To: <20190419120327.29752-1-bruce.richardson@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 19 Apr 2019 14:09:51 +0200
Message-ID:
 <CAJFAV8y9OjwGwUD-N2uqFgyZTEMGDvpwnX=KBCr+k+K7jfr0vA@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, 
 dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190419120951.BqXoaSYSQ4gybSk4HqhtRAGIyBCpHVS6UvGBUYP7o3o@z>

nit: "test/compress:" for the title prefix ?

On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson <bruce.richardson@intel.com>
wrote:

> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
>
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: pablo.de.lara.guarch@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> I sent this previously, but I don't think it made the public list, so
> resending.
> Apologies to anyone who gets this twice!
> ---
>  app/test/test_compressdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index 404b98f60..121514af5 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -5,6 +5,7 @@
>  #include <zlib.h>
>  #include <math.h>
>  #include <stdlib.h>
> +#include <unistd.h>
>
>  #include <rte_cycles.h>
>  #include <rte_malloc.h>
> --
> 2.20.1
>
>
Tested on FreeBSD 10.4.
Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand