* [dpdk-dev] [PATCH] app/test: fix missing header
@ 2019-04-19 12:03 Bruce Richardson
2019-04-19 12:03 ` Bruce Richardson
2019-04-19 12:09 ` [dpdk-dev] [dpdk-stable] " David Marchand
0 siblings, 2 replies; 8+ messages in thread
From: Bruce Richardson @ 2019-04-19 12:03 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, pablo.de.lara.guarch, stable
Build of test_compressdev.c fails on FreeBSD due to the missing
include of unistd.h, to provide the function usleep.
Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
Cc: pablo.de.lara.guarch@intel.com
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
I sent this previously, but I don't think it made the public list, so resending.
Apologies to anyone who gets this twice!
---
app/test/test_compressdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index 404b98f60..121514af5 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -5,6 +5,7 @@
#include <zlib.h>
#include <math.h>
#include <stdlib.h>
+#include <unistd.h>
#include <rte_cycles.h>
#include <rte_malloc.h>
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH] app/test: fix missing header
2019-04-19 12:03 [dpdk-dev] [PATCH] app/test: fix missing header Bruce Richardson
@ 2019-04-19 12:03 ` Bruce Richardson
2019-04-19 12:09 ` [dpdk-dev] [dpdk-stable] " David Marchand
1 sibling, 0 replies; 8+ messages in thread
From: Bruce Richardson @ 2019-04-19 12:03 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, pablo.de.lara.guarch, stable
Build of test_compressdev.c fails on FreeBSD due to the missing
include of unistd.h, to provide the function usleep.
Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
Cc: pablo.de.lara.guarch@intel.com
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
I sent this previously, but I don't think it made the public list, so resending.
Apologies to anyone who gets this twice!
---
app/test/test_compressdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
index 404b98f60..121514af5 100644
--- a/app/test/test_compressdev.c
+++ b/app/test/test_compressdev.c
@@ -5,6 +5,7 @@
#include <zlib.h>
#include <math.h>
#include <stdlib.h>
+#include <unistd.h>
#include <rte_cycles.h>
#include <rte_malloc.h>
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
2019-04-19 12:03 [dpdk-dev] [PATCH] app/test: fix missing header Bruce Richardson
2019-04-19 12:03 ` Bruce Richardson
@ 2019-04-19 12:09 ` David Marchand
2019-04-19 12:09 ` David Marchand
2019-04-19 12:12 ` Bruce Richardson
1 sibling, 2 replies; 8+ messages in thread
From: David Marchand @ 2019-04-19 12:09 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Pablo de Lara, dpdk stable
nit: "test/compress:" for the title prefix ?
On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson <bruce.richardson@intel.com>
wrote:
> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
>
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: pablo.de.lara.guarch@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> I sent this previously, but I don't think it made the public list, so
> resending.
> Apologies to anyone who gets this twice!
> ---
> app/test/test_compressdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index 404b98f60..121514af5 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -5,6 +5,7 @@
> #include <zlib.h>
> #include <math.h>
> #include <stdlib.h>
> +#include <unistd.h>
>
> #include <rte_cycles.h>
> #include <rte_malloc.h>
> --
> 2.20.1
>
>
Tested on FreeBSD 10.4.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
2019-04-19 12:09 ` [dpdk-dev] [dpdk-stable] " David Marchand
@ 2019-04-19 12:09 ` David Marchand
2019-04-19 12:12 ` Bruce Richardson
1 sibling, 0 replies; 8+ messages in thread
From: David Marchand @ 2019-04-19 12:09 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Pablo de Lara, dpdk stable
nit: "test/compress:" for the title prefix ?
On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson <bruce.richardson@intel.com>
wrote:
> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
>
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: pablo.de.lara.guarch@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> I sent this previously, but I don't think it made the public list, so
> resending.
> Apologies to anyone who gets this twice!
> ---
> app/test/test_compressdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index 404b98f60..121514af5 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -5,6 +5,7 @@
> #include <zlib.h>
> #include <math.h>
> #include <stdlib.h>
> +#include <unistd.h>
>
> #include <rte_cycles.h>
> #include <rte_malloc.h>
> --
> 2.20.1
>
>
Tested on FreeBSD 10.4.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
2019-04-19 12:09 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-04-19 12:09 ` David Marchand
@ 2019-04-19 12:12 ` Bruce Richardson
2019-04-19 12:12 ` Bruce Richardson
2019-04-19 21:17 ` Thomas Monjalon
1 sibling, 2 replies; 8+ messages in thread
From: Bruce Richardson @ 2019-04-19 12:12 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Pablo de Lara, dpdk stable
On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
> nit: "test/compress:" for the title prefix ?
maybe so, half the time I never know what to prefix autotest stuff like
this with! :-) Thomas, please fix on apply, if possible.
> On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
> <[1]bruce.richardson@intel.com> wrote:
>
> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: [2]pablo.de.lara.guarch@intel.com
> Cc: [3]stable@dpdk.org
> Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com>
> ---
> I sent this previously, but I don't think it made the public list,
> so resending.
> Apologies to anyone who gets this twice!
> ---
> app/test/test_compressdev.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/app/test/test_compressdev.c
> b/app/test/test_compressdev.c
> index 404b98f60..121514af5 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -5,6 +5,7 @@
> #include <zlib.h>
> #include <math.h>
> #include <stdlib.h>
> +#include <unistd.h>
> #include <rte_cycles.h>
> #include <rte_malloc.h>
> --
> 2.20.1
>
> Tested on FreeBSD 10.4.
> Reviewed-by: David Marchand <[5]david.marchand@redhat.com>
> --
> David Marchand
>
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
2019-04-19 12:12 ` Bruce Richardson
@ 2019-04-19 12:12 ` Bruce Richardson
2019-04-19 21:17 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: Bruce Richardson @ 2019-04-19 12:12 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Pablo de Lara, dpdk stable
On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
> nit: "test/compress:" for the title prefix ?
maybe so, half the time I never know what to prefix autotest stuff like
this with! :-) Thomas, please fix on apply, if possible.
> On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
> <[1]bruce.richardson@intel.com> wrote:
>
> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: [2]pablo.de.lara.guarch@intel.com
> Cc: [3]stable@dpdk.org
> Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com>
> ---
> I sent this previously, but I don't think it made the public list,
> so resending.
> Apologies to anyone who gets this twice!
> ---
> app/test/test_compressdev.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/app/test/test_compressdev.c
> b/app/test/test_compressdev.c
> index 404b98f60..121514af5 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -5,6 +5,7 @@
> #include <zlib.h>
> #include <math.h>
> #include <stdlib.h>
> +#include <unistd.h>
> #include <rte_cycles.h>
> #include <rte_malloc.h>
> --
> 2.20.1
>
> Tested on FreeBSD 10.4.
> Reviewed-by: David Marchand <[5]david.marchand@redhat.com>
> --
> David Marchand
>
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
2019-04-19 12:12 ` Bruce Richardson
2019-04-19 12:12 ` Bruce Richardson
@ 2019-04-19 21:17 ` Thomas Monjalon
2019-04-19 21:17 ` Thomas Monjalon
1 sibling, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2019-04-19 21:17 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, David Marchand, Pablo de Lara, dpdk stable
19/04/2019 14:12, Bruce Richardson:
> On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
> > nit: "test/compress:" for the title prefix ?
>
> maybe so, half the time I never know what to prefix autotest stuff like
> this with! :-) Thomas, please fix on apply, if possible.
In this case, you can just copy the prefix from the "Fixes:" line :)
> > On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
> > <[1]bruce.richardson@intel.com> wrote:
> >
> > Build of test_compressdev.c fails on FreeBSD due to the missing
> > include of unistd.h, to provide the function usleep.
> > Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> > Cc: [2]pablo.de.lara.guarch@intel.com
> > Cc: [3]stable@dpdk.org
> > Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com>
> >
> > Tested on FreeBSD 10.4.
> > Reviewed-by: David Marchand <[5]david.marchand@redhat.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
2019-04-19 21:17 ` Thomas Monjalon
@ 2019-04-19 21:17 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-04-19 21:17 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, David Marchand, Pablo de Lara, dpdk stable
19/04/2019 14:12, Bruce Richardson:
> On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
> > nit: "test/compress:" for the title prefix ?
>
> maybe so, half the time I never know what to prefix autotest stuff like
> this with! :-) Thomas, please fix on apply, if possible.
In this case, you can just copy the prefix from the "Fixes:" line :)
> > On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
> > <[1]bruce.richardson@intel.com> wrote:
> >
> > Build of test_compressdev.c fails on FreeBSD due to the missing
> > include of unistd.h, to provide the function usleep.
> > Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> > Cc: [2]pablo.de.lara.guarch@intel.com
> > Cc: [3]stable@dpdk.org
> > Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com>
> >
> > Tested on FreeBSD 10.4.
> > Reviewed-by: David Marchand <[5]david.marchand@redhat.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-19 21:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-19 12:03 [dpdk-dev] [PATCH] app/test: fix missing header Bruce Richardson
2019-04-19 12:03 ` Bruce Richardson
2019-04-19 12:09 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-04-19 12:09 ` David Marchand
2019-04-19 12:12 ` Bruce Richardson
2019-04-19 12:12 ` Bruce Richardson
2019-04-19 21:17 ` Thomas Monjalon
2019-04-19 21:17 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).