From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BACF2A00E6 for ; Fri, 19 Apr 2019 14:15:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 814C51BC06; Fri, 19 Apr 2019 14:15:11 +0200 (CEST) Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by dpdk.org (Postfix) with ESMTP id 395981BBF2; Fri, 19 Apr 2019 14:15:09 +0200 (CEST) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x3JCF1dA019597; Fri, 19 Apr 2019 05:15:02 -0700 Date: Fri, 19 Apr 2019 17:40:59 +0530 From: Rahul Lakkireddy To: Ferruh Yigit Cc: "dev@dpdk.org" , Nirranjan Kirubaharan , Indranil Choudhury , "stable@dpdk.org" , Kevin Traynor , Luca Boccassi , Yongseok Koh Message-ID: <20190419121054.GB12160@chelsio.com> References: <1555665721-11883-1-git-send-email-rahul.lakkireddy@chelsio.com> <20190419094925.GA11969@chelsio.com> <21fc74df-e565-64fd-1f58-03bb3512a0ea@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <21fc74df-e565-64fd-1f58-03bb3512a0ea@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419121059.9_bBkOMOBGN-EC4TuXe401dRfM4ePvvSQRQzVhmWIYo@z> On Friday, April 04/19/19, 2019 at 16:48:55 +0530, Ferruh Yigit wrote: > On 4/19/2019 10:49 AM, Rahul Lakkireddy wrote: > > Hi Ferruh, > > > > On Friday, April 04/19/19, 2019 at 15:00:32 +0530, Ferruh Yigit wrote: > >> On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote: > >>> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards") > >> > >> Why this is a fix, isn't this just adding new device ids? > >> > >> > >>> Cc: stable@dpdk.org > >> > >> What about keeping 'stable' tag to request the backport but remove the fix? > >> > > > > It's fixing probe for these new devices. Let me know if this particular > > case doesn't require the fixes line and I will send v2 with only the > > stable tag. > > No need a v2, if you are agree I can remove while merging. > > The commit is not fixing any old code in DPDK, if the intention of making this > patch a fix is to backport the patch, we can do same via stable tag, fix not needed. > If these devices were ready at that time, in 17.08, but forgotten in that commit > to be added, than I see the fix but this looks unlikely since it is almost two > years ago. > Ok, please remove the fixes line during merge. > > > >>> > >>> Signed-off-by: Rahul Lakkireddy > >> > > Thanks, Rahul