DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
Date: Fri, 19 Apr 2019 13:12:39 +0100	[thread overview]
Message-ID: <20190419121239.GA1843@bricha3-MOBL.ger.corp.intel.com> (raw)
Message-ID: <20190419121239.tAUkhW8toN6x8es3fpSNAnBaaDiMtGU4F6gIgCmPKws@z> (raw)
In-Reply-To: <CAJFAV8y9OjwGwUD-N2uqFgyZTEMGDvpwnX=KBCr+k+K7jfr0vA@mail.gmail.com>

On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
>    nit: "test/compress:" for the title prefix ?

maybe so, half the time I never know what to prefix autotest stuff like
this with! :-) Thomas, please fix on apply, if possible.

>    On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
>    <[1]bruce.richardson@intel.com> wrote:
> 
>      Build of test_compressdev.c fails on FreeBSD due to the missing
>      include of unistd.h, to provide the function usleep.
>      Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
>      Cc: [2]pablo.de.lara.guarch@intel.com
>      Cc: [3]stable@dpdk.org
>      Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com>
>      ---
>      I sent this previously, but I don't think it made the public list,
>      so resending.
>      Apologies to anyone who gets this twice!
>      ---
>       app/test/test_compressdev.c | 1 +
>       1 file changed, 1 insertion(+)
>      diff --git a/app/test/test_compressdev.c
>      b/app/test/test_compressdev.c
>      index 404b98f60..121514af5 100644
>      --- a/app/test/test_compressdev.c
>      +++ b/app/test/test_compressdev.c
>      @@ -5,6 +5,7 @@
>       #include <zlib.h>
>       #include <math.h>
>       #include <stdlib.h>
>      +#include <unistd.h>
>       #include <rte_cycles.h>
>       #include <rte_malloc.h>
>      --
>      2.20.1
> 
>    Tested on FreeBSD 10.4.
>    Reviewed-by: David Marchand <[5]david.marchand@redhat.com>
>    --
>    David Marchand
> 
Thanks,
/Bruce

  parent reply	other threads:[~2019-04-19 12:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19 12:03 [dpdk-dev] " Bruce Richardson
2019-04-19 12:03 ` Bruce Richardson
2019-04-19 12:09 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-04-19 12:09   ` David Marchand
2019-04-19 12:12   ` Bruce Richardson [this message]
2019-04-19 12:12     ` Bruce Richardson
2019-04-19 21:17     ` Thomas Monjalon
2019-04-19 21:17       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190419121239.GA1843@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).